xref: /vpp/
History log of /vpp/
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
a273ce62 24-Jan-2020 John DeNisco <jdenisco@cisco.com>

docs: Update the requirements and fix the build

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: I30e37f7e549083337b11ace95b4ff4f427d9fc8c

d539e256 16-Jan-2020 Matthew Smith <mgsmith@netgate.com>

nat: in2out-output nodes work with acl reflect

Type: feature

The current feature ordering of NAT44 nodes with respect to the
ACL plugin's IPv4 input/output features is:

ip4-output: acl-plugin-out-ip4-fa runs before any NAT44 nodes
ip4-unicast: acl-plugin-in-ip4-fa runs before any NAT44 nodes

ACL rules with action permit+reflect can keep track of outbound
flows and allow the replies inbound without an explicit inbound rule.
If ACL permit+reflect rules are configured on an interface that also
has NAT44 configured with output-feature/postrouting translation of
outbound packets, the ACL rules cannot allow inbound packets. The
ACL state that was stored on the outbound flow contains the IP
addresses of the original packet, prior to translation. The inbound
packets are being evaluated by the ACL node using the translated
addresses.

The order of processing inbound needs to be the opposite of what it
was outbound for this to work. Change the NAT44 features on
ip4-output so that they run before outbound ACL nodes. This matches
the existing behavior of the NAT44 nodes which rewrite
source addresses as an input feature instead of an output feature.

This was only done for endpoint dependent mode because the regular
endpoint independent in2out-output node currently selects an
explicit next node rather than using the next node on the feature
arc.

Unit test added to configure both NAT and an ACL and ensure that
out2in packets matching an in2out flow are permitted by the ACL
and translated by NAT.

Change-Id: Ibd679c28b64c3fc3cc8c0606ea93123e384e839f
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

ddb90a06 22-Jan-2020 Florin Coras <fcoras@cisco.com>

vcl: always report EPOLLHUP/EPOLLRDHUP on close

Type: fix

Change-Id: I3d24a7973c7113ffeb9109e89cda7fa960e73a5b
Signed-off-by: Florin Coras <fcoras@cisco.com>

68b7e588 22-Jan-2020 Florin Coras <fcoras@cisco.com>

vcl session: udp session migration notifications

Type: feature

Change-Id: I402549818ba6e078802e914293304174dc6625c2
Signed-off-by: Florin Coras <fcoras@cisco.com>

87e64c92 29-Nov-2019 Benoît Ganne <bganne@cisco.com>

docs: add AddressSanitizer mini-howto

Type: docs

Change-Id: I3bb589d04f15a03166a6d457552ffc316fb02f94
Signed-off-by: Benoît Ganne <bganne@cisco.com>

221b3839 16-Jan-2020 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile: fix the converity issue

Type: fix

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I358a290f4ac121f075f7ee52941beabe478bfba0

f66f8838 23-Jan-2020 Dave Barach <dave@barachs.net>

api: mark api_trace_command_fn thread-safe

Binary API trace replay with multiple worker threads depends in many
cases on worker thread graph replica maintenance. If we (implicitly)
assert a worker thread barrier at the debug CLI level, all graph
replica changes are deferred until the replay operation completes. If
an interface is deleted, the wheels may fall off.

Type: fix
Ticket: VPP-1824

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b07d43f8501caa5519e5ff9ae4c19dc2661cc84

7ec120e8 21-Jan-2020 Neale Ranns <nranns@cisco.com>

ipsec: re-enable DPDK IPSec for tunnel decap/encap (VPP-1823)

Type: fix

Change-Id: Iff9b1960b122f7d326efc37770b4ae3e81eb3122
Signed-off-by: Neale Ranns <nranns@cisco.com>

66300f6a 12-Jan-2020 Neale Ranns <nranns@cisco.com>

fib: Adjacency realloc during rewrite update walk (VPP-1822)

Type: fix

Change-Id: I0e826284c50713d322ee7943d87fd3363cfbdfbc
Signed-off-by: Neale Ranns <nranns@cisco.com>

f5c7305c 22-Jan-2020 Florin Coras <fcoras@cisco.com>

hsa: proxy app fixes

Type: fix

Change-Id: Icb4b331c9346d3781f4ddd6f62891c78d4059c1f
Signed-off-by: Florin Coras <fcoras@cisco.com>

da5dedfe 20-Jan-2020 Neale Ranns <nranns@cisco.com>

fib: FIB crash removing labelled route (VPP-1818)

Type: fix

The crash occured trying to retreive a NULL path list to walk the path
extensions. A walk shoul not be required, because there should be no
extensins, since all paths are removed. The problem is that when the
paths were added, they were not sorted, hence neither were the
extensions and when they were updated, duplicate extensions were added,
and hence a path removal did not remove them all.
Fix is to make sure paths are sorted.

Change-Id: I069d937de8e7bc8aae3d92f588db4daff727d863
Signed-off-by: Neale Ranns <nranns@cisco.com>
(cherry picked from commit 257749c40946a9269140d322e374d74c3b6eefb8)

c0c4eec3 21-Jan-2020 Dave Wallace <dwallacelf@gmail.com>

nsim: enable output scheduling on main thread

Type: fix

Change-Id: I5d47cb9bc7eb7f3c8485e3b42f0701e81d87ba2a
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

54eda4bc 14-Jan-2020 Alexander Chernavin <achernavin@netgate.com>

nat: fix dhcp client on outside interface with output feature

There was an attempt to fix this problem in the commit:
d3b8c861a44e70c197ab721fa3ce7f38bbeab7fd

But checking the LOCALLY_ORIGINATED flag didn't work because this flag
gets reset before it can reach the NAT nodes.

With this commit, replace the check for the LOCALLY_ORIGINATED flag
with a check to see if the packet is a DHCP broadcast.

Type: fix

Change-Id: I069c08a785b5988b10192f528e4f9c4c7cc2f8a3
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>

2b4e7401 17-Jan-2020 Filip Varga <fivarga@cisco.com>

nat: removed obsolete fragmentation code

Type: fix
Ticket: VPP-1817

Signed-off-by: Filip Varga <fivarga@cisco.com>
Change-Id: Id4d694ce636b0a213e65ce27c32a8150df9af0f8

cd681ada 16-Jan-2020 Florin Coras <fcoras@cisco.com>

classify: fix pcap filter set init

Type: fix

Change-Id: I6a48a6c14bfb84b3460e8211021bc9df6e915dba
Signed-off-by: Florin Coras <fcoras@cisco.com>

db43bb6a 08-Jan-2020 Yulong Pei <yulong.pei@intel.com>

lb: fix that lb_add_del_vip and lb_add_del_as api doesn't work correctly

Currently if user want to set ip4 address to the api, it must convert to ip6
format, e.g. user want to ip4 "90.1.2.1" but must convert to "::5A01:0201",
it is not acceptable, this fix solved the issue.

Ticket: FDIO-753
Type: fix

Change-Id: I2ffa5a3d38400ee176cf601421074f71fc395f03
Signed-off-by: Yulong Pei <yulong.pei@intel.com>

720435d0 16-Jan-2020 Filip Varga <fivarga@cisco.com>

nat: refactor of port/address allocation functions

Change-Id: Ie2a3c0f44322dd8415603b7ce51bb72d72769c95
Ticket: VPP-1815
Type: refactor
Signed-off-by: Filip Varga <fivarga@cisco.com>

13e6fce7 07-Dec-2019 Ahmed Abdelsalam <ahabdels@cisco.com>

sr: some fixes for SRv6 CLI/API

Return FIB table_id instead of vrf_index to clients

Type: fix
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I76a97bad3ecd3ac8eb045efb1657eaa90c2a57b6

1bf83b9d 16-Jan-2020 Steven Luong <sluong@cisco.com>

misc: binary-api sw_interface_vhost_user_dump is broken

Recent modificaton to vhost_user APIs for typing which added a sw_if_index
filter to the API sw_interface_vhost_user_dump with the default value -1 to
mean all interfaces. But the default is not set from api_format.c, causing the
binary-api command for sw_interface_vhost_user_dump to display nothing.

Also missing is the proper display on custom dump for the aformentioned API.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I05546e2318165af7531977fbed66ea7224c4a7ce

a420c5e6 16-Jan-2020 Steven Luong <sluong@cisco.com>

gso: fix typo in the quad-loop

Fix minor typo in the quad-loop for swif which may actually causes problem
if swif0 != swif1 or swif2 or swif3.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ib81f323479c7ecbd28d84956cffbc20b1072d2c2

6e20e035 27-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix typo in test doc string

Type: test

Change-Id: I97e02ebc5989eee794511c1ed6049e300be7d64e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

67a7749c 11-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix TypeError in run_tests.py

Traceback (most recent call last):
File "run_tests.py", line 886, in <module>
exit_code, suites = parse_results(results)
File "run_tests.py", line 732, in parse_results
results_per_suite.print_results()
File "run_tests.py", line 683, in print_results
result.get_testcase_names(failed_test_id)
TypeError: 'NoneType' object is not iterable

Type: test

Change-Id: I2c5ae0b9e11be6bfb4490d9ce057db0b0a84c9bf
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

56cef059 15-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix rxt delivered without sacks

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I69c245cb0e3f6d599a3270a485fa0a5845cde8eb

6e3c1f8e 15-Jan-2020 Florin Coras <fcoras@cisco.com>

vcl: add rx event on epoll ctl if needed

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ib6d0387076a4bb0b52e4cdfdcd62b6060b704fe6

ff2fad17 15-Jan-2020 Florin Coras <fcoras@cisco.com>

udp: fix ipv6 listen port registration

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I7f2233eb9bf3d81a697f76ba985083cf1040e2e9

de7fcacb 16-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix listen node coverity warning

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If5ec3ec4f46d3840c2b3c3005f093b5dddefc289

f0bae64f 15-Jan-2020 Vijayabhaskar Katamreddy <vkatamre@cisco.com>

vppinfra: fixing compilation issues in 32-bit

Fixing compilation issuues for 32-bit also setting init flag for shm based bihash

Type: fix
Signed-off-by: Vijayabhaskar Katamreddy <vkatamre@cisco.com>
Change-Id: Ic2072c5ba7fc77d061ca9f1b844a71f6e22e58b2

c171d01c 16-Jan-2020 Chris Luke <chrisy@flirble.org>

build: Add missing version.h dependency in vnet

Two modules in vnet include vpp/app/version.h but there is
no explicit build dependency for this generated file. This
leaves a race condition in the build system that the Coverity
build has recently started triggering.

Change-Id: I8e2bb32feeb16e1bdd8efb0d2633cfdba60f51aa
Type: fix
Signed-off-by: Chris Luke <chrisy@flirble.org>

bed0f4a4 15-Jan-2020 Andrew Yourtchenko <ayourtch@gmail.com>

misc: Initial 20.05-rc0 commit

Type: docs

Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I935a28d96078629607b23ce9c2aecec47e88b0b1
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

8ad070e1 15-Jan-2020 Klement Sekera <ksekera@cisco.com>

ip: align reass.save_rewrite_length

By aligning vnet_buffer_opaque.ip.save_rewrite_length and
vnet_buffer_opaque.ip.reass.save_rewrite_length we prevent shallow
virtual reassembly code from overwrite save_rewrite_length, allowing
other features down the pipe to rely on this value.

A static assert is added to guard this alignment.

Type: fix
Fixes: f126e746fc01c75bc99329d10ce9127b26b23814

Change-Id: Ie7c7f3abc2a221bbcf2830c0f006a4368088b342
Signed-off-by: Klement Sekera <ksekera@cisco.com>

e5060b33 15-Jan-2020 Dave Wallace <dwallacelf@gmail.com>

build: install vpp_echo for CSIT QUIC perf tests

Type: make

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Iddfcce1f662efe63c5a6788a0a604917b1c9d81e

79bfb9e0 24-Dec-2019 Simon Zhang <yuwei1.zhang@intel.com>

tcp: fix tcp check tx offload issue

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I3b8755831d762abf51e1cbe1b57024f9297de9a4
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>

d63b356b 14-Jan-2020 Yu Ping <ping.yu@intel.com>

tls: enable async node on demand

Type: fix

Change-Id: Iab7c65614c94497e8ec5a96624be72c1a139e486
Signed-off-by: Yu Ping <ping.yu@intel.com>

180210f9 15-Jan-2020 Alexander Chernavin <achernavin@netgate.com>

ip6: during icmp to icmp6 translation truncate error messages

All translated ICMPv6 packets that exceed the minimal IPv6 MTU get
truncated but according to RFC 4443 2.4 only ICMPv6 error messages
(type < 128) need to be truncated.

With this commit, truncate only ICMPv6 error messages.

Type: fix

Change-Id: Ic455352de2ff4ff6aa3421b46a2a54923f2d3f80
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>

fc0992cb 14-Jan-2020 Aloys Augustin <aloaugus@cisco.com>

quic: add FEATURE.yaml

Type: docs
Change-Id: Ica60b42e64703879c5c229209e4a4fac278bda31
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>

61f7bfb6 14-Jan-2020 Andrew Yourtchenko <ayourtch@gmail.com>

srv6-mobile: Revert "srv6-mobile:"

This reverts commit 57584d99dd8a8524db90c67c88525d58879d9b8e.

The reasons for reverting:

- the documentation seems "work in progress". Also, 500K of pngs
should probably go on wiki, rather than in the repo. Please
make sure that newly added documentation renders correctly
and sensibly as part of the review/commit process.

- runner.py seems to contain unit tests, so it should
be rewritten in a manner that allows the testing from within
CI (including an unprivileged docker container)

- the above items, especially the testing one, warrant more
work, and at a RC1 milestone time it is probably not
a good idea to include a significant patch without
proper care. I suggest to prepare it so it is ready
for the next release, or cherrypick it for a
20.01.1 release, if having it in stable/2001 is absolute necessity.

- when submitting it, ensure that the commit message
makes sense, especially having "srv6-mobile:" with no further
text should be absolutely avoided.

Change-Id: If81441f7ebf11a6ad5638b1327faf18e8ebe6a35
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

989c3c8f 14-Jan-2020 Simon Zhang <yuwei1.zhang@intel.com>

tls: add picotls session close process

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: If0a1691c1435f2826c8c83f8bc52e4cd3ecc6256

c95eefb3 08-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: handle ack advancement with no holes and reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I9afba8dc9e087b8c436fe568531c02614a577a7c

48bdbcd8 05-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix worker thread initialization

from threading.thread __init__:

This constructor should always be called with keyword arguments.

If a subclass overrides the constructor, it must make sure to invoke
the base class constructor (Thread.__init__()) before doing anything
else to the thread.

Type: test
Change-Id: Ifa89202e97053a4baf19e9a0ca0913430d5087a3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

57584d99 09-Jan-2020 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile:

Type: feature

Add new functions in SRv6 Mobile Plug-in

GTP4.DT and GTP6.DT

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I573a0c27bd463dd56a4d11b940941b8a8c826e08
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>

ba4a5bf8 09-Jan-2020 Neale Ranns <nranns@cisco.com>

classify: Reduce the include dependencies on vnet_classify.h

Type: refactor

currently vnet_classify.h is included in ip.h where it's not required.

Change-Id: Id55682637601655aa2edda681536a979c8e323bd
Signed-off-by: Neale Ranns <nranns@cisco.com>

207a1633 07-Jan-2020 Benoît Ganne <bganne@cisco.com>

dpdk: enforce max tx retries

n_retry was never decremented and so never enforced.

Type: fix

Change-Id: I71d60a72c156286f7e5b82b1c77a723361317c69
Signed-off-by: Benoît Ganne <bganne@cisco.com>

fec52edb 06-Jan-2020 Neale Ranns <nranns@cisco.com>

acl: Remove unsued type

Type: style

and add some indent offs.

Change-Id: I31cf3ab9ff9b64d2cd1f2034dcedd4a9c453efb4
Signed-off-by: Neale Ranns <nranns@cisco.com>

629e268a 07-Jan-2020 Neale Ranns <nranns@cisco.com>

ct6: dst,src copy typo

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I266fa5dc637383fd8dac6592c9c266a1b70a73e9

b3745c43 10-Jan-2020 Ole Troan <ot@cisco.com>

misc: feature file for unsupported feature l2tp

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I11db583650bc051f88f38358b877410f355b110f
Signed-off-by: Ole Troan <ot@cisco.com>

f63bf6a7 11-Jan-2020 Andrew Yourtchenko <ayourtch@gmail.com>

tests: disable the tap test for the time being

TAP tests require root access, which breaks
the testing in unprivileged scenario.
Disable the test until we find consensus on how
to deal with it.

Type: test
Change-Id: I66ee2b130723233682d858cad0b6e424ab0b2383
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

1c6486f7 09-Jan-2020 Yu Ping <ping.yu@intel.com>

tls: enable TLS OpenSSL plugin works in 3.0.0

Type: fix

Change-Id: Id1602981fcc6efed1b0efe79a1fc8177457acdb5
Signed-off-by: Yu Ping <ping.yu@intel.com>

d66848fd 11-Jan-2020 Andrew Yourtchenko <ayourtch@gmail.com>

misc: VPP 19.08.1 release notes

Change-Id: I365696bfcf11fcc74a698f764dec62e470fc7853
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Type: docs

2d18d2ea 03-Jan-2020 Nitin Saxena <nsaxena@marvell.com>

ip: avoid fib lookup for consecutive pkts having same source IP

Type: fix
Fixes: be2286b0

This patch does following:

- If terminating frame has consecutive packets with same source IP, this patch
avoids fib lookup for those packets in ip4-local node. This drops cycle count
for ip4-local node on both ARM and x86. It being done by enabling dead code in
else {} case of ip4_local_check_src_x2() and ip4_local_check_src() functions.

- In case all packets in terminating frame have unique source IP (e.g:
incrementing), ip4-local is costlier by 2 cycles (broadwell)

Change-Id: I472ddc324716cec8bfe601568b8aeb7565f97ab3
Signed-off-by: Nitin Saxena <nsaxena@marvell.com>

dfb3e410 08-Jan-2020 Mohsin Kazmi <sykazmi@cisco.com>

gso: add FEATURE.yaml

Type: docs

Change-Id: I64743c9f5ad7eef21855e883e1a00f355fddf3ee
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

ebd21c94 09-Jan-2020 pcamaril <pcamaril@cisco.com>

sr: feature YAML files for Segment Routing

Type: docs
Signed-off-by: pcamaril <pcamaril@cisco.com>
Change-Id: Ia35d18113e17fd2ba5310e81ca527d3569cd110e
Signed-off-by: pcamaril <pcamaril@cisco.com>

7c9fe920 10-Jan-2020 John DeNisco <jdenisco@cisco.com>

docs: Edit FEATURE.yaml files so they can be published

Type: docs
Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: I7280e5c5ad10a66c0787a5282291a2ef000bff5f

854eb6e3 07-Jan-2020 Matthew Smith <mgsmith@netgate.com>

bonding: process lacp when bond is admin down

Type: fix
Fixes: 6dfd3785e4

When a bond interface is administratively down but the slaves are
up, process inbound LACP packets received over the slaves. This
was the old behavior with bond interfaces in LACP mode and was
altered unintentionally by another change. Restore the old behavior.

Change-Id: I61b0b700211dea4859b6ee447ab83b33197d9d11
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

d3d7ef5e 09-Jan-2020 Zhiyong Yang <zhiyong.yang@intel.com>

fib: leverage well-optimized clib_memcpy

Type: fix

Change-Id: I684910837ca4d9c8a07262459158bbb0423a33af
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

87b0c892 09-Jan-2020 Florin Coras <fcoras@cisco.com>

session: remove io event dispatch dbg msg

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I166ab7b96444587a3252925d3a28505e0db52d74

a6696719 08-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix persist assert

Type: fix

Persist and retransmit can pop at the same time.

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ia9530645cc84c83a881a75d7b4627197dc50ed29

bbff1439 09-Jan-2020 Ole Troan <ot@cisco.com>

misc: fix feature description spelling

Type: docs
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I46856db81d42c3f10c03a7bf9a245cc998cd8a01

dbbff858 07-Jan-2020 Ole Troan <ot@cisco.com>

misc: feature tracking markdown improvements

Add table of contents to markdown file.
Added --exclude and --include options to user select which
fts fields to include in report.
Sort output based on feature name.

E.g.: ./build-root/scripts/fts.py --all --markdown --exclude="maintainer"

Type: make
Change-Id: I3edf8c2188a9f3e312767bbe12d75cca7d8c5b39
Signed-off-by: Ole Troan <ot@cisco.com>

edf1da94 08-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix scoreboard assert

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I3c70b331932708a1b773392e089aed9dba9b3b31

d8c1ef92 07-Jan-2020 Benoît Ganne <bganne@cisco.com>

rdma: api: prepare support for direct verb

Prepare rdma interface creation API for direct verb support:
- add new optional 'mode' parameters to select between ibverb or direct
verb backend (optional, default to 'auto')
- set default value for rxq_num (1), rxq_size (1024) and txq_size
(1024) so they are now optional
- bump default create value for rxq_size and txq_size to 1024 if
unset (0) so they are coherent with default values above

Type: feature

Change-Id: Id9eae2b8eb0baaf34a0fcd55da6ad09515f57a93
Signed-off-by: Benoît Ganne <bganne@cisco.com>

affc5f6d 26-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

virtio: fix ip4 checksum offload

Type: fix

Change-Id: I08747ac308e5c1768a3a6aa5f83a016dc0274a1c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

ba0061fe 18-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

tap: split gso and checksum offload functionality

Type: refactor

Change-Id: I0d4b79ef384c11c841576d264bfd8ccb21783e10
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

6d4af891 03-Jan-2020 Mohsin Kazmi <sykazmi@cisco.com>

virtio: split gso and checksum offload functionality

Type: refactor

Change-Id: I897e36bd5db593b417c2bac9f739bc51cf45bc08
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

0d74dd1f 07-Jan-2020 Florin Coras <fcoras@cisco.com>

tls: improve connection formating

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iea8abe33cf33036267ccaf58760abc2f48470202

479f7fec 08-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix last sacked with no holes

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Id12b0a9b8bc47aef8b393544e5b4c8228ed6a606

42ddf69e 06-Jan-2020 Florin Coras <fcoras@cisco.com>

vppinfra: retry socket connect on EAGAIN

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I93577acf559a8fa639aab7ec3f7cdbe7df9a248d

e4a08c1f 08-Jan-2020 Florin Coras <fcoras@cisco.com>

svm: fix eventfd signal write error check

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I706c8642ca0877430a42cc0ca5bc61a45428fc98

b2e73b1d 07-Jan-2020 John Lo <loj@cisco.com>

l2: fix MAC learn counter update on adding MAC entry

Type: fix

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I711432f589ee4a4527cf795526d3b4031999f71d

12050592 08-Jan-2020 Andrew Yourtchenko <ayourtch@gmail.com>

acl: add FEATURE.yaml

Change-Id: If6f13e7962c27f35528058224928def927fff19f
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

5dfc03f1 07-Jan-2020 Benoît Ganne <bganne@cisco.com>

rdma: add FEATURE.yaml

Type: docs

Change-Id: I91d701814e4bd9953616d2b7c76ae2ea7c07074b
Signed-off-by: Benoît Ganne <bganne@cisco.com>

5c944eef 07-Jan-2020 Dave Barach <dave@barachs.net>

vlib: fix coverity warning / real bug

The path must be next-to-impossible to hit, because the code has been
wrong for at least 5 years.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I23b8c4e1631827e7931f353c561c1e19c596c598

a9ed9347 06-Jan-2020 Yu Ping <ping.yu@intel.com>

tls: Make tls CPS test run for a quite long time

Type: fix

Change-Id: I8cfb48bd7f92689b296861dd368186408918061b
Signed-off-by: Yu Ping <ping.yu@intel.com>

067f8f96 04-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: fix duplicate sack whith reneging

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I6f7fb91e059996ff702eb9c36e3abaed237fe221

c190cf09 06-Jan-2020 Neale Ranns <nranns@cisco.com>

vppinfra: hash [un]set malloc/free takes a const key

Type: refactor

the key is not modified by these functions

Change-Id: I578f054355fca69e8a086bb69013155a01ed759f
Signed-off-by: Neale Ranns <nranns@cisco.com>

22e108d9 07-Jan-2020 Ole Troan <ot@cisco.com>

bonding: fix feature.yaml error

Type: fix
Fixes: 6b32b4aad
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8bd6bb95135dc280565f357aa5850292f66979a1
Signed-off-by: Ole Troan <ot@cisco.com>

6b32b4aa 06-Jan-2020 Steven Luong <sluong@cisco.com>

bonding: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I53522a60122014741d1c6533a0456bf31445529a

8e39e629 06-Jan-2020 Neale Ranns <nranns@cisco.com>

ipsec: Add FEATURE/yaml

Type: docs

Change-Id: I9cb093589b84fdca3f4239da90c431e8bc4d74f1
Signed-off-by: Neale Ranns <nranns@cisco.com>

c9ba85f8 06-Jan-2020 Neale Ranns <nranns@cisco.com>

qos: Add FEATURE.yaml

Type: docs

Change-Id: Id719ad59dd70f1d97b3cb3722621b10cd63badfb
Signed-off-by: Neale Ranns <nranns@cisco.com>

499b864d 06-Jan-2020 Neale Ranns <nranns@cisco.com>

mpls: Add FEATURE.yaml

Type: docs

Change-Id: Ic76a4bbfe2e2e45b7ea44556bc974c243970e9bf
Signed-off-by: Neale Ranns <nranns@cisco.com>

dc376eaa 06-Jan-2020 Neale Ranns <nranns@cisco.com>

ip-neighbor: Add FEATURE.yaml

Type: docs

Change-Id: I4c51dad23cf431692ef5b8bdd2391975fb7264d6
Signed-off-by: Neale Ranns <nranns@cisco.com>

78565f38 06-Jan-2020 Steven Luong <sluong@cisco.com>

vmxnet3: add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I8b0432a3a384dc2431fcb0b4e7c3f0cfb1713d8e

dfb93d25 06-Jan-2020 Steven Luong <sluong@cisco.com>

lacp: Add FEATURE.yaml

Type: docs

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6fe5555a9ec867d4e39f0751662256717b45e0f9

84def7cb 06-Jan-2020 MathiasRaoul <mathias.raoul@gmail.com>

quic: update quicly to v0.0.9-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I5cef549de8380b9b9534b8774819e42988f6b784

7adf5735 06-Jan-2020 John Lo <loj@cisco.com>

l2: Update FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Ib34440c137f24621002ce9463515c632c472a293

2e839be9 05-Jan-2020 Ole Troan <ot@cisco.com>

gre: fix feature.yaml error

vnet/gre/FEATURE.yaml does not conform with the JSON schema definition.
This bug should no longer happen with the patch that ensures
validation is run as part of checkstyle.

Signed-off-by: Ole Troan <ot@cisco.com>
Type: fix
Change-Id: I25bf8d2a442bf7ccdbf693b031a7a383444dfee3

7abab303 20-Dec-2019 Aloys Augustin <aloaugus@cisco.com>

quic: call quic_send_packets only once per ctx

This prevents unnecessary calls to quic_send_packets.

Type: fix
Change-Id: I7abe509aa8b7b9d5a01c9876046cf0f4507a79cf
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>

94501c49 03-Jan-2020 Hongjun Ni <hongjun.ni@intel.com>

lb: add FEATURE file for lb/pppoe/gtpu/vxlan-gpe/pppoe

Type: docs

Change-Id: Ia3949954423eb7691c02e99444767a9f01a14adf
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>

297fa0e7 05-Jan-2020 Neale Ranns <nranns@cisco.com>

gre: Add FEATURE.yaml

Type: docs

Change-Id: Icda0c8d2141294d78447177dd4823d1b2228e830
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

3a29c38d 05-Jan-2020 Neale Ranns <nranns@cisco.com>

ip6-nd: Add FEATURE.yaml

Type: docs

Change-Id: I907f2c7f5d73dd88b16a6ff78ef072e13af9739e
Signed-off-by: Neale Ranns <nranns@cisco.com>

f3aebda7 03-Jan-2020 Ole Troan <ot@cisco.com>

misc: fix feature.yaml

Add checkfeaturelist validation to checkstyle.
Fix two files with errors.

Type: docs
Change-Id: I81eda0e25b271f2006b4da22efdf7218d52a67d3
Signed-off-by: Ole Troan <ot@cisco.com>

69c2a589 04-Jan-2020 John Lo <loj@cisco.com>

vxlan: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I4372195121e05af671a3f48b1c2796cd0132b279

ff63798a 03-Jan-2020 John Lo <loj@cisco.com>

l2: Add FEATURE.yaml

Type: docs

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: Icd22f2ec7076bb11d6ac7e7d147bd58dc5ad1527

f3a6622c 02-Jan-2020 Neale Ranns <nranns@cisco.com>

ipsec: AH copy destination and source address from template

Type: fix

Change-Id: I63d4df68eed6589763b5ce62bcd7f3fd867c60e1
Signed-off-by: Neale Ranns <nranns@cisco.com>

02950406 20-Dec-2019 Neale Ranns <nranns@cisco.com>

ipsec: Targeted unit testing

Type: fix

1 - big packets; chained buffers and those without enoguh space to add
ESP header
2 - IPv6 extension headers in packets that are encrypted/decrypted
3 - Interface protection with SAs that have null algorithms

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie330861fb06a9b248d9dcd5c730e21326ac8e973

2f04cb9f 23-Dec-2019 Florin Coras <fcoras@cisco.com>

tcp: fix rate samples for old acks

Type: fix

Change-Id: Ieab35bbfba81faae61b1267d8661df5195877824
Signed-off-by: Florin Coras <fcoras@cisco.com>

1aaa8918 03-Jan-2020 Florin Coras <fcoras@cisco.com>

hsa: fix coverity warning

Type:fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I38b155f7617d002ac16943c2c031269a17f4ba73

8d0149d7 02-Jan-2020 Florin Coras <fcoras@cisco.com>

session: fix per slice fifo prealloc

Type: fix

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If6db37af6c2863a80d0787a98026b3b8171dad37

04d1a343 03-Jan-2020 Neale Ranns <nranns@cisco.com>

fib: Add dpo FEATURE.yaml file

Type: docs

Change-Id: I9c4727db8d498d0b513157b19ad306b7aaacc222
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

aa6a29f6 03-Jan-2020 Klement Sekera <ksekera@cisco.com>

bfd: add feature.yaml

Type: docs

Change-Id: Ica2b4a9d4fe2ceaafd6d707ebe3c4a7fa0af1c07
Signed-off-by: Klement Sekera <ksekera@cisco.com>

956819af 03-Jan-2020 Jakub Grajciar <jgrajcia@cisco.com>

tcp: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I48f08cc657c28ad1eef50c917a560425137bb70e
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

99c7b395 03-Jan-2020 Klement Sekera <ksekera@cisco.com>

lldp: add feature.yaml

Type: docs

Change-Id: I713ced931e26d5db70cd4678a9d02c5285a1a909
Signed-off-by: Klement Sekera <ksekera@cisco.com>

58989a37 08-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

ip: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I17b95bba2327049d2b99e59cea79208814a24b22
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

2c504f89 26-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

devices: virtio API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I38a409af770c88c1eb2c68b24abef2a5a91e1b9a

4b76c58b 03-Jan-2020 Jakub Grajciar <jgrajcia@cisco.com>

qos: api clenup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia66810293e41427c686fbf1ab9be5c8a7db4056a

3eb8f207 03-Jan-2020 Jakub Grajciar <jgrajcia@cisco.com>

mpls: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I44633df6d189da707657fbf9f9ba49c5f3879e9f

fb27096e 03-Jan-2020 Jakub Grajciar <jgrajcia@cisco.com>

vxlan-gbp: api cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I26bd57ba506165bf2dd574fa39a81adc4295d796

171577e1 26-Nov-2019 Jon Loeliger <jdl@netgate.com>

build: Fix Subject-line feature list extraction

Bang on sed until a better incantation appears.

Change-Id: Ib8ad0996b6325db0fe983c86dd7dc553c9d388c4
Type: fix
Fixes: 26ce6ca1fe6f524a9049444fe8d55042fd7530a6
Signed-off-by: Jon Loeliger <jdl@netgate.com>

87663cdf 20-Dec-2019 Vladimir Ratnikov <vratnikov@netgate.com>

map: fix ip4-map-t DF behavior

ip4_is_fragment(header)
or ip4_is_first_fragment(header) didn't changed
when packet with fragmentation needed arrives.

This patch checks DF flag and MTU with packet
length and if DF is set and length > MTU, packet
is dropped. In case if ignore_df is set, DF flag
makes no sense.

Type: fix
Fixes: d6d50cebde647f9a5ee7251a7fef977506f315d7

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I720e25167c19a0b13ac5fdfb41b12c0bbdc00d09

f126e746 10-Oct-2019 Klement Sekera <ksekera@cisco.com>

nat: use SVR

Remove NAT's implementation of shallow virtual reassembly with
corresponding CLIs, APIs & tests. Replace with standalone shallow
virtual reassembly provided by ipX-sv-reass* nodes.

Type: refactor
Change-Id: I7e6c7487a5a500d591f6871474a359e0993e59b6
Signed-off-by: Klement Sekera <ksekera@cisco.com>

3535501b 02-Jan-2020 Neale Ranns <nranns@cisco.com>

abf: add feature.yaml

Type: docs

Change-Id: I4959010617b0fb51652beafe6967afd556f27e92
Signed-off-by: Neale Ranns <nranns@cisco.com>

a6b175d3 02-Jan-2020 Florin Coras <fcoras@cisco.com>

tls: add features.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I847463fd38b9d569d2607b8a17f6d45a04b6fe09

93e053eb 02-Jan-2020 Florin Coras <fcoras@cisco.com>

tcp: add FEATURE.yaml

Type: feature

Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I21f822b597bfa44004bf2afaaf54463cb0ae2efc

c9e4b300 03-Jan-2020 Neale Ranns <nranns@cisco.com>

fib: add adjacency feature.yaml

Type: docs

Change-Id: I6cdfbae5a0eab8a69dfa2ae054945c510a3c63f6
Signed-off-by: Neale Ranns <nranns@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

3ff2ae24 03-Jan-2020 Neale Ranns <nranns@cisco.com>

bier: add FEATURE.yaml

Type: docs

Change-Id: I843a410b7a14c7c61e44ea38cf7cb74f40ccf853
Signed-off-by: Neale Ranns <nranns@cisco.com>

9abfbb22 03-Jan-2020 Neale Ranns <nranns@cisco.com>

arp: add FEATURE.yaml

Type: docs

Change-Id: If03488de772204a984e1785c33646833f2de6e1e
Signed-off-by: Neale Ranns <nranns@cisco.com>

115487c4 02-Jan-2020 Neale Ranns <nranns@cisco.com>

igmp: Add feature.yaml

Type: docs

Change-Id: I8d6ab1b4fd9f059a3f4c8ba28fc9f20debfb65cb
Signed-off-by: Neale Ranns <nranns@cisco.com>

d4dd1f81 02-Jan-2020 Neale Ranns <nranns@cisco.com>

l3xc: add feature.yaml

Type: docs

Change-Id: I0d939b26079e9e45fba1cbb7c8e668918c128526
Signed-off-by: Neale Ranns <nranns@cisco.com>

f9b5dcf3 02-Jan-2020 Florin Coras <fcoras@cisco.com>

udp: add features.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I2a7d509a2aaed6dba7d821b469c6de90d487f068

e774a8b3 02-Jan-2020 Ole Troan <ot@cisco.com>

nat: add feature.yaml

And add support for multiple maintainers in JSON schema.

Type: docs
Change-Id: Ice430927ceecf53526a3fdf46c075a95206bf0ac
Signed-off-by: Ole Troan <ot@cisco.com>

8ef8f8f7 03-Jan-2020 Florin Coras <fcoras@cisco.com>

session: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: If9065b03c0cd7d567c54eda383d6297ef554d9f0

b3f7d9ba 03-Jan-2020 Florin Coras <fcoras@cisco.com>

vcl: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Ifda0404cfc6710d7ecf21da96eb1cb92750b495f

a2dd5e08 03-Jan-2020 Florin Coras <fcoras@cisco.com>

lisp: add feature.yaml

Type: docs

Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: Iba2203e98c627d550021beee2ec1cfe3cb02686f

0ea672e3 02-Jan-2020 Neale Ranns <nranns@cisco.com>

svs: add feature.yaml

Type: docs

Change-Id: Ie75368f64201f2f6623413bc2ba015d9dc8fbc9f
Signed-off-by: Neale Ranns <nranns@cisco.com>

822d6899 02-Jan-2020 Neale Ranns <nranns@cisco.com>

crypto-ipsecmb: Add FEATURE.yaml for all crypto engine plugins

Type: docs

Change-Id: Ia00e3167e954271c9eb7618792fd86df288d5c19
Signed-off-by: Neale Ranns <nranns@cisco.com>

9ce3b747 02-Jan-2020 Dave Barach <dave@barachs.net>

http_static: add FEATURE.yaml

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2f9a74541183af6c10abea2c29002842ddb88815

95cd8643 31-Dec-2019 Florin Coras <fcoras@cisco.com>

session: fix listener global endpoint lookup

Type: fix

Ensure listeners for app transport protocols are added to lookup tables
using their session endpoints instead of their transport connections,
which can override the network connection id in the transport connection.

Change-Id: I56fa3666bb1422c0799fc7143cd099751ff6e2e6
Signed-off-by: Florin Coras <fcoras@cisco.com>

4ed25985 25-Dec-2019 Dave Barach <dave@barachs.net>

tests: configure 32 mb physmem

Absolutely nothing good happens when we force the kernel to briefly
map and then unmap 16gb as vpp starts. Effect exacerbated when
TEST_JOBS = 20...40, and so forth.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id8e3ce1763cad3a0891d5d6c8d2c1e3e610682d7

15d7fd0f 26-Nov-2019 Benoît Ganne <bganne@cisco.com>

virtio: fix checksum offload support

Checksum offload and GSO are independent. We must support checksum
offload if it has been negotiated, independently of GSO.

Ticket: VPPSUPP-47
Type: fix

Change-Id: I8cb6dd58b61714ebb2726eb4aab0d74d49fdab99
Signed-off-by: Benoît Ganne <bganne@cisco.com>

222b709a 24-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: fix number of buffers required for segmentation

Type: fix

Change-Id: I73ef0ce81b2d6a799f6a6e59908ec24cc2290a2c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

7ade2f51 06-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: bfd - move test_poll_response to EXTENDED_TESTS

test_bfd.BFD4TestCase.test_poll_response providing
inconsistent results is the per-patch tests.

Type: test

Change-Id: I8f1864511526fd330a7da1abfa19be3f565c683a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

306c3080 01-Jan-2020 Neale Ranns <nranns@cisco.com>

ip: indent format typo fix

Type: style

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Idfcd4a363d4582ce69fac83ddc760f2dc4feed52

fca3c6a3 31-Dec-2019 Neale Ranns <nranns@cisco.com>

ip-neighbor: set link-type ARP on incomplete adjacencies

Type: fix

Change-Id: I05d74da311d6a86ec4eb3df50d53ecaa9c622f50
Signed-off-by: Neale Ranns <nranns@cisco.com>

fea813ae 27-Dec-2019 Florin Coras <fcoras@cisco.com>

svm: broadcast on raw dequeues and full rings

Type: fix

Change-Id: I0cac9001290e7ed4e2e318ae62c56e97ec75a3db
Signed-off-by: Florin Coras <fcoras@cisco.com>

9f3f18f9 30-Dec-2019 hanlin <hanlin_wang@163.com>

vcl: hold errno when calling LDBG

Type: fix

Call trace of LDBG:
LDBG->clib_warning->_clib_error->dispatch_message->os_puts->writev
However, writev will hijacked by LDP, and then execute following code:
if ((errno = -ldp_init ()))
return -1;
Now, errno will be set.

Because we always call LDBG just before return from ldp_accept4, listen,
and etc. So errno will be overwritted after LDBG called.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: I7a90f3a14772994f11f09650481411796e3f5630

b7f035ff 27-Dec-2019 Florin Coras <fcoras@cisco.com>

tcp: validate port reuse

Type: fix

Make sure existing connection is in time-wait

Change-Id: I8e8bef151f81bcd589b4da0d4bf63cc59f9f451b
Signed-off-by: Florin Coras <fcoras@cisco.com>

b092b77c 26-Dec-2019 Yu Ping <ping.yu@intel.com>

tcp: Enable TCP timewait port use

Improve host stack CPS test, and it help improve 10x performance

Type: feature

Change-Id: I6af61e0bad7c16ee2d30a1422cc46bb89f1cedb4
Signed-off-by: Yu Ping <ping.yu@intel.com>
Signed-off-by: Yuwei Zhang <yuwei1.zhang@intel.com>

a42c6ee9 27-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: test_mpls_v6_ebgp_pic - don't write to stdout

Type: test

Change-Id: I2cccc68b1b4b6c576580ae0eb5d4511ca2f4663d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

475c9d7b 26-Dec-2019 hanlin <hanlin_wang@163.com>

vcl: EPOLLOUT should be generated when epoll_ctl called with EPOLLOUT
event

Type: fix

When we call epoll_ctl to add or mod fd with EPOLLOUT event, mostly to
check if we can write. So we expect a EPOLLOUT event should be generated
immediately unless tx queue is full.

Signed-off-by: hanlin <hanlin_wang@163.com>
Change-Id: Ie99986a44dbb07b6ff2fba6512171056f79e77bd

3f7b0f4a 27-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: tls - don't print skip info to stdout

Type: test

Change-Id: Id1bffbfe698113d85c4c6bf432ddf4908ed2b788
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

29c61321 24-Dec-2019 Dave Barach <dave@barachs.net>

classify: "classify filter ..." debug CLI cleanup

The pcap trace filter initial table index lives in
cm->filter_set_by_sw_if_index [0], which corresponds to the "local0"
interface. Debug cli makes sure that folks don't accidentally specify
the "local0" interface. At least it does now...

Fix the "vlib format.c code coverage" test in test/test_vlib.py.

Type: fix
Change-Id: I35320bc2c8f0c6f1f8c12e3529d1938548185151
Signed-off-by: Dave Barach <dave@barachs.net>

1decd98e 24-Dec-2019 Dave Barach <dave@barachs.net>

unittest: test_bihash call clib_time_init(...)

Fix "Rejecting large frequency change of +infinity" errors.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I8efca1291e38c48bb98e7f8109253224a4f0a2a1

de35cdb7 16-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix skip logic on test_tap

log.txt message:
17:52:59,969 API call failed, expected 0 return value instead of -13 in tap_create_v2_reply(_0=58, context=77019, retval=-13, sw_if_index=4294967295)

Test was failing with log message:
tap: tap0: tap_create_if: ioctl(TUNSETIFF): Operation not permitted

Type: test
Change-Id: I5bcd9d2b0c870ea5eef92b79314b97821399722f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

5002e7f2 23-Dec-2019 Matthew Smith <mgsmith@netgate.com>

ip-neighbor: ip_neighbor_advertise() handles null

Type: fix
Fixes: cbe25aab3b

ip_neighbor_advertise() was calling one of both of
ip4_neighbor_advertise() and/or ip6_neighbor_advertise() with
&addr->{ip4|ip6} as an argument. If addr is null, which is likely
a requirement when the type is IP46_TYPE_BOTH, this results in a
SEGV.

Check addr and pass a pointer to one of it's members if it is not
null, otherwise pass null.

Change-Id: I6261bb8fe947365fe3d6c58788ea27d5cb28ff05
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

4a56f4e4 23-Dec-2019 Neale Ranns <nranns@cisco.com>

ipsec: Test and fix IPSec worker hand-off

Type: fix

Change-Id: I5cb9a3845ddbc5f4de4eb4e9c481f606fe5cec9a
Signed-off-by: Neale Ranns <nranns@cisco.com>

1de7167e 22-Dec-2019 Florin Coras <fcoras@cisco.com>

tcp: accept sack reneging as a cc event

Type: fix

Change-Id: Iead1303ca3dec7593eb3ce54f291b82d94c821a4
Signed-off-by: Florin Coras <fcoras@cisco.com>

da8f218f 22-Dec-2019 Florin Coras <fcoras@cisco.com>

vcl: fix multi-thread app segment attaching

Type: fix

Guard segment attaching/deletion, not only the hash table CRD
operations.

Change-Id: Ic96e4adedffb73baf89e971438596927e6daf930
Signed-off-by: Florin Coras <fcoras@cisco.com>

a25a8576 07-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: vpp_memif fix formatting error in exception

Type: test

Change-Id: I2d32797efd1c3478a862b7950ef9ab63428da890
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

548d5ee7 17-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: TestL2bdMultiInst - break serial dependency on tests

enable the tests to run out of order/enable running an individual test.
Before:
[gw1] [ 20%] FAILED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_02
[gw0] [ 40%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_01
[gw1] [ 60%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_04
[gw0] [ 80%] FAILED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_03
[gw1] [100%] SKIPPED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_05
-------
After:
[gw1] [ 20%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_02
[gw0] [ 40%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_01
[gw1] [ 60%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_04
[gw0] [ 80%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_03
[gw1] [100%] PASSED test/test_l2bd_multi_instance.py::TestL2bdMultiInst::test_l2bd_inst_05

Type: test

Change-Id: Ie40eb310f5fccacf854c364aa017891bce9b9372
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

4a94cd26 20-Dec-2019 Miklos Tirpak <miklos.tirpak@gmail.com>

fib: use 32 bits per-source reference counter

The 16 bits reference counter limited the number of interfaces
per FIB table to 65K from a given source. Some use cases, for example
GTP-U tunnels require much more interfaces than that.
This change increases the size of the reference counter to 32 bits.

Type: fix

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: I944a98513018840f904f2808c2a1e963b37886cc

c301dc33 20-Dec-2019 Matthew Smith <mgsmith@netgate.com>

ip-neighbor: fix API initialization call

Type: fix
Fixes: cbe25aab3b

Wrap ip_neighbor_api_init() in VLIB_API_INIT_FUNCTION() macro
instead of VLIB_INIT_FUNCTION() so API message IDs get allocated.

Change-Id: Id0c36c16b982feb9d7442015f9ddf2449a9e5b60
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

c4c4cf50 25-Aug-2019 Florin Coras <fcoras@cisco.com>

session: move add/del segment msg to mq

Type: refactor

Change-Id: I32234173ebd69f80acb1afa4039fffbd19157f6d
Signed-off-by: Florin Coras <fcoras@cisco.com>

d849edf3 21-Dec-2019 Florin Coras <fcoras@cisco.com>

svm: fix multichunk alloc with not enough space

Type: fix

Change-Id: Ia89c76b0e897fc3a3ebbc8dcba25e8ac9974b7fa
Signed-off-by: Florin Coras <fcoras@cisco.com>

623b4f85 18-Dec-2019 Shawn Ji <xiaji@tethrnet.com>

vxlan: reuse inner packet flow hash for tunnel outer header load balance

Type: fix

Several tunnels encapsulation use udp as outer header and udp src port
is set by inner header flow hash, such as gtpu, geneve, vxlan, vxlan-gbd
Since flow hash of inner header is already been calculated, keeping it
to vnet_buffere[b]->ip.flow_hash should save load-balance node work to
select ECMP uplinks.

Change-Id: I0e4e2b27178f4fcc5785e221d6d1f3e8747d0d59
Signed-off-by: Shawn Ji <xiaji@tethrnet.com>

4453c09a 19-Dec-2019 Florin Coras <fcoras@cisco.com>

svm: fix sh ssvm size for private segments

Type: fix

Change-Id: Id11cb596923541c12d37f1afa00416d73c6ff5e3
Signed-off-by: Florin Coras <fcoras@cisco.com>

c701e571 19-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: don't prompt to launch gdb for sanity test case

Type: test

Change-Id: I4c54121b76b341381a819cee928c3c2455a83503
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

ff6cdcca 19-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Add periodic timing

Type: feature

Change-Id: I18cf38d6f77e0d42212c85262f3bb769b9477b29
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

b22e1f06 19-Dec-2019 Jon Loeliger <jdl@netgate.com>

interface: Prevent bad inner-dot1q any exact-match configuration

Someone much more knowledgeable than I wrote:

For L3 IP forwarding, any VLAN tags on a packet must be exact
match to a sub-interface which means both outer and inner VLAN
tag IDs must be exact-matched to specific values defined of that
sub-interface. Without exact match on a L3 sub-interface, VPP
has no mechanism to know what VLAN tags to use for packet output,
such as ARP request packets or IP packets, on that sub-interface.

Thus, sub-interface with "inner-dot1q any" is not an exact match
sub-interface by definition since no match is present on inner
tag.

While in the area, fix a memory leak that would ensue on poorly
configured interfaces.

Change-Id: I8d17a96dbca3e3724c297ecc935ca61764e6ce2e
Type: fix
Signed-off-by: Jon Loeliger <jdl@netgate.com>

b4f073cd 18-Dec-2019 Dave Wallace <dwallacelf@gmail.com>

bash: add -j <jobs> option to vpp-make-test

- Also cleanup local var declarations
- remove extraneous export statement

Type: test

Change-Id: I22198a65d1785ba53d1de22b2aa498cab910701b
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

75c72369 18-Dec-2019 Miklos Tirpak <miklos.tirpak@gmail.com>

gtpu: Track the dst FIB entry instead of RR sourcing that

RR sourcing the destination FIB entry limits the number of tunnels
to 255 for a particular destination. This change removes this limit.

Type: fix

The patch is based on 1f50bf8fc57ebf78f9056185a342493be460a847
that introduced the FIB entry tracking but did not update
the gtpu plugin.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: I8a4a87382a6eb5120e2bb65b9bc3c446bbfdbd3b

8122cc2a 18-Dec-2019 Florin Coras <fcoras@cisco.com>

session: reserve memory for rbtree

Type: fix

Change-Id: I2b89f6e4c09297e3712d88cd25c80a806d3005aa
Signed-off-by: Florin Coras <fcoras@cisco.com>

e090f4db 29-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: lazily initialize stats client

remove wait-loop on stats socket from test framework.

Type: refactor

Change-Id: I5bb95a7c597707a87f9d9a471215c4b4af1a2280
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

4c16d800 17-Dec-2019 Neale Ranns <nranns@cisco.com>

gre: multipoint ingress lookup fix

Type: fix

Change-Id: I170edd62220a63cb19efea3032e173fb87730b1b
Signed-off-by: Neale Ranns <nranns@cisco.com>

cfffeae1 19-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: fix accept failure

Type: fix

Change-Id: Ic85cedae268a3abc452a2b1d4cc6672a464e2d2c
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

64e9d28d 17-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

build tests: fail test run if we can't patch scapy

Type: fix

Change-Id: I694e44f449863b3edbbc8b6095e94f770dc20330
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

affa0553 22-Oct-2019 Jieqiang Wang <jieqiang.wang@arm.com>

docs: add physmem section in configuration parameters

physmem section is listed in 'Advanced Parameters', which has two
parameters, base-addr and max-size, for pmalloc module in VPP.

Type:feature

Change-Id: I7beef40603b864e4c8f3cf0fa716de74036cfdcc
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>

53131d2a 17-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix cdp patch for scapy 2.4.3

Type: test
Fixes: 5d4b8912d2fe186b4fb920a72b3a2f7b556f4e7d

Change-Id: Ib64ae00eba41b2b6afc728142cbccc02d07f4997
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

917c91ad 07-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: update troubleshooting commands

Depends-On: https://gerrit.fd.io/r/c/vpp/+/22819

Type: docs

Change-Id: I1e2170a524e19cb91836a8073f62100b88f46cee
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

d9942bcc 18-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Hotfix crypto context on migrate

Type: fix

quicly_connections have internal references to crypto
contexts which need to be updated when we switch thread
as the supporting pools are thread-based.
This under the assumption that the new contexts will be
exactly identical

Change-Id: I38083e59657ff068e347d9e7b47abe91a1167b6c
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

9f4ac587 18-Dec-2019 Florin Coras <fcoras@cisco.com>

svm: decrease svm map verbosity

Type: fix

Change-Id: I833b6c23c376f1e806f94f0780be365c82ad1f88
Signed-off-by: Florin Coras <fcoras@cisco.com>

568acbb7 18-Dec-2019 Neale Ranns <nranns@cisco.com>

ipsec: Fix decap of IPSEC/GRE in transport mode

Type: fix

in transport mode the header sequence is:
MAC - IP (tun) - ESP - GRE - L2
so popping the GRE header is done in the ESP decrypt node.

Change-Id: Ia125eb65b9300368617d2bffca09683851e43be0
Signed-off-by: Neale Ranns <nranns@cisco.com>

6461b7a3 17-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix import from change to scapy 2.4.3

Type: test
Fixes: 8d27fa73f22803d518993090804724f76350cfcc

Change-Id: I4656a9769011ed2399c1799f6f17520e44f375c7
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

77022b88 10-Dec-2019 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile

Type: fix

Plug-in for IPv6 Segment Routing Mobile

Fix the packet forwarding issue on GTP4/6.D when configuring only 1 segment in SRH.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I3a1d14b82821fc6e038d4ef719fd2aa006df2903
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>

10a8bda3 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

misc: don't os_exit(1) causing core on SIGINT

It's not typical for a program to core when it receives a SIGINT, so
keep this from happening.

Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I2c15985a57e6ea898ff05c4001e4b30b41154eba

19871f25 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

pg: don't leak open files in packet-generator

Fix pg code to close it's open file descriptors before zero'ing the
pcap_main structure for re-use.

Ticket: VPP-1780
Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I32945c6476ae83b8d210ee67ac78db3e8f786f46

0812aea0 03-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vpp: fix .short_help for "ip virtual"

Type: fix

"# <feature-name>: <subject>

Change-Id: I8b6b6b8c70faec7cd95e1842259e907fb9587017
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

336bccdf 31-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

dhcp: client use local logger

Type: fix

Change-Id: I8383e04d01e0001c1cba176d2148b2c4c74e397a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

5fb2278c 07-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vxlan geneve gtpu: fix short help

Type: fix

Change-Id: Id53eb6ed15f270d747b9831a7b585cbafe515dd2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

32c4d38f 23-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

ip: cleanup punt socket cli help

Make the help string consistent with the cli parser.

Type: fix

Change-Id: I7140bd589c2a94dbf5af5cc633cb495457a6af22
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

a4e2e7cc 06-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

feature: add descriptive cli command output for 'set interface feature'


DBGvpp# set interface feature local0 arp-foo arc bad-arc
set interface feature: Unknown arc name (bad-arc)...

DBGvpp# set interface feature local0 arp-foo arc arp
set interface feature: Feature (arp-foo) not registered to arc (arp)...
See 'show features verbose' for valid feature/arc combinations.

DBGvpp# set interface feature local0 arp-disabled arc arp

Type: fix

Change-Id: I036bb2a75dd2d40f6901e4fde3eb14925238e19b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

baa17104 06-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

feature: add [verbose] to show features help

Type: fix

Change-Id: Idf694477c18852e5541c28a493a56b302122e46c
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

9d0ca07f 20-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

build: Add missing package to Makefile

- add dependency for pip install psutil.
See: https://github.com/giampaolo/psutil/blob/master/INSTALL.rst#linux

Type: fix

Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I3a24a9dbfc5093c02e2aedf08ac64f10821693f8

c025329b 07-Nov-2019 Renato Botelho do Couto <renato@netgate.com>

misc: Add CentOS 8 package support

Type: feature

Added missing dependencies on RPM spec file and install-dep

Ticket: VPP-1800

Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Change-Id: I91d39c94b3f03c213249dff42b264718ef772bdb

842506f3 22-Oct-2019 jieqiang wang <jieqiang.wang@arm.com>

vlib: add max-size configuration parameter for pmalloc

Enable 'max-size' configuration parameter to set maximum size of
memory space allocated for pmalloc module. This parameter along
with existing 'base-addr' falls into physmem section. Both are
dedicated parameters to pmalloc module.

Type: feature

Change-Id: I939f25156b9a43440a24d69a7397d57eb6c2d392
Signed-off-by: Jieqiang Wang <Jieqiang.Wang@arm.com>

3be9351e 21-Nov-2019 Vratko Polak <vrpolak@cisco.com>

l2: l2_patch_main should not be static

Without understanding what is going on,
a pattern from l2_fwd.c is applied to l2_patch.c file.

Type: fix
Fixes: d770cfc96257f9bd9e0c96c8ebe50e4531dc1bc5
Ticket: VPP-1799

Change-Id: Ia97d448f9d1846549f57ea69044ae15fa39bb942
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

b2dbb36f 04-Dec-2019 GordonNoonan <gordon.noonan@intel.com>

vlib: fix startup-config-process stack overflow

Type: fix

Startup config setting an i40e/ice interface
up in Debug VPP consumes more than the currently
available stack space.

Signed-off-by: GordonNoonan <gordon.noonan@intel.com>
Change-Id: I98b52c5596799017b97f802a8661b76cd1bb3245

6dfd3785 07-Dec-2019 Steven Luong <sluong@cisco.com>

bonding: drop traffic on backup interface for active-backup mode

For active-backup mode, we transmit on one and only one interface. However,
we might still receive traffic on the backup interface. We should drop them
and strictly process incoming traffic on only the active interface.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Idb6b798b30033e84044b151c616be3c157329731

4ff8d615 14-Dec-2019 Chenmin Sun <chenmin.sun@intel.com>

flow: add ethernet flow

Type: feature

This patch adds the ethernet type flow support

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I6de163d04c6472df60a5f296fb428efd000267c4

497dd894 02-Dec-2019 Benoît Ganne <bganne@cisco.com>

misc: address sanitizer: do not instrument dlmalloc internals

Type: fix

Change-Id: I2b8273666db864d80012c39623ae866ac3527426
Signed-off-by: Benoît Ganne <bganne@cisco.com>

dea0b23f 06-Dec-2019 Vratko Polak <vrpolak@cisco.com>

vlib: fix an issue with show pci

The fix has been received over e-mail from Lijian Zhang.
https://lists.fd.io/g/vpp-dev/message/14808

Type: fix
Ticket: VPP-1805

Change-Id: I73e5fe7dcbe2b0b1c639d844f29183eab3b6dd66
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

dc20371f 05-Dec-2019 Oliver Giles <oliver_g@radwin.com>

build: export vapi generation in vpp-dev

Adds the higher-level vapi generation to cmake/api.cmake and exposes
the necessary python scripts in vpp-dev, so that out-of-tree/downstream
plugins can also leverage the more convenient API.

Type: feature

Signed-off-by: Oliver Giles <oliver_g@radwin.com>
Change-Id: I8c40a14d27ba3cb972c6907632e03c0e7b0ce982

3d14f036 05-Dec-2019 Bernhard M. Wiedemann <bwiedemann@suse.de>

build: Allow to override build date with SOURCE_DATE_EPOCH

and make host and user overridable
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.
Also use ISO 8601 date format to be easier to parse.
This is similar to c9f40227836b827b71a6cbc4744d4b7151b2fcef
and df82ec8fe7d91467c8b479bba74c761c0a6ffc59
which was lost in the move away from automake.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.

Type: fix

Change-Id: If4cab12320e6b5fcb1f2842fac5d745b33b01ed7
Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>

62d9fda8 16-Dec-2019 Benoît Ganne <bganne@cisco.com>

vlib: fix vector-as-C-string overflow

Type: fix

Change-Id: If0419ff1a82d45e5b3326973008e1b9feb290c5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>

b2f09146 16-Dec-2019 Benoît Ganne <bganne@cisco.com>

misc: address sanitizer: fix instrumentation

Type: fix

Change-Id: I99e3951f8cfb7ab9d2f0a7dcee92199eab29043c
Signed-off-by: Benoît Ganne <bganne@cisco.com>

8d27fa73 09-Dec-2019 Benoît Ganne <bganne@cisco.com>

classify: add complex encap packet tracing test

Type: test

Change-Id: I392975c00d7dae86dacedf7559aafa431e71cb14
Signed-off-by: Benoît Ganne <bganne@cisco.com>

71a70d73 09-Dec-2019 Benoît Ganne <bganne@cisco.com>

classify: forbid invalid match config

Forbid too long match to be configured.

Type: fix

Change-Id: Icfced0f86821d5febd6a3c81e1315bd9737498c0
Signed-off-by: Benoît Ganne <bganne@cisco.com>

f62a8c01 02-Apr-2019 Neale Ranns <nranns@cisco.com>

ipsec: bind an SA to a worker

the sequence number increment and the anti-replay window
checks must be atomic. Given the vector nature of VPP we
can't simply use atomic increments for sequence numbers,
since a vector on thread 1 with lower sequence numbers could
be 'overtaken' by packets on thread 2 with higher sequence
numbers.
The anti-replay logic requires a critical section, not just
atomics, and we don't want that.
So when the SA see the first packet it is bound to that worker
all subsequent packets, that arrive on a different worker,
are subject to a handoff.

Type: feature

Change-Id: Ia20a8645fb50622ea6235ab015a537f033d531a4
Signed-off-by: Neale Ranns <nranns@cisco.com>

f2bde7ac 13-Dec-2019 Chenmin Sun <chenmin.sun@intel.com>

dpdk: add devargs support

Type: feature

This patch adds the devargs support for dpdk device
The devargs are used as hardware-specific init args for dpdk devices
please refer to the nic guides under
$(DPDK_DIR)/doc/guides/nics/$(NIC_DRIVER).rst

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Id380d04720090bb66afe5ce09d664e5e248b8eb9

a7cb3574 16-Dec-2019 Benoît Ganne <bganne@cisco.com>

vppinfra: fix cpu flag string overflow

Type: fix

Change-Id: Idb1fff8a172034044bb33d5b271a84d1fd672ef5
Signed-off-by: Benoît Ganne <bganne@cisco.com>

7176b800 16-Dec-2019 Benoît Ganne <bganne@cisco.com>

perfmon: fix per-worker data initialization

When perfmon_init is called at initialization time worker threads are
not created yet and vec_len(vlib_mains) returns 1.
Initialize per-worker data when the number of workers is known, when
enabling data collection instead.

Type: fix

Change-Id: I36887cc7b2a3e88d9728d3cd7262d9b1c968dd3c
Signed-off-by: Benoît Ganne <bganne@cisco.com>

e11dce20 17-Dec-2019 Neale Ranns <nranns@cisco.com>

nhrp: mGREv6

Type: test

Change-Id: I7d0496c37e06d3b6eee325a262e5398860282b63
Signed-off-by: Neale Ranns <nranns@cisco.com>

70ef0fae 16-Dec-2019 Benoît Ganne <bganne@cisco.com>

l2: fix l2input_feat_names overflow

Type: fix

Change-Id: I59549b3aab5a0ccfe7db02757f78528e028121a5
Signed-off-by: Benoît Ganne <bganne@cisco.com>

edf3b4b0 30-Oct-2019 Mohsin Kazmi <sykazmi@cisco.com>

virtio: fix the tx queue thread binding

Type: fix

Change-Id: Ibbe7e20aebc9153ceba07e048dc0eaa45193f4ea
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

d1b9e706 07-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Implement crypto contexts

Type: feature

Make quic use the crypto contexts. This introduces a crypto context
pool backed by a hashtable giving ctx indexes by connect params
(ckpair, engine, rx & tx fifo sizes).
Applications keep the initialization vector common.

Change-Id: I22ed6711196cd70a2f2f74240f12113c7af8dfcd
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

70ae4efa 09-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: minor fixes to gso segmentation

Type: fix

Change-Id: I01602ba7f1a4820c7790a771a5a7281ed66ff905
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

328631d4 17-Dec-2019 Dave Barach <dave@barachs.net>

docs: improve compressed core file documentation

In particular, document "zcat vpp_core.gz | dd conv=sparse of=vpp_core"

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I01b70492ced864b47847c2ef7bc1ea8eb0980ec3

cbe25aab 30-Sep-2019 Neale Ranns <nranns@cisco.com>

ip: Protocol Independent IP Neighbors

Type: feature

- ip-neighbour: generic neighbour handling; APIs, DBs, event handling,
aging
- arp: ARP protocol implementation
- ip6-nd; IPv6 neighbor discovery implementation; separate ND,
MLD, RA
- ip6-link; manage link-local addresses
- l2-arp-term; events separated from IP neighbours, since they are not
the same.

vnet retains just enough education to perform ND/ARP packet
construction.
arp and ip6-nd to be moved to plugins soon.

Change-Id: I88dedd0006b299344f4c7024a0aa5baa6b9a8bbe
Signed-off-by: Neale Ranns <nranns@cisco.com>


MAINTAINERS
extras/vom/vom/.clang-format
extras/vom/vom/api_types.cpp
extras/vom/vom/api_types.hpp
extras/vom/vom/arp_proxy_binding_cmds.cpp
extras/vom/vom/arp_proxy_binding_cmds.hpp
extras/vom/vom/arp_proxy_config_cmds.cpp
extras/vom/vom/arp_proxy_config_cmds.hpp
extras/vom/vom/interface_ip6_nd_cmds.cpp
extras/vom/vom/neighbour_cmds.cpp
extras/vom/vom/neighbour_cmds.hpp
extras/vom/vom/ra_config.cpp
extras/vom/vom/ra_config.hpp
extras/vom/vom/ra_prefix.hpp
src/plugins/abf/test/test_abf.py
src/plugins/acl/test/test_acl_plugin_conns.py
src/plugins/acl/test/test_acl_plugin_l2l3.py
src/plugins/dhcp/dhcp6_ia_na_client_cp.c
src/plugins/dhcp/dhcp6_ia_na_client_dp.c
src/plugins/dhcp/dhcp6_pd_client_cp.c
src/plugins/dhcp/dhcp6_pd_client_dp.c
src/plugins/dhcp/test/test_dhcp.py
src/plugins/gbp/gbp_endpoint.c
src/plugins/gbp/gbp_route_domain.c
src/plugins/l3xc/test/test_l3xc.py
src/plugins/mactime/builtins.c
src/plugins/mactime/mactime.c
src/plugins/mactime/mactime.h
src/plugins/mactime/test/test_mactime.py
src/plugins/nat/nat64_in2out.c
src/plugins/ping/ping.c
src/plugins/srv6-ad/test/test_srv6_ad.py
src/plugins/srv6-am/test/test_srv6.py
src/plugins/srv6-as/test/test_srv6_as.py
src/plugins/svs/test/test_svs.py
src/vat/api_format.c
src/vlibapi/api_helper_macros.h
src/vnet/CMakeLists.txt
src/vnet/adj/adj.h
src/vnet/adj/adj_glean.c
src/vnet/adj/adj_internal.h
src/vnet/adj/adj_mcast.c
src/vnet/adj/adj_nbr.c
src/vnet/api_errno.h
src/vnet/arp/arp.api
src/vnet/arp/arp.c
src/vnet/arp/arp.h
src/vnet/arp/arp_api.c
src/vnet/arp/arp_packet.h
src/vnet/arp/arp_proxy.c
src/vnet/arp/arp_test.c
src/vnet/bfd/bfd_api.h
src/vnet/bfd/bfd_udp.c
src/vnet/bonding/device.c
src/vnet/ethernet/arp.c
src/vnet/ethernet/arp.h
src/vnet/ethernet/arp_packet.c
src/vnet/ethernet/arp_packet.h
src/vnet/ethernet/ethernet.h
src/vnet/ethernet/interface.c
src/vnet/ethernet/mac_address.c
src/vnet/ethernet/mac_address.h
src/vnet/fib/fib_entry.c
src/vnet/fib/fib_path.c
src/vnet/fib/fib_table.h
src/vnet/fib/fib_types.c
src/vnet/fib/fib_types.h
src/vnet/fib/ip4_fib.c
src/vnet/fib/ip6_fib.c
src/vnet/ip-neighbor/ip4_neighbor.c
src/vnet/ip-neighbor/ip4_neighbor.h
src/vnet/ip-neighbor/ip6_neighbor.c
src/vnet/ip-neighbor/ip6_neighbor.h
src/vnet/ip-neighbor/ip_neighbor.api
src/vnet/ip-neighbor/ip_neighbor.c
src/vnet/ip-neighbor/ip_neighbor.h
src/vnet/ip-neighbor/ip_neighbor_api.c
src/vnet/ip-neighbor/ip_neighbor_dp.c
src/vnet/ip-neighbor/ip_neighbor_dp.h
src/vnet/ip-neighbor/ip_neighbor_types.c
src/vnet/ip-neighbor/ip_neighbor_types.h
src/vnet/ip-neighbor/ip_neighbor_watch.c
src/vnet/ip-neighbor/ip_neighbor_watch.h
src/vnet/ip/format.h
src/vnet/ip/icmp46_packet.h
src/vnet/ip/icmp6.c
src/vnet/ip/ip.api
src/vnet/ip/ip4.h
src/vnet/ip/ip46_address.c
src/vnet/ip/ip46_address.h
src/vnet/ip/ip4_forward.c
src/vnet/ip/ip6.h
src/vnet/ip/ip6_forward.c
src/vnet/ip/ip6_link.c
src/vnet/ip/ip6_link.h
src/vnet/ip/ip6_neighbor.c
src/vnet/ip/ip6_neighbor.h
src/vnet/ip/ip6_packet.h
src/vnet/ip/ip_api.c
src/vnet/ip/ip_neighbor.c
src/vnet/ip/lookup.c
src/vnet/ip6-nd/ip6_mld.c
src/vnet/ip6-nd/ip6_nd.api
src/vnet/ip6-nd/ip6_nd.c
src/vnet/ip6-nd/ip6_nd.h
src/vnet/ip6-nd/ip6_nd_api.c
src/vnet/ip6-nd/ip6_nd_proxy.c
src/vnet/ip6-nd/ip6_nd_test.c
src/vnet/ip6-nd/ip6_ra.c
src/vnet/ip6-nd/ip6_ra.h
src/vnet/ip6-nd/rd_cp.api
src/vnet/ip6-nd/rd_cp.c
src/vnet/ip6-nd/rd_cp.h
src/vnet/ip6-nd/rd_cp_api.c
src/vnet/l2/l2.api
src/vnet/l2/l2_api.c
src/vnet/l2/l2_arp_term.c
src/vnet/l2/l2_arp_term.h
src/vnet/l2/l2_bd.h
src/vnet/tcp/tcp.c
src/vnet/vnet_all_api_h.h
src/vpp/api/api.c
src/vpp/api/custom_dump.c
test/test_bond.py
test/test_container.py
test/test_ip4.py
test/test_ip4_irb.py
test/test_ip4_vrf_multi_instance.py
test/test_ip6.py
test/test_ip_ecmp.py
test/test_l2bd_arp_term.py
test/test_mpls.py
test/test_neighbor.py
test/test_ping.py
test/test_punt.py
test/test_sixrd.py
test/test_srmpls.py
test/test_udp.py
test/vpp_neighbor.py
test/vpp_papi_provider.py
96453fd2 16-Dec-2019 wanghanlin <wanghanlin@corp.netease.com>

vcl: RX event may lost when accept session repeatedly

Type: fix

Some applications may call accept repeatedly to process all connect
request until get EAGIAIN error. Subsequent call may get RX event of
previous accepted session, then should process it rather than just
discard it.

Signed-off-by: wanghanlin <wanghanlin@corp.netease.com>
Change-Id: Ice53442de66289a62591b79a9cc31e883e894c23

ecb9d18c 10-Dec-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: update quicly to v0.0.8-vpp

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I7470d79d1e39716ff83ba2d2b320813d79e2554c

3fd99047 16-Dec-2019 Neale Ranns <nranns@cisco.com>

fib: Glean on NBMA interface points to drop

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Iaae7a9e120bbf8168c581b06d3ac0e124b32e0e7

e7ee3009 16-Dec-2019 Neale Ranns <nranns@cisco.com>

fib: Adjacency walk fix for IPv6

Type: fix

Change-Id: Id3a1950e49d5eb1883af06a14df97e98f55162a8
Signed-off-by: Neale Ranns <nranns@cisco.com>

f50bac1b 06-Dec-2019 Neale Ranns <nranns@cisco.com>

vppinfra: bihash walk cb typedef and continue/stop controls

Type: feature

Change-Id: I28f7a658be3f3beec9ea32635b60d1d3a10d9b06
Signed-off-by: Neale Ranns <nranns@cisco.com>

77cfc017 15-Dec-2019 Neale Ranns <nranns@cisco.com>

fib: Adjacency creation notifications for dlegates

Type: feature

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3feddfe44dee528b9ca05aa0150e9423306ae49d

5d4b8912 13-Dec-2019 snaramre <snaramre@cisco.com>

tests: changes for scapy 2.4.3 migration

Type: fix
Change-Id: I7e041b666dabd90df23a920a1f1d99db4c10ddfe
Signed-off-by: snaramre <snaramre@cisco.com>

aa725786 13-Nov-2019 Steven Luong <sluong@cisco.com>

bonding: Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/partner-state

We already had /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/state in
the stats segment. Add also the partner-state to be complete.
Change to populate stats segment with the states at startup, after processing
an lacp pdu, and after timer expiration.

Unit test
---------
sudo vpp_get_stats dump | grep /if/lacp
63.00 /if/lacp/3/1/state
61.00 /if/lacp/3/1/partner-state
63.00 /if/lacp/3/2/state
61.00 /if/lacp/3/2/partner-state

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ib7b8e1183d572bb6e422a846aaa2b7b3559a0dc7

380e8578 10-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Fix timing & nits

Type: fix

Change-Id: I4fef896a3556df75532ef938ca2e263287dd74e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

407f593d 11-Dec-2019 Klement Sekera <ksekera@cisco.com>

ip: SVR: fix wrong return value

Type: fix

Change-Id: I9498b660bf2045bb6aac96d19bb9456a14b35847
Signed-off-by: Klement Sekera <ksekera@cisco.com>

4c6b1b6d 30-Nov-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix crash during SA rekey

Type: fix

Change-Id: Ib00ab9b2f28c0f4d85e96bf95697f61b8e415f37
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

64cf459b 12-Dec-2019 Florin Coras <fcoras@cisco.com>

vcl: fix disconnect from binary api

Type: fix

Change-Id: I4398d26879b5efd932fa1d9ae232aa918ec736d6
Signed-off-by: Florin Coras <fcoras@cisco.com>

6d5df8d2 11-Dec-2019 Dave Barach <dave@barachs.net>

vlib: fix "<command> help"

Walk the sub_commands vector directly.

Type: fix
Fixes: 6b3f25caff262b536a5449ac5461dd041c92a655

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3022b39e5a739647ec68effc6756166ce2da85b6

ef4f3e7f 11-Dec-2019 Florin Coras <fcoras@cisco.com>

session svm: support for segments larger than 4GB

Type: feature

Change-Id: I7d3017bbb369261d74f51807a226f2c12f45291c
Signed-off-by: Florin Coras <fcoras@cisco.com>

38277e40 06-Dec-2019 Ole Troan <ot@cisco.com>

gbp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia886858fe608782d64a5346dd33e1e9fa22d8b8f

62ddc030 09-Dec-2019 Florin Coras <fcoras@cisco.com>

session svm: per thread fifo segment slices

Type: refactor

Change-Id: I9be652e56cdb48b0aee3253f7ce8d9bed299d824
Signed-off-by: Florin Coras <fcoras@cisco.com>
Signed-off-by: Dave Barach <dave@barachs.net>

a0bf06d7 06-Dec-2019 Ole Troan <ot@cisco.com>

avf: explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If693e066eeb9312d4535893c279446dc43e8baa2

e6eaa24f 27-Nov-2019 Filip Varga <fivarga@cisco.com>

nat: session cleanup fix

Ticket: VPP-1795
Type: fix

Change-Id: Ib3b5742119d7013c293a11eb3dd1aadf46b422dd
Signed-off-by: Filip Varga <fivarga@cisco.com>

b644eb54 06-Dec-2019 Ole Troan <ot@cisco.com>

rdma: add explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I80c674b73b7f86cf159b8779aab31a87b20def9a

4f85968a 10-Dec-2019 John DeNisco <jdenisco@cisco.com>

docs: Rework the startup configuration section

Type: docs

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ic60aac96a4aeb5532f98dfb85c776bf549c0d660
Signed-off-by: Dave Barach <dave@barachs.net>

d4c70922 28-Nov-2019 Florin Coras <fcoras@cisco.com>

vcl: separate binary api connections per thread worker

Type: fix

Change-Id: I2d72efc74a3b0a5b9e4da265475b1b01bf361125
Signed-off-by: Florin Coras <fcoras@cisco.com>

0aa4013e 25-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

api: Use vl_msg_push/pop_heap

Type: refactor

Change-Id: I0eb46676fc22ce6825b2d879498df344b5a855e8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

cfdb1091 02-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: Add mq debug cli

Type: feature

This add a `show app message queue` cli command
that shows mq size per app & thread.

Change-Id: I5c6ce024b149fb7a47d899bc514c5a4887429982
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

c00f480b 03-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Add support for unidirectional streams

Type: feature

Change-Id: I3a642626a444504594c5e3df40dbc92df54136f0
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

f98e59b8 06-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Add option for multiple ips

Type: feature

Change-Id: I133f12f9075a09bda0c5c1ed143d03838b33f6da
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

038c7e66 10-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Use per thread next_cid

Type: fix

Change-Id: Ia89427257b78f6f7ba62c9d1076bf0593ee2dca7
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

5d4c99f2 26-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

devices: vhost API cleanup

Use consistent API types.

Type: fix

Change-Id: I2dec594cb834a45004edc9ca58ad7c7b4bd7ff06
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

deaf97f4 10-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Add aggregated quicly stats

Type: feature

Change-Id: Ice8de7030a0330cfe77a58657701f0703e0695dd
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

1802fcc5 06-Dec-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: add more detailed statistics

Type: feature

Change-Id: I3df7b054ec08c7b307413d24468fc3df6a5aacc3
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

5de4fb70 03-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

devices: tap API cleanup

Use consistent API types.

Type: fix

Change-Id: I11cc7f6347b7a60e5fd41e54f0c7994e2d81199f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

8dc75c0c 10-Dec-2019 Neale Ranns <nranns@cisco.com>

ipsec: Init salt value in SA creation CLI (so it's not random)

Type: fix

Change-Id: Idf4d0b59a1eb2c739a67a4786470884050f81561
Signed-off-by: Neale Ranns <nranns@cisco.com>

05d7312e 27-Nov-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: removing quicly_send call from quic_accept_connection

Type: fix

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I429b50b88c8e029b06854c7433d0bc77619e98a3

684fb6e9 10-Dec-2019 Florin Coras <fcoras@cisco.com>

api: pass api and client main to rx thread

Type: fix

Change-Id: Ib8313e87a89c80045edd897924917a88b98d1937
Signed-off-by: Florin Coras <fcoras@cisco.com>

0fa66d61 09-Dec-2019 Ole Troan <ot@cisco.com>

ioam: use explicit api types

Also remove API boilerplate.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I62e795f5af3843af7912707ade4ba178ff326942

668605fc 09-Dec-2019 Ole Troan <ot@cisco.com>

ip: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1fd190da28a765ba430952539c291a741aaa3dce

3013e698 09-Dec-2019 Ole Troan <ot@cisco.com>

flowprobe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I4f1cccca7de0c07cee472bde80cd6b0ef60046bd

39d69112 27-Nov-2019 Dave Barach <dave@barachs.net>

api: multiple connections per process

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2272521d6e69edcd385ef684af6dd4eea5eaa953


src/plugins/dhcp/dhcp6_ia_na_client_cp.c
src/plugins/dhcp/dhcp6_pd_client_cp.c
src/plugins/dns/dns.c
src/plugins/hs_apps/echo_client.c
src/plugins/hs_apps/echo_server.c
src/plugins/hs_apps/proxy.c
src/plugins/hs_apps/sapi/vpp_echo.c
src/plugins/lacp/lacp_api.c
src/plugins/mactime/mactime.c
src/plugins/mactime/mactime_top.c
src/plugins/nat/nat.c
src/plugins/nsh/nsh_api.c
src/svm/svm.c
src/tools/vppapigen/vppapigen_c.py
src/vat/api_format.c
src/vat/main.c
src/vcl/vcl_bapi.c
src/vcl/vcl_private.c
src/vlibapi/api.h
src/vlibapi/api_common.h
src/vlibapi/api_shared.c
src/vlibmemory/memory_api.c
src/vlibmemory/memory_client.c
src/vlibmemory/memory_client.h
src/vlibmemory/memory_shared.c
src/vlibmemory/socket_api.c
src/vlibmemory/socket_client.c
src/vlibmemory/vlib_api.c
src/vlibmemory/vlib_api_cli.c
src/vnet/bfd/bfd_api.c
src/vnet/bier/bier_api.c
src/vnet/bonding/bond_api.c
src/vnet/classify/classify_api.c
src/vnet/cop/cop_api.c
src/vnet/devices/af_packet/af_packet_api.c
src/vnet/devices/netmap/netmap_api.c
src/vnet/devices/pipe/pipe_api.c
src/vnet/devices/tap/tapv2_api.c
src/vnet/devices/virtio/vhost_user_api.c
src/vnet/devices/virtio/virtio_api.c
src/vnet/ethernet/p2p_ethernet_api.c
src/vnet/feature/feature_api.c
src/vnet/geneve/geneve_api.c
src/vnet/gre/gre_api.c
src/vnet/gso/gso_api.c
src/vnet/interface_api.c
src/vnet/ip/ip_api.c
src/vnet/ip/punt_api.c
src/vnet/ip/rd_cp.c
src/vnet/ipfix-export/flow_api.c
src/vnet/ipsec/ipsec_api.c
src/vnet/l2/l2_api.c
src/vnet/l2tp/l2tp_api.c
src/vnet/lisp-cp/lisp_api.c
src/vnet/lisp-cp/one_api.c
src/vnet/lisp-gpe/lisp_gpe_api.c
src/vnet/lldp/lldp_api.c
src/vnet/mpls/mpls_api.c
src/vnet/pg/pg_api.c
src/vnet/policer/policer_api.c
src/vnet/qos/qos_api.c
src/vnet/session/session.c
src/vnet/session/session_api.c
src/vnet/span/span_api.c
src/vnet/srmpls/sr_mpls_api.c
src/vnet/srv6/sr_api.c
src/vnet/syslog/syslog_api.c
src/vnet/tcp/tcp_api.c
src/vnet/udp/udp_api.c
src/vnet/vxlan-gbp/vxlan_gbp_api.c
src/vnet/vxlan-gpe/vxlan_gpe_api.c
src/vnet/vxlan/vxlan_api.c
src/vpp-api/client/client.c
src/vpp-api/client/test.c
src/vpp-api/vapi/vapi.c
src/vpp/api/api.c
src/vpp/api/api_main.c
src/vpp/api/gmon.c
src/vpp/api/test_client.c
src/vpp/api/test_ha.c
6b3f25ca 09-Dec-2019 Dave Barach <dave@barachs.net>

vlib: improve test coverage

Add tests.
Remove unused rule-based parser code.

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I3ca3a9dd9da8ee8f3a47004c98f2f5644db10057

5224b5cb 07-Dec-2019 Florin Coras <fcoras@cisco.com>

api: fix sock reg passing on read event

Type: fix

Change-Id: I383242e04a114b69fe247d912842be3560e96c10
Signed-off-by: Florin Coras <fcoras@cisco.com>

4505f015 07-Dec-2019 Benoît Ganne <bganne@cisco.com>

ipsec: make sure pad_bytes does not exceed pad data size

This helps GCC understand the memcpy will not overflow pad_data. GCC-6
(default on Debian 9) in particular got confused.

Type: fix

Change-Id: I176eb01531b9d5c7ebec40f015e510b2d56e77c4
Signed-off-by: Benoît Ganne <bganne@cisco.com>

4a65b910 08-Dec-2019 Ole Troan <ot@cisco.com>

marvell: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1af842f38f90d3ede971da74cd28179b61f613cf

55636cb6 08-Dec-2019 Ole Troan <ot@cisco.com>

gtpu: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I16fcbd5e63526dbf062a3032701479324fe2a4f5

60f5108a 08-Dec-2019 Ole Troan <ot@cisco.com>

l3xc: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia94eab60689a07de522b8106dd48ff6b669bc770

a633a431 06-Dec-2019 johny <jan.cavojsky@pantheon.tech>

ip: coverity fix

Delete Null-checking "p0" in function ip6_tcp_udp_icmp_bad_length,
because it's not necessary.

Type: fix

Signed-off-by: johny <jan.cavojsky@pantheon.tech>
Change-Id: I2bf43a60c1c1d76e42581df27f2285c9e9563093

ebef4a9e 06-Dec-2019 Ole Troan <ot@cisco.com>

lacp: use explit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3f19c69a6f6282a97fd591adcd1e4490cf21e743

3f2d5718 06-Dec-2019 Ole Troan <ot@cisco.com>

lacp: fix control_ping from plugins

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I030f75234a346ef6a20640c1a0ed65f4934867f2

7929f9f5 06-Dec-2019 Ole Troan <ot@cisco.com>

stn: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifba4ff0e0f61641ca3f5e7bb72086cb4f32f1909

277f03f0 06-Dec-2019 Ole Troan <ot@cisco.com>

vmxnet3: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2e699fc812c45f88e359f0f7231f372955e70149

8e388390 06-Dec-2019 Ole Troan <ot@cisco.com>

vlib: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib3a5d9fc36692553eb109976e9365dc7d82911ab

be31c2a2 06-Dec-2019 Ole Troan <ot@cisco.com>

map: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8f01f9e71c788fbca989d43d5b87da9c33fba0b1

5e913f37 06-Dec-2019 Ole Troan <ot@cisco.com>

svs: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ic9570fca7e434c9b861be8ed064503492225f9fd

04338e85 06-Dec-2019 Ole Troan <ot@cisco.com>

pppoe: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifd1e1907740e55420dc040eb2afbbbf9887aea3c

69885b72 28-Nov-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: update quicly to v0.0.7-vpp

Type: feature

Change-Id: Ieeb9abb59b4d094bbd7bfc04a9007d3cebd645d7
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

8d820857 27-Nov-2019 Florin Coras <fcoras@cisco.com>

api: avoid swapping vlib_rp before barrier sync

Type: fix

Change-Id: I9868d13e827c6f5aa5535a38f629efb62ff12dbc
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>
Signed-off-by: Florin Coras <fcoras@cisco.com>

157a4ab4 06-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: fix the tap/virtio driver for header offset

Type: fix

Change-Id: Ied34466907fa8ad44f997c600dbf481be4d22027
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

b0384230 06-Dec-2019 Florin Coras <fcoras@cisco.com>

api: fix free socket process args

Type: fix

Change-Id: I910be067de6ed65790d25cc95a3d8b5b66680567
Signed-off-by: Florin Coras <fcoras@cisco.com>

7b22df06 06-Dec-2019 Ole Troan <ot@cisco.com>

mactime: update api to use explicit types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id347e77d0230bf1b22df75bf1ae63a50eaf4d564

b2e463a1 06-Dec-2019 Ole Troan <ot@cisco.com>

l2e: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1888a8247ef03cfb715a2c0e0e3ca2a108fecbc8

6d75c20a 06-Dec-2019 Ole Troan <ot@cisco.com>

dpdk: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iff7e995499e422003147342ff14de483d807b3f3

d4efce2e 06-Dec-2019 Ole Troan <ot@cisco.com>

ct6: use explicit type in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2342baa91234db1336394305c031dbfa21d219a5

07e557a7 06-Dec-2019 Ole Troan <ot@cisco.com>

cdp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If50e66638554e0fcfc72d35a89a39379dfcb530d

bdde5853 06-Dec-2019 Ole Troan <ot@cisco.com>

abf: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9462de3d27b88539bff87c07a59987dd62fb2add

4a7fc4cf 06-Dec-2019 Ole Troan <ot@cisco.com>

igmp: use explicit types in api

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifdb623c092cf0a9d9e24117edc32c6ddf014052f

6aaee8c7 06-Dec-2019 Ole Troan <ot@cisco.com>

ikev2: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2171ef678ecad12d681668257498a5a62004152f

d3f0a486 06-Dec-2019 Ole Troan <ot@cisco.com>

nsh: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8fd870e757e9243d4f0916dfbbe65495f7e1a8c6

e06e7c67 06-Dec-2019 Ole Troan <ot@cisco.com>

nsim: use explicit api types

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icdc359beb127944418305775e42fa88c569dfbd7

59cea1a9 25-Nov-2019 Florin Coras <fcoras@cisco.com>

api: multiple socket connections per single process

Type: feature

Change-Id: Idea1857eb2225881d2982a7aa2ae7a79536b3f33
Signed-off-by: Florin Coras <fcoras@cisco.com>

f1910326 05-Dec-2019 Florin Coras <fcoras@cisco.com>

session: close for reset replies independent of state

Type: fix

Change-Id: I8b8875f1dc9203dfbb443ac43df8250cbb0b1edc
Signed-off-by: Florin Coras <fcoras@cisco.com>

3eba7f15 16-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: fix tail rescue with sacks

Type: fix

Change-Id: Iad73f47cef3d29c4b0b7d1f58f2f2b14ba4b1d38
Signed-off-by: Florin Coras <fcoras@cisco.com>

61e3ade8 05-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: move bfd over gre to extended tests

This test should be fixed or removed.
EXTENDED_TESTS should not become "BROKEN_TESTS"

Type: test

Change-Id: Id998f0d3b7bd31100f917d076fbd7ddb46d99ed2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

ce7fd674 05-Dec-2019 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile

Type: fix

Plug-in for IPv6 Segment Routing Mobile

Fix the static analysis issue on srv6-mobile/gtp4_d function.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I5c419b76a30c9616dc3557267fcceed0d512b67e

9f356961 04-Dec-2019 Matthew Smith <mgsmith@netgate.com>

map: fix MAP-T ip6 port check

Type: fix
Ticket: VPP-1804

Fix a regression introduced by 640edcd90.

The port set ID on received IPv6 packets for MAP-T was being
checked against the destination port. It should be checked
against the source port.

Added a new unit test to verify that a v6 packet with a good
source port is translated and forwarded and a v6 packet with
a bad source port is dropped. The important part of the test
which will prevent similar future regressions is that the
source port and destination port are not equal. The existing
unit test used the same source and destination port which is
why it did not fail when the regression was introduced.

Change-Id: Idc144ea509722bb9e0f80b3887d220384a04e6d6
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

1063f2ae 05-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: quic enable per testcase timeout overrides

Type: test

Change-Id: I4f8aee3efa53d58f96631fe2d2da5756304fb75a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

87d24db6 04-Dec-2019 Dave Barach <dave@barachs.net>

classify: vpp packet tracer support

Configure n-tuple classifier filters which apply to the vpp packet
tracer.

Update the documentation to reflect the new feature.

Add a test vector.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Iefa911716c670fc12e4825b937b62044433fec36

17478e4e 11-Oct-2019 johny <jan.cavojsky@pantheon.tech>

ip: fix cancel termination after receive malformed ip6 packet

This fix is for cancel termination of vpp after receive malformed
packet type of ip6.To avoid termination of vpp are checked if are
missing data in packet. This occours, when payload length in ip6
header packet is more than real count of data in packet. When
this error occours, packet is ignore.

Type: fix
Ticket: VPP-1693, VPP-1694

Change-Id: I9d9ecea7b75c8702cb31aa8051c8d4d7ce19659d
Signed-off-by: johny <jan.cavojsky@pantheon.tech>

70d8ef89 05-Dec-2019 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile

Type: feature

Plug-in for IPv6 Segment Routing Mobile

Support the plug-in function in SR Policy.
Support GTP4.D plug-in as SR Policy plug-in.

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: I306160b7203921d879940193868944158867c482

66cea092 05-Dec-2019 Klement Sekera <ksekera@cisco.com>

tests: fix wrong checksum error message

This change fixes the error message, which would previously report
mismatch on IPv6 layer instead of TCP layer.

Type: fix

Change-Id: Ie78779685362a420d155f928b3cdb341bc3fb8bc
Signed-off-by: Klement Sekera <ksekera@cisco.com>

95d2f30f 04-Dec-2019 Jon Loeliger <jdl@netgate.com>

classify: Fix 2 coverity errors

Validate two tainted scalars, filter_sw_if_index, that
came from an API message.

Type: fix
Change-Id: I3ac8a09f91f380185e36babeaa6330691f7cb24b
Signed-off-by: Jon Loeliger <jdl@netgate.com>

fd574087 27-Nov-2019 Ole Troan <ot@cisco.com>

papi: add call stats

Type: feature
Change-Id: Ic6d44122d3e62e09402e3f1946f7e57e9b5e7c5f
Signed-off-by: Ole Troan <ot@cisco.com>

8b2fffd9 02-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: Revert "Python Tests: Make VppTestCase unit testable."

Type: test
This reverts commit 087c811b63aa6b0575149749e188bb37e7fb0513.

Change-Id: Ica12597f27d5a75c33c12c2d27a227dc4866adcb
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

0c629323 28-Nov-2019 Ole Troan <ot@cisco.com>

tests: add test run time.

Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id7b30b5fe63e68ae88f3a42aa77d2614ccda724d

1ec9fdbf 04-Dec-2019 Chenmin Sun <chenmin.sun@intel.com>

vxlan: fix vxlan hw offload issue

Type: fix

Since Vxlan hw offload jumps the ethernet-input node, so needs to
adjust the data offset accordingly

In original code, the current_data is 0 when arriving vxlan-flow-input
node(due to no graph node before it, except the dpdk-input), so this
code block cannot find the correct vxlan header:
enum
{ payload_offset = sizeof (ip4_vxlan_header_t) };
vlib_buffer_advance (b0, payload_offset);
see code in src/vnet/vxlan/decap.c, function vxlan4_flow_input_node

This patch fixes this issue

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Iab4af7a7dc3b69a117a4c9ea1c59662669a6438c

901467ed 04-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: fix session_main_get_worker_if_valid

Type: fix

Change-Id: Ie024792015f3c9c52102c9be03da63c79f3456af
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

b2955355 03-Dec-2019 Yu Ping <ping.yu@intel.com>

vcl: resolve VCL part session cleanup issue

In Nginx performance test, we notice that there are so many session kept
open with the state of TRANSPORT_DELETE, and it is root caused that
vppcom fails to return close state.

Type: fix

Change-Id: Ia30f959e0e5adb5b8bcfa13fb1dd7b2cb410a31b
Signed-off-by: Yu Ping <ping.yu@intel.com>

ce9bdfe5 28-Nov-2019 Yu Ping <ping.yu@intel.com>

tls: change SSL_has_pending to avoid BIO check error

Type: fix

Change-Id: I454aff1b187b75a1328c90e30b9b487377ae5f68
Signed-off-by: Yu Ping <ping.yu@intel.com>

e89bfe33 04-Dec-2019 Dave Wallace <dwallacelf@gmail.com>

build: fix vom_test dependency on EXTENDED_TESTS

- Note: This was not caught by CI because the VPP 'make verify'
target always build libvom.so

Type: fix
Fixes: f0797d130

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I8663e317e4e793c386b09d1cb887133de1e43faf

72e7312a 22-Oct-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: add protocol header parser

Type: feature

Change-Id: I7c6be2b96d19f82be237f6159944f3164ea512d0
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

1043fd38 03-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix exception handling around vapi.connect()/.disconnect()

vapi.connect() only raises subclasses of vpp_papi.VPPIOError.
vapi.disconnect() doesn't raise any exceptions, removed uneeded try block.

Type: test

Change-Id: Ide6e6db298b205f14382065862e358757619a5ba
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

207083f5 03-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: add interface function chaining

Type: test

Change-Id: I24e740aa87a8a4061fa98740f2d636997e18f08d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

3f4be92c 30-Oct-2019 Mohsin Kazmi <sykazmi@cisco.com>

vom: get interface type from vpp device type

Type: feature

Change-Id: Ia626188c22dc80c2b7a06b61cf0af435ee53d1e7
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

3bab8f9c 04-Dec-2019 Neale Ranns <nranns@cisco.com>

fib: Decouple source from priority and behaviour

Type: feature

the fib_source_t enum alone no longer defines the priority and
behaviour, instead each source must be allocated these attributes.
This allows the creation of other sources by the plugins (and
soon over the API).

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I890ee820fbc16079ee417ea1fbc163192806e853

5f8f6173 18-Apr-2019 Neale Ranns <nranns@cisco.com>

gre: Multi-point interfaces

Type: feature

Change-Id: I0129ad6ace44a50a8a3b26db8e445cd06b2b49e8
Signed-off-by: Neale Ranns <nranns@cisco.com>

79619c10 04-Dec-2019 Jon Loeliger <jdl@netgate.com>

build: Add Jon Loeliger as plugin/MAP maintainer.

Change-Id: I2e25e6f9481afd7370bad4332906a2a7f0e78081
Type: make
Signed-off-by: Jon Loeliger <jdl@netgate.com>

3aae3dc7 04-Dec-2019 Jon Loeliger <jdl@netgate.com>

map: Fix a coverity MAP dead-code issue.

Type: fix

Change-Id: I5467bbe3b25b1ea3fb44157abe6e7bfb3f191e77
Signed-off-by: Jon Loeliger <jdl@netgate.com>

f0797d13 15-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

build: fix make test with distributed src

This patch addresses the functionality that is
missing for distributed make test source files.
In addition it extends the concept of colocating
test source code with functional source code
(eg. src/vcl/test). It also cleans up deficiencies
in the make test makefiles.

NOTE: Due to the way sphinx document tools work,
all test, all of the make test python code is
gathered using soft links into the directory:
.../build-root/build-test/src

Change summary:
- Remove 'make test' help details from
main makefile help output to reduce clutter
and redundant help output
- Move all generated build output to
.../build-root/build-test
- Move test_vcl.py as first usecase for
distributed core feature make test code
- Add test-wipe-all target and fix wipe targets
to remove all generated files
- Fix 'make test-doc' to generate module
documentation for all source files
- Remove unused targets in test/doc/Makefile
- Fix 'make test-shell'
- Fix test/ext Makefile to not generate
bogus output

Type: fix
Fixes: a43c93f8554ad7418e31be3791b3fb71232f60ac

Change-Id: Icc2ddb81d474081c3ede4548ecd7a0624651f62d
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

c9cb8f6d 03-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: fix stream tx_fifo race condition

Type: fix

There is a race condition in when receiving TX from
a client application :
As egress_emit writes as much data as possible to
the stream, if during egress_emit the app writes
to the fifo, the data will be directly passed to
quicly. Then TX callback happens and triggers
a scheduler update telling quilcy the stream has
data to send. When the next egress_emit is called
and no more data has come, we have nothing to write,
we return len = 0 to quicly which breaks an assert if
a loss happens later on.

Change-Id: I47e00a14dfc9068b5dac7b5c090a89124aea004f
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

d9577b4a 02-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: clean accept/connect error codepath

Type: fix

First attempt to clean the leftover state when
accept_notify / connect_notify fails due to mq
size constraints. vpp should now be left in a
state such that clean state will eventually be
reached when timers fire.

Change-Id: I9e1166dab2778bf05d5af42d437769651369cae0
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

3f5594d8 03-Dec-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: remove the interface count

Type: refactor

Change-Id: I51405b9d09fb6fb03d08569369fdd4e11c647908
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

deb268fe 02-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: refactor connection search fn

Type: refactor

Change-Id: I55aace44773e4fab0470d27b14dd68544f7d99c5
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

2f566c23 02-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: add conn-timeout config option

Type: feature

Change-Id: Ia9cb57b9f7c2d14a137556d6918763f1cb11850d
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

65f6cfcd 27-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: fix import typo

Type: fix

Change-Id: Iab96ebc1579b0be5b711f975163f9ac96648d2ad
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

a90b26c1 03-Dec-2019 Jon Loeliger <jdl@netgate.com>

ip6: Fix improper MCAST adj test in IPv6 router solicitation

Type: fix
Fixes: cb9cadad578297ffd78fa8a33670bdf1ab669e7e

Change-Id: Id6de9780da41db5d762fe042f533cfaf21ed7b73
Reported-by: Rajith PR <rajith@rtbrick.com>
Signed-off-by: Jon Loeliger <jdl@netgate.com>

b3174dfe 03-Dec-2019 Matthew Smith <mgsmith@netgate.com>

ip: populate ip_reassembly_get_reply correctly

Type: fix
Fixes: de34c35fc

The API handler for requests to retrieve IP reassembly settings was
modified to support shallow virtual reassembly. It retrieves
settings into local variables now instead of directly into the reply
message. The fields in the reply message were not being populated
using those variables. So the reply message was being sent with all
0's, except in the is_ip6 field.

Also, the max_reassembly length field in the reply message was not
being populated.

Change-Id: I80b071340fdc190c3a0b1f7294a03f14b6e00ecc
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

960eeea7 02-Dec-2019 Neale Ranns <nranns@cisco.com>

fib: constify the adjacency in the rewrite nodes

Type: refactor

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I3aad20b35d89fc541fdf185096d71ca12b09a6e2

9534696b 25-Nov-2019 Neale Ranns <nranns@cisco.com>

ipip: Tunnel flags controlling copying data to/from payload/encap

Type: feature

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I9467f11775936754406892b8e9e275f989ac9b30

c8972fe5 02-Dec-2019 Neale Ranns <nranns@cisco.com>

fib feature: Code mechanics to decouple dependency of feature on adj

Type: refactor

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I1d8b88fe1eefc850865297b4f025b97e6373a6bd

a6460e46 03-Dec-2019 Jon Loeliger <jdl@netgate.com>

build: Separate ip and ip6 maintainers

Boldly assign IPv6 to Neale and to me.
Ole said so. Really!

Change-Id: Iaa30a57230558dcf3ee016a94479cac95bb2d50d
Type: make
Signed-off-by: Jon Loeliger <jdl@netgate.com>

4a6d093e 21-Nov-2019 Jon Loeliger <jdl@netgate.com>

map: Avoid null dereference in 'map show' and 'map del'

If a map domain is created without a tag name, inspecting
the map data will segfault looking for an unset name in
the so-called "domain extras" vector.

Enhance "show map domain" to show all map domains.

Type: fix
Change-Id: Ic55662b84eec58221816da270b2ef9e89c3a31c3
Signed-off-by: Jon Loeliger <jdl@netgate.com>

08f26641 03-Dec-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Less verbose logging for many sessions

Type: feature

ECHO_LOG has the following levels
0 -> global progression (many connections)
1 -> Connection global evts (some conn, much data)
2 -> More connection events
3 -> Data related logging

Change-Id: I69eeaa0dd02a4b8ebcfefa1c7a218ef57f217d2b
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

692bfc85 27-Aug-2019 Jakub Grajciar <jgrajcia@cisco.com>

classify: API cleanup

Use consistent API types.

Type: fix

Change-Id: Ib5b1efa76f0a9cecc0bc146f8f8a47c2442fc1db
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

e2ccdf03 02-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: add a per-call _timeout option

add the ability to override the default timeout value on a per-call
basis.
Use:
rv = self.vapi.papi.cli_inband(cmd='wait 10', _timeout=15)

Type: feature

Change-Id: Ia90a58586a1f63e02118599a2a4b7141e5a0b90d
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

5d440d9c 02-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: vpp_interface fix ip6 setter

Type: fix
Fixes: efd7bc2b1c8db160933ed3e9ab3cde0d07aaf863

Change-Id: I254f9fe44189f88621b9b0ff3f869efb9966ada5
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

dbf68c9a 13-Nov-2019 Prashant Maheshwari <pmahesh2@cisco.com>

ipsec: Changes to make ipsec encoder/decoders reusable by the plugins

Type: fix

Signed-off-by: Prashant Maheshwari <pmahesh2@cisco.com>
Change-Id: I81b937fc8cfec36f8fb5de711ffbb02f23f3664e
Signed-off-by: Prashant Maheshwari <pmahesh2@cisco.com>

abde62fb 02-Dec-2019 Neale Ranns <nranns@cisco.com>

tests: GRE over IPSec unit tests

Type: test

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I4ae1b56f273026aca86775fb61feabcdeb62c62e

e52d8d88 01-Dec-2019 Dave Barach <dave@barachs.net>

vppinfra: preserve total_cpu_time across clock freq adjustment

If clib_time_verify_frequency() adjusts the clock frequency, transform
total_cpu_time to the new time coordinate space. Otherwise, we break
comparisons with previous clib_time_now() value.

Without this correction, time jumps in one direction or the other
depending on the sign of the frequency change. Reasonably harmless in
most cases, but under perfect storm conditions the wheels fall off.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I21802c2630e2c87ff817cd732b7d78bc022cd2d7

5ef9ca6c 02-Dec-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: raise exception in vpp_interface for invalid sw_if_index

Type: test

Change-Id: I34058f2bd20f61a8f8355299a8df95f2948c25eb
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

e83aa456 14-Nov-2019 Matthew Smith <mgsmith@netgate.com>

bonding: add/del secondary mac address callback

Type: feature

Add a callback to the bond device class which allows a secondary
mac address to be added/deleted.

The desired operation is performed on all the hardware interfaces
which belong to the bond interface. This allows virtual MAC
addresses to be used on bond interfaces without requiring the
hardware interfaces to have promiscuous mode enabled.

When a hardware interface is added or removed from a bond, if there
are any secondary MAC addresses configured on the bond, they are
added or removed from the hardware interface.

Change-Id: If9488078b4d7869ecc56ef6853f3cc9891211860
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

73aff479 02-Dec-2019 snaramre <snaramre@cisco.com>

tests: BFD python3 changes

Type: fix
Change-Id: Ie441e81fe3971d70f96196c79d74658f910b4875
Signed-off-by: snaramre <snaramre@cisco.com>

ce43569d 29-Nov-2019 Jerome Tollet <jtollet@cisco.com>

dhcp: add FEATURE.yaml for the DHCP plugin

Type: docs

Signed-off-by: Jerome Tollet <jtollet@cisco.com>
Change-Id: Ia2b892e550d391d421d9980d736768c918955cb6

d3955fb1 29-Nov-2019 Florin Coras <fcoras@cisco.com>

session: no cleanup notification for forced deletes

Type: refactor

Change-Id: Ib36cc3f1173d093e9050f9fecda343df2aa3dc1f
Signed-off-by: Florin Coras <fcoras@cisco.com>

3268a64d 29-Nov-2019 Dave Barach <dave@barachs.net>

classify: debug cli %v not %s

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I294f0b773375f6dce020b771db0726ceb5d812cc

757de987 27-Nov-2019 Florin Coras <fcoras@cisco.com>

ip: init l3_hdr_offset when pushing an ip4 header

Type: fix

Change-Id: I87503b9a981724b1f3ff1c45a4a5f7a43024ca76
Signed-off-by: Florin Coras <fcoras@cisco.com>

bfd7d294 27-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vlib: add 'wait' cli command

When running exec scripts, there can be a need to wait between statements.

Type: feature

Change-Id: I2a45b390697e09fc222358c9354f28e3368a06ba
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

1a7ed5e3 21-Nov-2019 Benoît Ganne <bganne@cisco.com>

tests: display stdout and stderr when output caching is disabled

Type: fix

Change-Id: I4286ba58bb15dd67c1199f76166bedf3b4e0344c
Signed-off-by: Benoît Ganne <bganne@cisco.com>

d3b8c861 22-Nov-2019 Alexander Chernavin <achernavin@netgate.com>

nat: fix dhcp client on outside interface with output feature

When a DHCP client is configured on a NAT outside interface with
output feature enabled, DHCP packets will reach the NAT in2out-output
node and will be dropped with "out of ports" reason.

With this commit, allow locally originated DHCP packets to be sent
from a NAT outside interface with output feature enabled.

Type: fix

Change-Id: I47d76b22587f2bf0c7b0b9dfda41c89f8f61d0b4
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>

9fb6d40e 15-Apr-2019 Benoît Ganne <bganne@cisco.com>

misc: add address sanitizer heap instrumentation

Introduce AddressSanitizer support: https://github.com/google/sanitizers/
This starts with heap instrumentation. vlib_buffer, bihash and stack
instrumentation should follow.

Type: feature

Change-Id: I7f20e235b2f79db72efd0e756f22c75f717a9884
Signed-off-by: Benoît Ganne <bganne@cisco.com>

99fbf057 26-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: fix typo in repr

Reported by Vratko's review.
(Thanks for the review)

Fixes: 14b0b4791c0b8c886e7b5c9ca667d060f0bada0b

Type: fix

Change-Id: I9c080c0c40060cc77977e76edae03d60eb393ce2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

9efcee6e 26-Nov-2019 Neale Ranns <nranns@cisco.com>

fib: Fix crash on cover update to non activated adj source

if the adj source is not active then there is no existing cover
during a cover update

Type: fix
Ticket: VPP-1803
Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie912f1c99345de4fb012bdcd97b443098d4a7351

acaa04a2 26-Nov-2019 Jon Loeliger <jdl@netgate.com>

map: Fix inverted 'map security check enable' CLI flag.

Type: fix
Fixes: 5a2e278a09726be627b8310e03f0522d60aafedf

Change-Id: Ibdc2f0be44e382bfa4a8f3e16be8d6239d7a0ec1
Signed-off-by: Jon Loeliger <jdl@netgate.com>

c298f376 12-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Refactor for crypto contexts

Type: refactor

Change-Id: I5ec7079d34826edd7a3048ae1d44037386f5d3ff
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

be2ad0b4 21-Nov-2019 Chenmin Sun <chenmin.sun@intel.com>

flow: fix several crash issues

Type: fix

This patch fixes crash issues(marked in brackets) in the below test cases

test flow enable index 0 1/1 -> [crash]
test flow disable index 0 1/1 -> [crash]

test flow add src-ip 192.168.8.8 proto udp redirect-to-queue 8
test flow enable index 0 1/1
test flow disable index 0 1/1 - [crash]

test flow add src-ip 192.168.8.8 proto udp redirect-to-queue 8
test flow enable index 0 1/1
test flow enable index 0 1/2
test flow del index 0 -> [crash]

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I84bc6faa3d93a2cab4c82e8a876a8b1067257b62

7dbf9a1a 21-Nov-2019 Klement Sekera <ksekera@cisco.com>

fib: reduce save_rewrite_length to u8

This is a preparation step for migrating NAT to use SVR (shallow virtual
reassembly) to conserve space in vnet_buffer. Since max rewrite length
is currently pre-data size (128), u8 is sufficient to hold that value.

Type: refactor

Change-Id: I5374bb396e178245b870cb0bbf1370d2a54230bc
Signed-off-by: Klement Sekera <ksekera@cisco.com>

981a690b 21-Nov-2019 Neale Ranns <nranns@cisco.com>

fib: Another realloc burn

Type: fix

harmless this time since it only affects the debug statement, but
it still crashes an ASAN image.

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: Ie02e7fe3014b98b9f8c83447f59017a380ab3948

2b65f9ca 21-Nov-2019 Benoît Ganne <bganne@cisco.com>

misc: add gdb helpers for vlib buffers

Type: feature

Change-Id: I7e619040857310fffd33c355f6c491a55f7a4a02
Signed-off-by: Benoît Ganne <bganne@cisco.com>

e69f4714 26-Nov-2019 Hongjun Ni <hongjun.ni@intel.com>

lb: lb_add_del_vip and lb_add_del_as doesn't work.

Ticket: FDIO-753
Type: fix

Change-Id: I4a8cf06970b658dfa15768459a3ff76571d6dfff
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>

30cca512 25-Nov-2019 Benoît Ganne <bganne@cisco.com>

build: remove valgrind leftovers

Valgrind never really worked well with VPP. Remove the partial support.

Type: refactor

Change-Id: Ic09773fd85f904fdd2240bc161e23a4c2b196cf6
Signed-off-by: Benoît Ganne <bganne@cisco.com>

42bde459 18-Nov-2019 Matthew Smith <mgsmith@netgate.com>

ethernet: all dmac checks include secondary addrs

Type: feature

In ethernet_input_inline(), when verifying that the destination
mac address on a received packet matches the mac address of the
interface where the packet was received, check the secondary
addresses on the interface if the primary address does not match.

This was done previously for eth_input_single_int().

Change-Id: I45716184dd789d83852271f9c79cedf5f6cbf75b
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

9db6ada7 08-Nov-2019 Neale Ranns <nranns@cisco.com>

fib: Table Replace

Type: feature

from the API doc, a table replace is:

"
The use-case is that, for some unspecified reason, the control plane
has a very different set of entries it wants in the table than VPP
currently has. The CP would thus like to 'replace' VPP's current table
only by specifying what the new set of entries shall be, i.e. it is not
going to delete anything that already eixts.
the CP delcartes the start of this procedure with this begin_replace
API Call, and when it has populated all the entries it wants, it calls
the below end_replace API. From this point on it is of coursce free
to add and delete entries as usual.
The underlying mechanism by which VPP implements this replace is
purposefully left unspecified.
"

In the FIB, the algorithm is implemented using mark and sweep.

Algorithm goes:
1) replace_begin: this marks all the entries in that table as 'stale'
2) download all the entries that should be in this table
- this clears the stale flag on those entries
3) signal the table converged: ip_table_replace_end
- this removes all entries that are still stale

this procedure can be used when an agent first connects to VPP,
as an alternative to dump and diff state reconciliation.

Change-Id: I168edec10cf7670866076b129ebfe6149ea8222e
Signed-off-by: Neale Ranns <nranns@cisco.com>

0d3d4824 25-Nov-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tap: fix coverity warning 205875

check the return result from fcntl, and if error, behave
the same way the expansion of _IOCTL macro does.

Type: fix
Change-Id: I6d537d1bdedae64470612aef64b46e07387fe84b
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

599db9e9 25-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: honor cc pacing rate when resetting pacer

Type: fix

Change-Id: I36558b67d38266def9dfe45777d9757a33ce2569
Signed-off-by: Florin Coras <fcoras@cisco.com>

b72a0ff7 23-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: invalidate expired timer handles before dispatching

Type: fix

Change-Id: Icc8cd05cb9c1844a9f8b0399797ad554f4ccf1a1
Signed-off-by: Florin Coras <fcoras@cisco.com>

3afac8f8 25-Nov-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: update quicly to v0.0.6-vpp

Type: feature

Change-Id: Ib604cfdd55b72f0bc605d1d1e8b387e532b0a255
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

41a817a3 23-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: fix typo in test_vlib

Trailing comma made last line of a multi-line command a new command.

Logs:
22:39:49,695 Return value: cli_inband_reply(_0=794, context=2, retval=0, reply='loop0\n')
22:39:49,695 CLI: packet-generator new {
name vlib
limit 15
size 128-128
interface loop0
node ethernet-input
data {
IP6: 00:d0:2d:5e:86:85 -> 00:0d:ea:d0:00:00
ICMP: db00::1 -> db00::2
incrementing 30
}

22:39:49,695 Calling cli_inband('cmd':'packet-generator new {\n name vlib\n limit 15\n size 128-128\n interface loop0\n node ethernet-input\n data {\n IP6: 00:d0:2d:5e:86:85 -> 00:0d:ea:d0:00:00\n ICMP: db00::1 -> db00::2\n incrementing 30\n }\n\n','context':3,'_vl_msg_id':792)
22:39:49,696 Return value: cli_inband_reply(_0=794, context=3, retval=0, reply='')
22:39:49,696 CLI: }

22:39:49,696 Calling cli_inband('cmd':'}\n\n','context':4,'_vl_msg_id':792)
22:39:49,697 Return value: cli_inband_reply(_0=794, context=4, retval=-1, reply="unknown inpu...
22:39:49,697 }
FAIL reply unknown input `}'

Type: fix

Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: Iaa82d432677d742e766e42383364adda5bd87665

5f9f3c8d 22-Nov-2019 Dave Barach <dave@barachs.net>

vlib: autogenerate <node> before <last-in-arc> constraints

If an arc declaration includes '.last_in_arc = "some-node"', assume
that folks mean it and add explicit ordering constraints.

Fix the "arp" arc declaration which claimed that the arc ends at
arp-disabled, but the arc really ends at error-drop.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ie2de1fb30091671cbc7c62770903a2e05987f141

da47f67b 24-Nov-2019 Ole Troan <ot@cisco.com>

papi: fix papi default handling

Type: fix
Change-Id: I91063e2096fb09c34898a611184c8381fccdb333
Signed-off-by: Ole Troan <ot@cisco.com>

7c8803d4 21-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vppapigen: clean up typos in c generated code

Type: style

Change-Id: Ib8febf8ea83f7ce1aeb93f227d00d3111fbef4ab
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

b307c712 23-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vppapigen: fix i64 format string

Type: fix

Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: I6b42bb9fb9d2e57f523022e321770bb1ff7415f3

1c200dc4 20-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vppapigen: fix typo on f64 endian_string

Type: fix

Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: Id47e3f2c348f07c84d9c2499122fa25d6c74fb13

ba2c7fad 24-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: add missing base types to serializer

File "/vpp/src/vpp-api/python/vpp_papi/vpp_serializer.py", line 512, in __init__
'Unknown message type {}'.format(f_type))
vpp_papi.vpp_serializer.VPPSerializerValueError: Unknown message type i16

Type: fix

Change-Id: Ibf73dc8df90153db586afe614e47be49739bac2f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

14b0b479 24-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: add repr to packer types for troubleshooting

Type: feature

Change-Id: Id3cd89eca0deddb70f506239f9d0543fc28cf7f4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

f9623ca2 21-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Refactor quic rx callback for offload

Type: refactor

Change-Id: I1d90c8807e7eea4a77403bafc0628ec0d393c572
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

b2fce36c 22-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Improve for mq-intensive

Type: feature

* Remove the retry mechanism in case of failed connect
* Limit the number of simultaneous connects (default
to mqsize / 2)

Change-Id: I7a0ed2e349ee3e8ca71639c2a2ec4cdf84f5c13e
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

952a7b8b 19-Nov-2019 Damjan Marion <damarion@cisco.com>

build: add build types helpstring to cmake project

Type: feature

Change-Id: Ia016fee107859d5ad22fe7959c8e9d32758e0787
Signed-off-by: Damjan Marion <damarion@cisco.com>

7bd1fd77 20-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Remove qctx opening pool

Type: fix

We don't need the pool anymore as we store
the ctx index in the underlying UDP session opaque

Change-Id: Iec9be9c84a1f929d94b084176a143d304b0acb83
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

a7f81b75 22-Nov-2019 Fan Zhang <roy.fan.zhang@intel.com>

crypto-ipsecmb: use single GCM API

Type: refactor

Use ipsecmb single GCM enc/dec API to furthuer improve single
buffer performance for small packets.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I2d34ff50d34b09f194fc0c88b6e9a3928a86fc33

9ce35233 18-Nov-2019 Andrew Yourtchenko <ayourtch@gmail.com>

vppinfra: fix coverity issue 205691 in pmalloc

set the address to MMAP_FAILED if mmap has failed,
so that we do not attempt to free it in the error
handling path.

Change-Id: I6e6b51a365fb68086dc20aa40a676a36af59a3ba
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

418ebb71 19-Nov-2019 Ole Troan <ot@cisco.com>

papi: support default for type alias decaying to basetype

Add PAPI support for VppTypeAlias decaying to BaseType.
E.g vl_api_interface_index_t sw_if_index [default=0xffffffff]

Type: feature

Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2061392157c9c11fbb0ff9e5406ea65489b017e9

d35fefe8 04-Nov-2019 Fan Zhang <roy.fan.zhang@intel.com>

crypto-ipsecmb: bump to intel-ipsec-mb version 0.53

This patch bumps the engine's intel-ipsec-mb version from 0.52 to
0.53, to avail performance improvement brought by the library.

Type: feature
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I939803015dece91ca59a7fe2120e2131d29e1c55

8cdb1a0a 18-Nov-2019 Filip Tehlar <ftehlar@cisco.com>

ipsec: fix trailing data overflow

IPsec writes trailing data at the end of the buffer without checking
if there is enough space. If the packet length equals buffer size this
leads to rewiting of the next buffer header in the pool.

Type: fix

Change-Id: Iceb27bb724c7243863a4b532aad0808051b7d74c
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

595d6f8b 20-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: install/remove ipsec tunnels from main thread

Type: fix

Change-Id: I5ad27b05c34494c5a2ea28706130612b547aaf67
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

f4ce6ba2 21-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: add no csum offload config option

Type: feature

Change-Id: I77b3ee74229f3c85e99f74bf9000cb5aedbc1760
Signed-off-by: Florin Coras <fcoras@cisco.com>

ff31ac68 21-Nov-2019 jiangxiaoming <jiangxiaoming@outlook.com>

vcl: if the ldp user send buf with 0 len, it will assert failed.

Type: fix

Change-Id: I8ff60cf8726c463491c687e170ad0b1026a1303a
Signed-off-by: jiangxiaoming <jiangxiaoming@outlook.com>

2c6efec5 21-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

build: Update missing package

CI jobs are being marked as unstable.

18:02:47 ---> python-tools-install.sh
18:02:47 Listing pip packages
18:02:48 DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning.
18:02:48 Generating Requirements File
18:02:48 The virtual environment was not created successfully because ensurepip is not
18:02:48 available. On Debian/Ubuntu systems, you need to install the python3-venv
18:02:48 package using the following command.
18:02:48
18:02:48 apt-get install python3-venv
18:02:48
18:02:48 You may need to use sudo with that command. After installing the python3-venv
18:02:48 package, recreate your virtual environment.

Type: fix

Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Change-Id: Ifb9e8547bce2310f1ce6d9b70f11ceef6f0a8576

11e9e351 14-Nov-2019 Florin Coras <fcoras@cisco.com>

session tcp: support pacer idle timeouts

Type: feature

To avoid excessive bursts, pacer must be provided with an estimated rtt
for the connection. That's used to compute an idle timeout, i.e., time
after which the bucket is reset to 1 mtu due to inactivity. For now,
idle timeout is computed as 5% of the rtt.

Change-Id: Ia0b752fe7b4ad0ce97b477fb886b0133a2321541
Signed-off-by: Florin Coras <fcoras@cisco.com>

d28437cd 20-Nov-2019 Dave Barach <dave@barachs.net>

classify: per-interface rx/tx pcap capture filters

Finish the feature, and fix a couple of doc bugs

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2c62745fda137776204c8fc4fca0e7e288051573

e51a9bbe 19-Nov-2019 Dave Barach <dave@barachs.net>

vlib: improve code coverage, part deux

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If31f4b50da7a6e4a9704ceb3415c582143c08355

a548d134 20-Nov-2019 Neale Ranns <nranns@cisco.com>

ipsec: Honour the renumber argument when selecting show instnace

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: If41f154c354772f5b32cfd35ea231b8f59c2c0c5

0b91bd6c 20-Nov-2019 Benoît Ganne <bganne@cisco.com>

vlib: pci: fix non-NULL terminated C-string

Type: fix

Change-Id: I6f25d9295b973ab7133071b6dc325ecd86386898
Signed-off-by: Benoît Ganne <bganne@cisco.com>

99eefc2c 23-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix memory leak in child SA

traffic selector vector isn't freed when freeing child SA

Type: fix

Change-Id: Icf6c240db5093f45d141451bad6f6627a61821cf
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

fa6b556f 20-Nov-2019 Dave Barach <dave@barachs.net>

misc: fix 4 coverity warnings in srv6-mobile

Type: fix
Ticket: VPP-1771

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I48854befbd3d1514ad8b41ac5b194259c2a577a4

bf85a98f 17-Oct-2019 Chenmin Sun <chenmin.sun@intel.com>

flow: Add GTP support

Type: feature

Adding:
VNET_FLOW_TYPE_IP4_GTPC
VNET_FLOW_TYPE_IP4_GTPU
VNET_FLOW_TYPE_IP4_GTPU_IP4
VNET_FLOW_TYPE_IP4_GTPU_IP6
VNET_FLOW_TYPE_IP6_GTPC
VNET_FLOW_TYPE_IP6_GTPU
VNET_FLOW_TYPE_IP6_GTPU_IP4
VNET_FLOW_TYPE_IP6_GTPU_IP6
in this patch

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I4ad53895b5ac0771432bb039b8c79e48e3c19f25

7c6102b1 08-Nov-2019 Damjan Marion <damarion@cisco.com>

tap: multiqueue support

Type: feature

Change-Id: I7dcc8c6911d02729b3bda1b3a21a211c82c3b949
Signed-off-by: Damjan Marion <damarion@cisco.com>

0b6c9c48 20-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Increase logging

Type: fix

Change-Id: I689649ad163e76fecdabe96a8c2be5be3068ffde
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

8f011830 20-Nov-2019 Benoît Ganne <bganne@cisco.com>

virtio: fix use-after-free

Type: fix

Change-Id: Ic67d9da65d937f56ecf994a5504c6351624b32ff
Signed-off-by: Benoît Ganne <bganne@cisco.com>

d9035a40 20-Nov-2019 Florin Coras <fcoras@cisco.com>

session tcp: add opaque data to show cli

Type: feature

Change-Id: Iac8d4ed4997c4fce802589585e6a9424957152ca
Signed-off-by: Florin Coras <fcoras@cisco.com>

535fdba5 19-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

bash: vpp-make-test bash function

- A bash function which enhances reproduction,
debugging, and verification of intermittent
make test failures.

Type: test

Change-Id: I2faf56829d0633963506e136a68b77b8a1b32236
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

3bbbf0db 20-Nov-2019 Florin Coras <fcoras@cisco.com>

session: fix transport proto unformat

Type: fix

Change-Id: I38a5cbd53b278c21142bac4ee1bbe5dc8bcaaac9
Signed-off-by: Florin Coras <fcoras@cisco.com>

331c428a 19-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

quic: handle duplicate packet from quicly

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ia4b1eb3c704374e27b260d88ae6ab628754468d3

989bc47d 19-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: Fix out of order mq

Type: fix

Change-Id: I522db62db50fc0fa46a6dd7cddd32e2f09b5e5a6
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

9df54b77 19-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

srv6-mobile: fix yamllint failure in FEATURE.yaml

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ia28cf193f7fed2a1702774f3f74f505cc7bad954

ab9b9a5c 19-Nov-2019 Benoît Ganne <bganne@cisco.com>

dpdk: fix non-NULL terminated string

Type: fix

Change-Id: Ic221cd4fcad89aece71239ed96152bf0311f3286
Signed-off-by: Benoît Ganne <bganne@cisco.com>

91f90d08 24-Oct-2019 Florin Coras <fcoras@cisco.com>

session: more show cli output

Type: feature

Change-Id: I7f64fb1a13d90fa1679ca2ca35206092682f0c8f
Signed-off-by: Florin Coras <fcoras@cisco.com>

1b81e6ef 06-Nov-2019 Tetsuya Murakami <tetsuya.mrk@gmail.com>

srv6-mobile

Type: feature

Plug-in for IPv6 Segment Routing Mobile

This funcion was developed by

Signed-off-by: Satoru Matsuchima <satoru.matsushima@gmail.com>
Signed-off-by: Filip Varga <filipvarga89@gmail.com>
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>

Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>
Change-Id: Ie995adc73d8f8d444339aab71619c3599e69f12d
Signed-off-by: Tetsuya Murakami <tetsuya.mrk@gmail.com>

360b523b 18-Nov-2019 Andrew Yourtchenko <ayourtch@gmail.com>

map: fix coverity issue 205684

ip4_map_get_domain returns d0 = 0 in case of no domain,
and sets error MAP_ERROR_NO_DOMAIN. Rearrange the clauses
in the logical check that relies on dereferencing d0
such that boolean shortcutting takes care of not
referencing the null pointer.

Change-Id: I378adc120836ea920fc530808ac3c1f98ab8d593
Type: fix
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

9a6dc8a9 09-Sep-2019 Filip Varga <fivarga@cisco.com>

nat: respect arc features (multi worker)

Type: fix
Ticket: VPP-1747

Change-Id: If282aae3e584d7017c200f897b99c8a37eb1b2e5
Signed-off-by: Filip Varga <fivarga@cisco.com>

b15ad951 14-Nov-2019 Jon Loeliger <jdl@netgate.com>

map: Fix TCP MSS clamping for MAP-E traffic.

Original MSS clamp patch by Vladimir Ratnikov.
Modified to apply only to TCP packets.

Type: fix
Test: Wrote new unit test to ensure MAP-E TCP MSS clamping.
Change-Id: I77c69714a2e3cc3b7473aa12b645243bb595c2a2
Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Signed-off-by: Jon Loeliger <jdl@netgate.com>

93e060ae 18-Nov-2019 Srikanth Akula <srakula@cisco.com>

session: Increasing the Header lengthe size

Type: feature

For some deployments(mobile traffic) we need few extra bytes of space

Signed-off-by: Srikanth Akula <srakula@cisco.com>
Change-Id: I3367561dc23dbb8b266dea583e23b9430fd7dcab

e140d5d0 18-Nov-2019 Srikanth Akula <srakula@cisco.com>

session: extra checks in session validation

Type: fix

Adding few extra checks while doign session validationwq!

Signed-off-by: Srikanth Akula <srakula@cisco.com>
Signed-off-by: Florin Coras <fcoras@cisco.com>
Change-Id: I4d18b5ad97d1802ce38a07aeb56b5f35939c1187

c17fc447 18-Nov-2019 Dave Barach <dave@barachs.net>

vlib: improve code coverage in src/vlib

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I2dc4c09730f77931a2b484a6dd5dc669068f8e57

920180e5 14-Nov-2019 Dave Barach <dave@barachs.net>

api: configurable binary api client rx pthread fcn

Add vl_client_connect_to_vlib_thread_fn (...) and export the
memory_client_main_t definition.

If you use this new API, make sure not to miss the setjmp / longjmp
dance shown in .../src/vlibmemory/memory_client.c:rx_thread_fn(...),
which is required for the rx pthread to terminate cleanly; please
process client delete reply messages in the rx thread...

Type: refactor

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ia67038ec59e2e14b174c67afca15b2c3f67a4d20

d14fccd6 15-Nov-2019 Neale Ranns <nranns@cisco.com>

ipsec: Coverity warnings

Type: fix

Signed-off-by: Neale Ranns <nranns@cisco.com>
Change-Id: I6bb6c6be62f98ac9a059469c81a5f4476b96e96e

210c7453 17-Nov-2019 Dave Barach <dave@barachs.net>

nsim: add FEATURE.yaml

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I75d1efc503135bdc224f563b4e02b449904bfa08

845f51ff 31-Oct-2019 Alexander Chernavin <achernavin@netgate.com>

bfd: allow IPv6 link-local address as local address

Type: fix

Change-Id: Ia3dacd2628591f7ba9710e8e4d68df97ae21935c
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>

52be6743 15-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: close session on retransmit failure

Type: fix

Since the connection is closed, also mark the session as closed.

Change-Id: Ica3849c3ff12fa7a65ba64e563a60d6c94f5ceca
Signed-off-by: Florin Coras <fcoras@cisco.com>

504d023d 15-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

quic: replace quicly patch with upstreamed fix

- Replace the solution to the quicly time skew assert
with h2o/quicly PR#222 which was merged upstream
after verification that it resolved the vpp issue.

Type: refactor

Change-Id: I26df08e4108b054a28f50c964ddff1c80a592339
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

47e09273 15-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

build: fix docs/doxygen targets

- Add missing dependencies
- Fix clean/wipe to remove generated files
- Fix doxygen src variable

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: If6b2797e8af3f2e735759fab5841a0b4576ed7cc

e7906906 14-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

build: make checkstyle-* targets and cleanup

- Add new make targets:
checkstyle-commit
checkstyle-test (alias test-checkstyle)
checkstyle-all
test-wipe-papi (papi-wipe deprecated)
retest-all
retest-all-debug
install-deps (alias install-dep)
install-ext-dep (alias install-ext-deps)
- Fix .PHONY dependencies
- Cleanup redundant target commands

Type: refactor

Change-Id: I08b0ef459d421a09fb929aee5cd6baec329931b7
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

1976f36b 06-Nov-2019 Neale Ranns <nranns@cisco.com>

tests: Add UT to test incomplete MPLS adjacencies send ARP requests

Type: test

Change-Id: I81e07233aec54c786e4e9beb8c4f06d0a3dca90f
Signed-off-by: Neale Ranns <nranns@cisco.com>

efd7bc2b 11-Nov-2019 Neale Ranns <nranns@cisco.com>

tests: Remove the unrequired VPP IP address/prefix class wrappers

Type: refactor

Change-Id: I204f3f8eebc5f5d5a377e91262f91c615fd00168
Signed-off-by: Neale Ranns <nranns@cisco.com>

5ae7f0db 11-Nov-2019 Aleksander Djuric <aleksander.djuric@gmail.com>

ikev2: add definitions for libssl

Type: fix

Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>
Change-Id: I2fe36e2e4e8ce2906a6573301c7fca3cbab571c3

50c99b4a 11-Nov-2019 Aleksander Djuric <aleksander.djuric@gmail.com>

ikev2: correct byte order in api handlers

Type: fix

Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>
Change-Id: I186286b8959ae138528a5171c22d3e1b00f46baf
Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>

c3731ac8 12-Nov-2019 Andy Gospodarek <gospo@broadcom.com>

dpdk: Enable bnxt PMD

This adds support to compile the bnxt PMD that supports Broadcom's
10/25/40/50/100/200 Gbps NICs. Tested with modified DPDK driver on
x86_64 and aarch64 targets that is pending upstream acceptance, but
should compile just fine today.

Type: feature

Signed-off-by: Andy Gospodarek <gospo@broadcom.com>
Change-Id: I735a991c4cae4fa77e5605094facea54b781a1db

f41244f4 08-Nov-2019 Damjan Marion <damarion@cisco.com>

virtio: refactor virtio-pci logging

Type: refactor

Change-Id: I34306c1206b2bf5f521be6c6b78074ccf9259a08
Signed-off-by: Damjan Marion <damarion@cisco.com>

aa27dcb8 06-Nov-2019 Alexander Chernavin <achernavin@netgate.com>

interface: send proper link/admin status in event

Type: fix

Change-Id: I7cba9f911abe1ae82d8381a48f65e81b615ede76
Signed-off-by: Alexander Chernavin <achernavin@netgate.com>

320dfcf2 06-Nov-2019 Neale Ranns <nranns@cisco.com>

fib: Copy the prefix before use in case the underlying entry reallocs.

Type: fix

all other uses of the fib_entry_get_preifx in the code base don't pass
the prefix into recursive functions.

Change-Id: Ic1c56acd406a733b215ee2fd98b6bed58b490a4f
Signed-off-by: Neale Ranns <nranns@cisco.com>

e16707b5 13-Nov-2019 Carl Smith <carl.smith@alliedtelesis.co.nz>

vcl: Handle newer Glibc (>2.28) where fcntl is actually fcntl64

Glibc 2.28 now provides fcntl64 which is used instead of fcntl
by defining fcntl as fcntl64 in fcntl.h

Type: fix

Change-Id: I87fedfbf3e0d241aafdc920e90f824d71353e0e6
Signed-off-by: Carl Smith <carl.smith@alliedtelesis.co.nz>

211b9f6a 13-Nov-2019 Dave Barach <dave@barachs.net>

dhcp: option 61 add missing type field

Apparently some dhcp servers care about it. Also fixed the unit-test.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If0af70d624f4122b0339f20f84be047053776fe8

d9ca7c96 12-Nov-2019 Dave Barach <dave@barachs.net>

vlib: improve vlib "make test" code coverage

Type: test

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Idf982fddad9e577595d2e05ac78c39705e9d616d

ed32c639 13-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

build: Revert "build: fix make checkstyle"

This reverts commit 069e2a734cf75f4d151efe49d1efc51bc82cedb2.

Reason for revert: The vpp-verify-checkstyle-master build executor now
runs 'make install-dep'

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I2ab6bee642b7ed631d2aa06203c76c3d0ca01c9e

318fbfe8 25-Oct-2019 Benoît Ganne <bganne@cisco.com>

gtpu: check packet has enough data for gtpu header

Type: fix

Change-Id: I604e4dd2b29962bfcd8e950a0074637dab53c79e
Signed-off-by: Benoît Ganne <bganne@cisco.com>

06c194d9 13-Nov-2019 Damjan Marion <damarion@cisco.com>

virtio: feature arc have higher priority than redirect

Type: fix
Fixes: 8389fb9

Change-Id: Ie159eb444b28b36a7af86049b80fba4e49be93cb
Signed-off-by: Damjan Marion <damarion@cisco.com>

6545df79 06-Nov-2019 Benoît Ganne <bganne@cisco.com>

crypto: do not crash if no crypto engine loaded

Do not overflow ops_handlers vector.

Type: fix

Change-Id: I8d5e7fb8125a7bd87ecfe6f4f1390fb9f43dad8f
Signed-off-by: Benoît Ganne <bganne@cisco.com>

069e2a73 13-Nov-2019 Florin Coras <fcoras@cisco.com>

build: fix make checkstyle

Type: fix

Comment out yamllint for now.

Change-Id: Id40a5aef3fa15b2c6e9d7fe6fd6201923593b4cd
Signed-off-by: Florin Coras <fcoras@cisco.com>

6af62565 12-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

papi: enhance MACAddress() equality

Allows for comparison without needing str(MACAddress())

Traceback (most recent call last):
File "/vpp/test/test_ip6.py", line 1074, in test_icmpv6_echo
self.assertEqual(ether.dst, self.pg0.remote_mac)
AssertionError: '02:01:00:00:ff:02' != MACAddress(02:01:00:00:ff:02)

Type: feature

Change-Id: Ife1cbfc74d477695d15b33a19da7dd2fa241a348
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

44d06916 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tap: Move client registration check to top

Type: fix

Change-Id: I33dc4cf7b6c69f74c7bf4971ce59442678b878ef
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

867b9ec6 11-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: update logging configuration section.

Type: docs

Change-Id: I6359623b2eadb404fc391e4c4608fff86020f53f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

adb71a74 12-Nov-2019 Damjan Marion <damarion@cisco.com>

virtio: remove unused code

Type: refactor

Change-Id: I25f1cc3969c6a6ec1384079dc437537acd2ec152
Signed-off-by: Damjan Marion <damarion@cisco.com>

9485d99b 08-Nov-2019 Jon Loeliger <jdl@netgate.com>

interface: Allow VLAN tag-rewrite on non-sub-interfaces too.

This fix was first made in
commit fdea5c6a00b74971dbb1b7ec4e25839a871006ca
but was subsequently lost in
commit 053204ab039d34a990ff0e14c32ce3b294fcce0e

Added unit test for setting VTR on a non-sub-interface to
help ensure no future regressions of this ability.

Type: fix
Change-Id: I71ce2684fb72383741455829ae2d397ea2e95eae
Signed-off-by: Jon Loeliger <jdl@netgate.com>

592a909a 12-Nov-2019 Carl Smith <carl.smith@alliedtelesis.co.nz>

vcl: fix nonblocking accept with >1 event in the queue

We discard unwanted events until we get an ACCEPTED.
But if we are non-blocking we need to check the queue
length every time and EAGAIN if empty before waiting.

Type: fix

Signed-off-by: Carl Smith <carl.smith@alliedtelesis.co.nz>
Change-Id: Ie0c7e5cb00f0d37d2e1534f8bb384221ff56f2e3

ea93e48c 12-Nov-2019 Neale Ranns <nranns@cisco.com>

ip: IP address and prefix types (moved from LISP)

Type: refactor

Change-Id: I2c6b59013bfd21136a2955442c779685f951932b
Signed-off-by: Neale Ranns <nranns@cisco.com>

c046d709 14-Oct-2019 Ole Troan <ot@cisco.com>

papi: add wrapper to validate crc manifest

If a client application is built against 19.08, it can dump the "manifest" of API signatures.
Either the all APIs (--dump) or the APIs it is interested in (--dumpfiltered).

When the developers of said client application wants to verify that it works with VPP 20.01.
It can connect to VPP and --validate the old mainfest file, and will be told a list of
messages (both request and reply) that has changed.

import argparse
from vpp_papi import VPP
import sys
import argparse

parser = argparse.ArgumentParser()
group = parser.add_mutually_exclusive_group()
group.add_argument("--dump", action="store_true")
group.add_argument("--dumpfiltered", action="store_true")
group.add_argument("--validate", action="store_true")
args = parser.parse_args()

vpp = VPP(use_socket=True)

vpp.connect(name='apimanifest')

if args.validate:
# Verify manifest
message_table = eval(sys.stdin.read())
missing = vpp.validate_message_table(message_table)
print ('Changed message signatures: {}'.format(missing))
elif args.dump:
# Output manifest to stdout
print('{}'.format(vpp.dump_message_table()))
elif args.dumpfiltered:
# Output manifest to stdout
filterlist = eval(sys.stdin.read())
print('{}'.format(vpp.dump_message_table_filtered(filterlist)))

vpp.disconnect()

Type: feature
Change-Id: I7e708b36f599ed88e4864970c8593cc2fe5fbf61
Signed-off-by: Ole Troan <ot@cisco.com>

31bd0356 07-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: session enable in multiworker

Having session enable in config file wasn't
working for multiple workers

Type: fix

Change-Id: Ib29ba540a6e1d714e7e470f4c7518e3d266fe7ca
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

55a9dacb 11-Nov-2019 Florin Coras <fcoras@cisco.com>

tls: fix picotls coverity warnings

Type: fix

Change-Id: Ib5c9de9c9053b8339f514ff648a75c3b56b55215
Signed-off-by: Florin Coras <fcoras@cisco.com>

a03c7d5b 06-Nov-2019 Benoît Ganne <bganne@cisco.com>

bonding: fix non-null terminated vector

Type: fix

Change-Id: Iea7d73a304236b525b95bdad3bfdb41e711f8cdb
Signed-off-by: Benoît Ganne <bganne@cisco.com>

b15d796d 27-Sep-2019 Lijian Zhang <Lijian.Zhang@arm.com>

crypto: not use vec api with opt_data[VNET_CRYPTO_N_OP_IDS]

opt_data is defined as a array, while in some code, e.g., function
vnet_crypto_get_op_type, it's used as vec.
vec api is not applicable to static arraies.

src/vnet/crypto/crypto.h:234:70: error: address of array 'cm->opt_data' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
vnet_crypto_op_data_t *od = ({ do { if ((0 > 0) && ! ((id) < ((cm->opt_data) ? (((vec_header_t *) (cm->opt_data) - 1)->len) : 0)))

Type: fix

Change-Id: I0b6754406e4216ca975bc1da4b5d4ce293a9bb45
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>

f8461bfb 08-Nov-2019 Florin Coras <fcoras@cisco.com>

svm: improve fifo segment verbose cli

Type: feature

Also make sure that size for dlmalloc allocated private segments is
accurate.

Change-Id: I6ec81ff99a13dd29b9664d768835a68019f0c96c
Signed-off-by: Florin Coras <fcoras@cisco.com>

320998a8 08-Nov-2019 Dave Barach <dave@barachs.net>

vlib: fix handoff queue sequencing bug

Set vm->check_frame_queues after actually enqueuing a frame. Under
obscure circumstances, the code managed to set check_frame_queues so
far in advance that 100 dispatch cycles could elapse before the frame
enqueue succeeded. That resulted in permanent lack of queue service.

Type: fix
Ticket: VPP-1734
Fixes: 18191

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If2d398202b4ba2b96581d25e8142daef3f74c9e5

b3dce89a 30-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: improve lost rxt heuristic

Type: feature

- retransmit first unacked segment if newer retransmitted packets
are acked
- avoid spurious retransmits if recovery ends with sacked bytes

Change-Id: Ic1b56d22e025822edb7609afb136e47440ea6032
Signed-off-by: Florin Coras <fcoras@cisco.com>

eb284a1f 09-Oct-2019 Ole Troan <ot@cisco.com>

ip: functional interface to ip fragmentation

This provides a functional interface to IP fragmentation.
Allowing external features to fragment. Supports
arbitrary encap size, for e.g. MPLS or inner fragmentation
of tunnels.

This also removed dual loop in MAP that was fundamentally broken.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia89ecec8ee3cbe2416edbe87630fdb714898c2a8
Signed-off-by: Ole Troan <ot@cisco.com>

d318a996 10-Nov-2019 Dave Barach <dave@barachs.net>

dhcp: ipv6 prefix delegation improvements

Autoconfigure router advertisements for delegated prefixes.

Clean up a longstanding issue. If vpp receives a dhcpv6 renew reply,
do NOT reset per-delegated-prefix timers. That prevented vpp from
sending a solicit to renew the delegation on time. That, in turn
caused the RA code to send advertisements with valid_time =
preferred_time = 0. That causes almost any downstream client to throw
away its delegated address.

Miscellaneous changes

o src/vnet/ip/ip6_neighbor.c - always memset elements allocated from pools
to zero. DGMS.
o Remove debug spew from the ipv6 connection-tracker plugin

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I428feccdc47efdc413898600e0d62916928a6eb7

f83194c2 14-Oct-2019 Simon Zhang <yuwei1.zhang@intel.com>

tls: picotls engine basic enabling for TLS

Type: feature

Change-Id: I700d999771d837604dd0571741f4f0bcbec82403
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>

aa43914d 08-Nov-2019 Florin Coras <fcoras@cisco.com>

session: re-set tx fifo event if out of buffers

Type: fix

Change-Id: I7416e827fbc5c63d082273656441c81dd6246d8a
Signed-off-by: Florin Coras <fcoras@cisco.com>

fd4c3fe3 07-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: avoid retransmits post reset

Type: fix

Change-Id: Ib6a8f5ca597389700e5746f089a5cec7eee65ab5
Signed-off-by: Florin Coras <fcoras@cisco.com>

20b962d3 09-Nov-2019 Dave Barach <dave@barachs.net>

dhcp: fix dhcpv6 client and dhcpv6 prefix delegation

Keep trying even if the interface in question is not "admin-up,
link-up." In real life, it's normal for link autonegotiation to take a
good fraction of a second. The driver layer takes care of packets sent
to an interface which can't transmit at the moment.

Renew address leases at the preferred renewal time, not at the
expiration time.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I68ec1c52cc1f4a8aa256185820748b845e92f7c1

3c80c106 07-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

build: Fix typo introduced in src/plugins/mdata/FEATURE.yaml

Type: fix
Fixes: Ide0bb276659119c59bdbbc8b8155e37562a648b8

Change-Id: I4db18508910d5fe5f5df4d902e15cf19b10c0621
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

2baa115d 07-Nov-2019 Damjan Marion <damarion@cisco.com>

build: use cmake build types

Type: make

Change-Id: If822c85d6ff26982516ea1d597ca81aa84773b2b
Signed-off-by: Damjan Marion <damarion@cisco.com>

972d71da 05-Nov-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix next node rx redirect

Type: fix

Change-Id: I694db40c3a0361852d01b84c7a45e32e39e9f4af
Signed-off-by: Benoît Ganne <bganne@cisco.com>

a50892e1 06-Nov-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix name auto-generation on create

When creating rdma interface without specifying a name, we need to
generate one instead of NULL.

Type: fix

Change-Id: If41870691dec47e8e673d48ac4b4ddffd2385a03
Signed-off-by: Benoît Ganne <bganne@cisco.com>

12989b53 26-Sep-2019 Neale Ranns <nranns@cisco.com>

ipsec: remove dedicated IPSec tunnels

APIs for dedicated IPSec tunnels will remain in this release and are
used to programme the IPIP tunnel protect. APIs will be removed in a
future release.

see:
https://wiki.fd.io/view/VPP/IPSec

Type: feature

Change-Id: I0f01f597946fdd15dfa5cae3643104d5a9c83089
Signed-off-by: Neale Ranns <nranns@cisco.com>

f1653e62 06-Nov-2019 Florin Coras <fcoras@cisco.com>

vcl: fix epoll connected events sid

Type: fix

Use sid returned by vcl_session_connected_handler instead of trying to
infer it from vpp session handle.

Change-Id: Ic0fbb90ec2bd851b435fc3f2a34265ac9a8ab29f
Signed-off-by: Florin Coras <fcoras@cisco.com>

39807d02 08-Nov-2019 Damjan Marion <damarion@cisco.com>

tap: add check for vhost-net backend

Type: feature

Change-Id: I402f4c88dee70fbb0b3b61dc4e0a4034d24d8b56
Signed-off-by: Damjan Marion <damarion@cisco.com>

0ba86cb1 08-Nov-2019 Damjan Marion <damarion@cisco.com>

tap: fix cli parser

Type: fix

Change-Id: I38ee9efd23774cce7790565825527cca9ba6f200
Signed-off-by: Damjan Marion <damarion@cisco.com>

07df7915 07-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: fix ip check in lookup validation

Type: fix

Change-Id: Ia18632c8fe22bdcfdf3cb48a4234f8703a7ac1d7
Signed-off-by: Florin Coras <fcoras@cisco.com>

4f599850 08-Nov-2019 Vratko Polak <vrpolak@cisco.com>

session: add space around ternary operator

Type: style

Change-Id: If28a4959c1d60ab1caf22dbc8b72d9adf7060bd4
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

770a0dea 07-Nov-2019 Ole Troan <ot@cisco.com>

tests: python3 use byte strings in raw()

Raw('\xaf) and Raw(b'\xaf) are two quite different things in python 2 versus 3.
In most cases this didn't make a difference, apart from those cases where length
of payload actually mattered.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3cba5c1486e436a3ca8aa10a7b393da75aa9f6b9

76a36e83 04-Nov-2019 Fan Zhang <roy.fan.zhang@intel.com>

crypto-ipsecmb: improve gcm performance using dedicated API.

This patch improves the GCM encrypt and decrypt performance using
the dedicated API provided by intel-ipsec-mb library. This helps
remove the overhead caused by the JOB API.

Type: feature
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: I00c9ab3ed9f2660093fb2584feb8bca4979acee8

801c7016 30-Oct-2019 Damjan Marion <damarion@cisco.com>

pmalloc: always lock pages

Type: feature

Change-Id: I5bbf37969c9c51e40a013d1fc3ab966838eeb80d
Signed-off-by: Damjan Marion <damarion@cisco.com>

86a9441c 26-Oct-2018 Paul Vinciguerra <pvinci@vinciconsulting.com>

build: Fix 3rd party CI systems.

Commit https://gerrit.fd.io/r/#/c/15525/ breaks 3rd party CI jobs.

This suggests an alternative solution that supports both use cases.

Type: feature
Change-Id: I966210cf4594651735e6a8bffa32dd52b4539a13
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

d58419f1 03-Nov-2019 Christian Hopps <chopps@labn.net>

dpdk: ipsec gcm fixes

- Fix AAD initialization. With use-esn the aad data consists of the SPI
and the 64-bit sequence number in big-endian order. Fix the u32 swapped
code.

- Remove salt-reinitialization. The GCM code seems inspired by the GCM
RFCs recommendations on IKE keydata and how to produce a salt
value (create an extra 4 octets of keying material). This is not IKE
code though and the SA already holds the configured salt value which
this code is blowing away. Use the configured value instead.

Type: fix

Change-Id: I5e75518aa7c1d91037bb24b2a40fe4fc90bdfdb0
Signed-off-by: Christian Hopps <chopps@labn.net>

bc2e640d 04-Nov-2019 Fan Zhang <roy.fan.zhang@intel.com>

crypto: fix crypto perf unittest crash

Type: fix

crypto perf test crashes for key size different than 16 bytes.
This patch fixes the issue

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Change-Id: Ic8a8ca83ca189c879815dc5d065b8c6f7826cd41

bf1f8b7f 04-Nov-2019 Florin Coras <fcoras@cisco.com>

tcp: fix retransmit with no sacks

Type: fix

Change-Id: I6f7df0d358f57f7feadb9b7a3fcffb99558b2af8
Signed-off-by: Florin Coras <fcoras@cisco.com>

5ed3fe3d 07-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

api: fix dead client scan heap issue

Type: fix

On multiworker setup when an app client dies, the
vec_reset_length call fails the assert in
clib_mem_is_heap_object. Same thing might happen for
the clib_warnings

Change-Id: I369f9d2dbe60407c84994a4e8d25f6df7848ca93
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

de6caf48 09-Oct-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: Add crypto context

Type: feature

Crypto contexts are a per protocol cache for storing
crypto related connection data. They share a common
interface with generic properties : cert, key, engine
and session refcount.

Change-Id: I8165e05afbcc6ecb3777b6abeab62c369d2fe9ed
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

7c40a383 06-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: Add ckpair & crypto engine in vpp_echo

Type: feature

* vpp echo adds and dels a cert and key pair for each run
* it passes the crypto engine to be used (openssl, picotls, vpp, mbedtls)

Change-Id: Iaba1de2e6abb510e6c4edbe84b2324b2f4843f26
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

dcbbf283 06-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Add support for ckpair & crypto engine

quic choice used ckpair is now the one passed to
connect or listen via mq.
The crypto engine is chosen with the value passed to
connect or listen via mq:
* If NONE(0) is provided, we default to quic_main.
default_crypto_engine (picotls at init, can be changed
via debug cli : quic set crypto api [crypto engine])
* If PICTOLS/VPP is provided, use this one
* Other values return an error

Type: feature

Change-Id: Ifab893d6d03c83f202e6c7e7a9936f546a4b1530
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

45ec9f49 06-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: ckpair store & crypto engine as mq params

Type: feature

This patch adds the logic to pass to connect &
listen msg in the mq the following parameters
* ckpair index
* crypto engine (for now only used in quic)

Change-Id: I7213d8b581cb4532a9a6b18c4b3fe021287b7733
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

9d3e1b43 07-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: fix app attach on error

Type: fix

Change-Id: I57b3c76515544ba3655690b37e0dacb47734ba6d
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

c9dff181 07-Nov-2019 Florin Coras <fcoras@cisco.com>

svm: fix byte accounting when allocating fifo header

Type: fix

Change-Id: Ie50625271d257da814445ce13c2e6cd98986d523
Signed-off-by: Florin Coras <fcoras@cisco.com>

c12eae73 31-Oct-2019 Aleksander Djuric <aleksander.djuric@gmail.com>

interface: shmemioerror while getting name_filter arg

Type: fix

Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>
Change-Id: I5e0eb7024d208040d79e9d6db863f41e2ecf4ee6
Signed-off-by: Ole Troan <ot@cisco.com>

3f8c8713 05-Nov-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: make threads in punt tests join when finished

The 42693521f6046997133c8f63bcfc9d615d96f69d added the timeout
to the child process join + print the name of the offending
child process.

Upon testing the issue furher, appeared the offenders were
always the same - punt tests. The processes running them
were stuck trying to acquire lock, even if all
the user-accessible execution has finished. Some searching
revealed that one needs to tread carefully when dealing
with Thread and Multiprocessing at the same time.

punt tests used threads but did not call thread.join. Somehow
it worked in some cases but not the others. This fix makes
the threads exit cleanly - which also makes the timeouts
waiting for the process to join disappear.

Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I05d99bb48a9987544bbfe45118755c09d7867aa0
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

cf4c2102 07-Nov-2019 Srikanth Akula <srakula@cisco.com>

tcp: validate the IP address while checking TCP connection

Type: feature

Along with the port information, we need to validate the IP address details as well.
This is very useful in the case port re-use scenario

Signed-off-by: Srikanth Akula <srakula@cisco.com>
Change-Id: I11e1ebcd3e56aae47ac235a89606a83c928aa6bb

8d74caa0 06-Nov-2019 Dave Barach <dave@barachs.net>

misc: add lcov scripts, README.md

See extras/lcov

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id229436bd94cd18bcd0f3a3d938eae2b28d5b1f5

c96d618a 06-Nov-2019 John DeNisco <jdenisco@cisco.com>

docs: Rewrite the what is VPP (first) section, also fix the build

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ifb558171f8976a721703e74afea997d006273b5f
Signed-off-by: Dave Barach <dave@barachs.net>

340c15c6 05-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: add spellcheck to 'make docs' sphinx docs

The CI gate will fail if there are typos in the docs.

writing output... [ 21%] events/Summits/OpensourceSummit...
writing output... [ 22%] events/Summits/UKNO/2017_04_30_...

featuresbyrelease/vpp16.06.rst:34:Rasberry:vpp16.06
writing output... [100%] usecases/vppinazure
Spelling checker messages written to /vpp/docs/_build/html/output.txt

Warning, treated as error:
Found 1 misspelled words
Makefile:31: recipe for target 'html' failed
make[1]: *** [html] Error 2
make[1]: Leaving directory '/vpp/docs'

If you introduce a term that is not recognized,
please add it to custom dictionary at
docs/spelling_wordlist.txt.

Type: feature

Change-Id: Id49be4fbee617f544f1ab8e78e7de8a4df36448b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

4d11b6ce 06-Nov-2019 Damjan Marion <damarion@cisco.com>

dpdk: conditionally revert rte_vfio_dma_map patch

DPDK have bug which will be fixed in 19.11.

Type: fix
Change-Id: I6c0058928e5991d61b3c5fcba706f35e6886b0f2
Signed-off-by: Damjan Marion <damarion@cisco.com>

6b0dd550 03-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

build: add yaml file linting to make checkstyle

Type: feature

fts and trex rely on yaml config files. Verify
that they are valid, so comitters can catch
errors early.

Change-Id: Ide0bb276659119c59bdbbc8b8155e37562a648b8
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

7f39e91f 05-Nov-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: free qctx after udp cleanup

Type: fix

As udp_session.opaque is qctx index, qctx free
needs to happen after session cleanup. This patch
also introduces
* assert timer stop on ctx free
* debug cli for listing quic ctx

Change-Id: I3a58d226b094a0bbdf090b4f3eccbc2e11c6329b
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

2089c69e 05-Nov-2019 Tarun Gupta <tarungup@cisco.com>

tcp: IPv6 flow label support

Type:feature

For cases when proxy is in use IPv6 flow label received in origin pkt needs to be added
to ipv6 header of outgoing pkts from proxy to original destination and vice versa.

Signed-off-by: Tarun Gupta <tarungup@cisco.com>
Change-Id: I143f7e67237c0f865333078628a016b50ad5e630
Signed-off-by: Tarun Gupta <tarungup@cisco.com>

ead1e536 31-Oct-2019 Renato Botelho do Couto <renato@netgate.com>

misc: Fix python scripts shebang line

Type: fix

Since CentOS 8, RPM build script doesn't accept '#!/usr/bin/env python'
as a valid shebang line. It requires scripts to explicitly chose
between python2 or python3.

Change all to use python3 as suggested by Paul Vinciguerra.

Depends-On: https://gerrit.fd.io/r/23170

Signed-off-by: Renato Botelho do Couto <renato@netgate.com>
Change-Id: Ie72af9f60fd0609e07f05b70f8d96e738b2754d1


extras/vpp_config/scripts/dpdk-devbind.py
extras/vpp_config/vpp_config.py
src/plugins/abf/test/test_abf.py
src/plugins/acl/test/test_acl_plugin.py
src/plugins/acl/test/test_acl_plugin_conns.py
src/plugins/acl/test/test_acl_plugin_l2l3.py
src/plugins/acl/test/test_acl_plugin_macip.py
src/plugins/acl/test/test_classify_l2_acl.py
src/plugins/cdp/test/test_cdp.py
src/plugins/dhcp/test/test_dhcp.py
src/plugins/dns/test/test_dns.py
src/plugins/flowprobe/test/test_flowprobe.py
src/plugins/gbp/test/test_gbp.py
src/plugins/gtpu/test/test_gtpu.py
src/plugins/igmp/test/test_igmp.py
src/plugins/l3xc/test/test_l3xc.py
src/plugins/mactime/test/test_mactime.py
src/plugins/map/examples/test_map.py
src/plugins/map/gen-rules.py
src/plugins/map/test/test_map.py
src/plugins/nat/extras/nat_static_gen_cfg.py
src/plugins/nat/test/test_ipsec_nat.py
src/plugins/nat/test/test_nat.py
src/plugins/pppoe/test/test_pppoe.py
src/plugins/quic/test/test_quic.py
src/plugins/sctp/test/test_sctp.py
src/plugins/srv6-ad/test/test_srv6_ad.py
src/plugins/srv6-am/test/test_srv6.py
src/plugins/srv6-as/test/test_srv6_as.py
src/plugins/svs/test/test_svs.py
src/scripts/host-stack/cc_plots.py
src/scripts/vnet/uri/dummy_app.py
src/vpp-api/python/vpp_papi/macaddress.py
src/vpp-api/python/vpp_papi/tests/test_vpp_serializer.py
src/vpp-api/python/vpp_papi/vpp_papi.py
src/vpp-api/python/vpp_papi/vpp_stats.py
src/vpp/stats/stats.md
test/discover_tests.py
test/framework.py
test/ipfix.py
test/log.py
test/patches/scapy-2.3.3/geneve.patch
test/patches/scapy-2.4/geneve.patch
test/remote_test.py
test/run_tests.py
test/sanity_import_vpp_papi.py
test/sanity_run_vpp.py
test/template_bd.py
test/test_bfd.py
test/test_bier.py
test/test_bihash.py
test/test_bond.py
test/test_buffers.py
test/test_classifier.py
test/test_classifier_ip6.py
test/test_cli.py
test/test_container.py
test/test_crypto.py
test/test_dvr.py
test/test_fib.py
test/test_geneve.py
test/test_gre.py
test/test_gso.py
test/test_interface_crud.py
test/test_ip4.py
test/test_ip4_irb.py
test/test_ip4_vrf_multi_instance.py
test/test_ip6.py
test/test_ip6_vrf_multi_instance.py
test/test_ip_ecmp.py
test/test_ip_mcast.py
test/test_ipip.py
test/test_l2_fib.py
test/test_l2_flood.py
test/test_l2bd.py
test/test_l2bd_arp_term.py
test/test_l2bd_multi_instance.py
test/test_l2tp.py
test/test_l2xc.py
test/test_l2xc_multi_instance.py
test/test_lisp.py
test/test_mpcap.py
test/test_mpls.py
test/test_mtu.py
test/test_neighbor.py
test/test_p2p_ethernet.py
test/test_pipe.py
test/test_punt.py
test/test_qos.py
test/test_reassembly.py
test/test_session.py
test/test_sixrd.py
test/test_span.py
test/test_sparse_vec.py
test/test_srmpls.py
test/test_stats_client.py
test/test_string.py
test/test_syslog.py
test/test_tcp.py
test/test_tls.py
test/test_udp.py
test/test_util.py
test/test_vapi.py
test/test_vcl.py
test/test_vhost.py
test/test_vom.py
test/test_vtr.py
test/test_vxlan.py
test/test_vxlan6.py
test/test_vxlan_gbp.py
test/test_vxlan_gpe.py
test/vpp_udp_encap.py
464e5e0b 01-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: fix 'make doxygen' under python3

The 'make doxygen' component has this cool vpp specific customization called siphon.
This updates the siphon component so that 'make doxygen' works with python3.

Needed-By: https://gerrit.fd.io/r/23159

Type: docs

Change-Id: Ie29f1602bf3460b637058acbb0a2f19b128a8824
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

ea1a6513 01-Nov-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: fix issues with src/scripts/fts.py

- packaging issue
- yaml deprecation
- yaml formatting

Type: fix

Change-Id: Ia8808cbc83271a3067164f2db2418f071b35607a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

5854b43d 05-Nov-2019 Filip Varga <fivarga@cisco.com>

nat: NAT udp counter & unit test fixes

Ticket: VPP-1798
Type: fix

Change-Id: I42f02d5824575720e95b9fc99cfa864252221a82
Signed-off-by: Filip Varga <fivarga@cisco.com>

a8e71c89 23-Oct-2019 Florin Coras <fcoras@cisco.com>

session tcp: refactor pacer time

Type: refactor

Change-Id: Ic1c3e1f7987702cd88972acc34849dc1f585d5fe
Signed-off-by: Florin Coras <fcoras@cisco.com>

0b6a857d 30-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: Fragmentation fixes

Type: fix

if the packet is about to be fragmented, then don't call any of the
actions that expect the rewrite to have been written.
1) don't double count packets thru the adjacency (original & fragments)
2) don't double decrement the TTL for fragments
3) return to ip4-midchain post ip-frag if that's where we started.
4) only run midchain/mcast fixups if not fragmenting (if no errors)

Change-Id: Ib2866787a42713ee5871b87b597d8f74b901044b
Signed-off-by: Neale Ranns <nranns@cisco.com>

3ea17d54 05-Nov-2019 Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>

tcp: correct validity check return value

Type: fix

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: Ib59bf664d8da20516d8f16d716c5e8698675da4b

45a95dd7 05-Nov-2019 Klement Sekera <ksekera@cisco.com>

tests: support setting random seed

Log the random seed used when running tests and provide means to re-use
it in a later run.

Type: feature

Change-Id: I18d2a36ee802b901d4cca5577df41cec07f09cc0
Signed-off-by: Klement Sekera <ksekera@cisco.com>

718a19b8 05-Nov-2019 Jakub Grajciar <jgrajcia@cisco.com>

libmemif: reset number of queues on disconnect

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: If4df47b1109ac90d4d5834b3aa7d326f6b3761d2

16572355 21-Oct-2019 Filip Varga <fivarga@cisco.com>

nat: respect udp checksum

Type: fix

Change-Id: I732be02d2e2b854eb589c3fa10f980ef2dbe8dfc
Signed-off-by: Filip Varga <fivarga@cisco.com>

42693521 05-Nov-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: avoid test runner hanging on child test process join

In parallel test, the single process is spawning
a bunch of child processes running the tests,
and communicates to them. When the child process
signals that it has finished, the parent calls
child.join(). Sometimes this join never returns.
The result is a lot of defunct python processes,
and the test run just hangs.

I have seen this failure intermittently a fair bit
in a busy containerized environment, and by chance,
consistently reproduced it on a Thinkpad X280
with 8G of RAM and Ubuntu 19.04, which allowed
to diagnose it.

Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: If0a3110fc2d23e73d77c310d61c3ea90a2b53610

f7f49640 25-Oct-2019 Benoît Ganne <bganne@cisco.com>

ipsec: ipsec-input: check for too-short packets

Make sure packet is big enough before processing it.
Policy matching is done speculatively but is discarded if packet is too
short.

Type: fix

Change-Id: I647db2c4e568b0d9bf2cfd5056e1b1c2e25132fe
Signed-off-by: Benoît Ganne <bganne@cisco.com>

3a23f9e3 01-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

quic: enhance error reporting

Type: refactor

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I710d00e4a6c4356d0f00f7592bf14b55596ec6ae

caa52f3f 01-Nov-2019 Dave Wallace <dwallacelf@gmail.com>

quic: fix quicly rtt time skew

- This patch to quicly fixes an intermittent failure
in the rtt calculation when there is a time skew

Type: fix

Change-Id: If89c47401ee75c88f0eb65ae888b6914695b2aec
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

34d92ebd 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

quic: remove redundant function calls

- session_transport_delete_notify() is called before
and inside quic_connection_delete()

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I5c79a3269e36c4aab5aa99fdfdac06c1334f0f6f

8f6d7a78 04-Nov-2019 Ole Troan <ot@cisco.com>

nat: revert respect udp checksum

This reverts commit 0d75f783644a24b219ed79d9f9c17387783f67ca.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iaf33301201897e6646eba2b4157e2a45f5fd30f2

cb3cfe87 23-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix traffic selector match

Type: fix

Change-Id: I81ab3dcd03f397b3d275da6cfa094e048ad92f95
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

a519f213 04-Nov-2019 Ole Troan <ot@cisco.com>

nat: revert fix dual-loop tcp checksum botch

This reverts commit 9654a37fac7fe2b425576eb0237b8d24ae44e1b1.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I93ed5a48303421de43f5494c11db2be9a3c8ce57

2e8b0618 03-Nov-2019 Christian Hopps <chopps@labn.net>

vlib: fix for vlib_node_add_next_with_slot

- vlib_node_add_next_with_slot was not cleaning the old next node
references to the given slot when replacing it with new next node. This mostly
worked until one tried to set the slot to a previously (but not currently) used
next node for that slot.

Type: fix

Signed-off-by: Christian Hopps <chopps@labn.net>
Change-Id: I7ee607625da874e320158b80f12ddc16e377f8e9

bf103d99 28-Oct-2019 IJsbrand Wijnands <iwijnand@cisco.com>

mpls: number of mpls tunnel paths returns zero

The number of paths on the mpls tunnel returned through the bapi is
always zero. Doing a ntohl on a uint32 and poking it into a uint8 causes the problem.

Type: fix
Signed-off-by: IJsbrand Wijnands <ice@cisco.com>
Change-Id: I4135ad43a891e7818ca673c8067ef1f11cb34530

9654a37f 03-Nov-2019 Dave Barach <dave@barachs.net>

nat: fix dual-loop tcp checksum botch

Type: fix
Fixes: 22921

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4fecce96d027c0ee1797d9d84cfab94b1ecdc02b

983ebaa3 01-Nov-2019 Dave Barach <dave@barachs.net>

build: install generated api enum and type headers

Otherwise, <api-name>.api_enum.h and <api-name>.api_types.h files are
unavailable. If plugin B needs to send an API message to plugin A,
it's out of luck.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I25fdb904b5cf57727d6196fa2c0c71be68f207ed
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

2d0b2bbb 01-Nov-2019 Florin Coras <fcoras@cisco.com>

session: fix show cli with closed session

Type: fix

Change-Id: Ifb6ead644c0273b84a5647f7923053f1db7c5a76
Signed-off-by: Florin Coras <fcoras@cisco.com>

dd97a48d 02-Nov-2019 Florin Coras <fcoras@cisco.com>

session: reschedule asap when snd space constrained

Type: feature

Improves fairness for sessions that are snd space or pacer constrained.

Change-Id: Ida5f523090f1dcbfb17bf5116bc7917747ac8593
Signed-off-by: Florin Coras <fcoras@cisco.com>

a1f5a956 01-Nov-2019 Dave Barach <dave@barachs.net>

vlib: enhance the "show cli" debug CLI command

Dump the entire CLI, mp-safe commands, non-mp-safe commands, commands
which have been executed. Optionally, clear the hit counters.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ie38fc664b7deaabc35ca35be68db7e159272f551

feda5451 01-Nov-2019 Alexander Kabaev <kan@freebsd.org>

vlib: Handle race in thread barrier processing

When CLIB_DEBUG is enabled, vlib_foreach_main macro asserts that
vlib_main it currently looks at is safely parked in barrier, by
checkling that vlib_main->parked_at_barrier is not 0.
Unfortunately, the check is racy - workers first increment the
atomic counter to indicate that they have reached the barrier
and _then_ set this_main->parked_at_barrier to 1. For the last
worker to suspend this opens the race - main thread is free
to execute and assert immediately after atomic counter has been
incremented, before worker gets to write to own parked_at_barrier.

Fix this by simply swapping the order of two operations.

Type: fix

Signed-off-by: Alexnader Kabaev <kan@FreeBSD.org>
Change-Id: Iae47abd6ca0be1c5413f5ecaefabc64cd7eac2ed

5bec5f78 10-Oct-2019 Chenmin Sun <chenmin.sun@intel.com>

dpdk: fix tso not properly check the 'enable-tcp-udp-checksum' option issue

Type: fix

Fix tso did not properly check the 'enable-tcp-udp-checksum' option issue
Add description of 'tso' and 'enable-tcp-udp-checksum' in startup.conf

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: Id659067a9fa9e1db6c3f8dc533a2e90351b86831

f9d784b6 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

quic: fifo size is u32

- Fix cli / config fifo size to only accept u32
size input.
- Make cli / config fifo-size input type handling
to be the same as vpp hoststack
- Update external transfer tests to use new
syntax with different fifo sizes for
vpp_echo client/server and vpp.

Type: fix

Change-Id: Ia5ddb2b8d3d9908ab502352819eebeec8ac0971d
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

3edd1bbe 31-Oct-2019 Damjan Marion <damarion@cisco.com>

build: bump rdma-core version to 26.0

Type: make
Change-Id: I642cff93c4935d6ba7948f0e38761c64007ae0c2
Signed-off-by: Damjan Marion <damarion@cisco.com>

597354c1 31-Oct-2019 Damjan Marion <damarion@cisco.com>

build: bump nasm version to 2.14.02

Type: make
Change-Id: I9b598ce17c058709553a45524e18a64de642a8db
Signed-off-by: Damjan Marion <damarion@cisco.com>

1f8daefd 31-Oct-2019 Damjan Marion <damarion@cisco.com>

build: remove obsolete dpdk patches

Type: refactor
Change-Id: I2bad8d4e7b9d7868c949856d0bbabeccb6825273
Signed-off-by: Damjan Marion <damarion@cisco.com>

60ad1a59 30-Oct-2019 Benoît Ganne <bganne@cisco.com>

dhcp: fix proxy dhcpv6 size check

Type: fix

Change-Id: Ibbb25bc530fdeaa3083c9b833a286a5d40e93c1e
Signed-off-by: Benoît Ganne <bganne@cisco.com>

4354317b 21-Oct-2019 Benoît Ganne <bganne@cisco.com>

vlib: only dump 1st buffer in chain by default

Several nodes include buffers in their traces, but only the 1st. When
formatting the trace we must not try to iterate through all chained
buffers.
Default to display only the 1st buffer.

Type: fix

Change-Id: Ib3c668bbf4ab70ae68eba2ac402c7b7329825b70
Signed-off-by: Benoît Ganne <bganne@cisco.com>

c520fe7a 29-Oct-2019 Benoît Ganne <bganne@cisco.com>

ipsec: fix esp trace seq number overflow

Do not copy invalid seq number if packet is too small.

Type: fix

Change-Id: I1e78f5920e9645521f57efccaf35bbf9ce0676a8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

09220b8d 31-Oct-2019 Vratko Polak <vrpolak@cisco.com>

misc: Use tabs in MAINTAINERS

Type: style

Change-Id: Idd15c372f43a720e18a973e78ec5ccd00e1ad709
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

ea7d4fe1 31-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

quic: fix wrong error checking

- Revert error checking to previous ASSERT

Type: fix
Fixes: 7c7fa9066

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6d915d88bf932c74f9b866aec3bd1531e0cb47f4

45b7973d 31-Oct-2019 Florin Coras <fcoras@cisco.com>

session: avoid double dispatch of new events

Type: fix

Avoid re-dispatching new events if they've just been added to the old
events linked list.

Change-Id: Ie5d0b799eae6cebb118d97204e5111eb194c0b8e
Signed-off-by: Florin Coras <fcoras@cisco.com>

ba13c3b3 31-Oct-2019 Florin Coras <fcoras@cisco.com>

session: fix dispatch event logging

Type: fix

Change-Id: Icf3c73cd7eb7565ed6e1b0371da172b5408a9d36
Signed-off-by: Florin Coras <fcoras@cisco.com>

b31d3935 31-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: Revert "tests: add sending SIGQUIT to vpp quit sequence"

This reverts commit 4465fe1e30556b40c9ef8a1a155aa1665102dd22.

That commit makes *every* test to send SIGQUIT to VPP when it is done,
thereby triggering the coredump if there was none.

It is most surely not what we want.

Type: test

Change-Id: I3cc4c96f44c05527d586142f8feccc2f93c3e536
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

3ad98473 31-Oct-2019 Florin Coras <fcoras@cisco.com>

quic: disable failing test

Type: fix

Disable test until fixed.

Change-Id: I1f03630d126e61578c63a3536a0dd1a7b4da2b92
Signed-off-by: Florin Coras <fcoras@cisco.com>

b5076cbe 28-Oct-2019 Jieqiang Wang <jieqiang.wang@arm.com>

acl: add missing square brackets to vat_help option in acl api

Add the missing right square brackets to remove ambiguity in
vat_help option for acl_add_replace and macip_acl_add_replace api.

Type: fix

Change-Id: I2679d8ce163d23a0e513afdfdb87434cbb673c74
Signed-off-by: Jieqiang.Wang <Jieqiang.Wang@arm.com>

46ec6e01 22-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: track lost rxt segments in byte tracker

Type: feature

Change-Id: I18dfac9c3d2f539edf20dba64cd2b7b541154144
Signed-off-by: Florin Coras <fcoras@cisco.com>

7c7fa906 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

quic: fix quicly fifo size mismatch

- This fixes an intermittent failure of the
test_quic_ext_transfer test due to quicly
being configured with the wrong fifo size
which was taken from the cli or startup.conf
file. The fifo size from the application
context is now used when creating the
quicly context.
- Emit an error message if the entire chunk
of a stream is not enqueued in the svm fifo.

Type: fix

Change-Id: I03847ea7d4cd7a617b577697dfe3afa969850937
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

35b037fd 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vpp_config: fix typos in templates

Type: style

Change-Id: Ia435604c8c48a78054848095567f1e54d028227e
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

b1010588 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

http_static: fifo-size is u32

- Limit cli input to u32

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ib1f8ee9764da91a7804cc08901112c3f074130bc

c9832e3d 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vlib: fix subclass name being truncated in output

Type: fix

Change-Id: I50816cca4eb88f58209138a348fc5954ab835f5b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

e74718fa 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

dns: fix typo in counter

Type: fix

Change-Id: Id8a0ce8278816d2839d229799daa3735a097bc7b
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

ddbd90aa 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

l2: fix typo in doxygen

Type: style

Change-Id: I286280fffa6ab5d3e15986911a4ccc35efbf41c3
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

4465fe1e 27-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

tests: add sending SIGQUIT to vpp quit sequence

As suggested in the docs by:
https://fd.io/docs/vpp/master/usecases/contiv/core_files#let-vpp-crash

Type: test

Change-Id: I10caf16220e2507351636c1b26e57e19bcf8a542
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

5b755e2f 26-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

ip: cleanup typos in documentation

Type: style

Change-Id: I7d44b7fab1b8b196e4934cb4832ee51084c5bf98
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

b1a81aa6 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tls: fifo size is u32

- unformat_memory_size() writes to a uword *
- Limit cli input to u32

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I453a5633e04f9ee6f2f1a843634f99063a81579b

e3b70df8 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: vpp_echo fifo size is u32

- Fix cli / config fifo size to only accept u32
size input.
- Make cli / config fifo-size input type handling
to be the same as vpp hoststack
- Clean up vpp_echo usage output
- Clean up json close stats labels to make them
less confusing

Type: fix

Change-Id: I3aa2247f75a4ce284be9e7c0adc71ba488bfbf2b
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

db39656d 30-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tcp: rx fifo size is u32

- Limit cli input for rx fifo size to u32

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: If5a8e0668acf5b0f369acf4f120e47a012bd1899

27ccbfde 28-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

misc: MAINTAINERS clean up typos

Type: style

Change-Id: I0241005c1bb009444fdc510fc1a6599cc90d91dd
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

43d8cf6f 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vlib: Trivial - fix typo in short help

Type: fix

Change-Id: Ifada594088984291ce2e79da0bbbbd1f500640c9
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

59c11073 30-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

dpdk: use local logger

Type: fix

Change-Id: I44922f70aef6a3c53f0f56c6d0656502c8fd69b2
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

60013b55 27-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

quic: fix typos

Type: style

Change-Id: Iec3478541997352a627c8869e38cb7be7c3dae6a
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

cbbc4a25 12-Oct-2019 Zeyu Zhang <zeyu.zhang@intel.com>

tls: fix on tcp connection reset

VPP would fail in tcp_connection_reset() if the tls
or app session was just created.

Type: fix

Change-Id: I45d107f57e4f3fc468c15ca3392d5e1c413bd690
Signed-off-by: Zeyu Zhang <zeyu.zhang@intel.com>

0c4def0e 29-Oct-2019 Benoît Ganne <bganne@cisco.com>

lisp: fix lisp-gpe db hash

lgt->key is already a pointer to the key, hash the pointed data instead
of the pointer value.

Type: fix

Change-Id: I4d29d8c6519afc3843cb2e5ef88795d60f715e23
Signed-off-by: Benoît Ganne <bganne@cisco.com>

00217cb1 29-Oct-2019 Aleksander Djuric <aleksander.djuric@gmail.com>

dhcp: allocate memory for dns

Type: fix

Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>
Change-Id: I56375d5d53eb07d80c1b12513798317f60c81a6d
Signed-off-by: Aleksander Djuric <aleksander.djuric@gmail.com>

97c998c2 29-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: devices-- add FEATURES.yaml

Type: docs

Change-Id: I039ba9ad5385452b202366fba0b367506a21ea4f
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

3ae52627 28-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

l2: l2tp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I9015fc60e8d77e5d5ac36bf2862c1fe794addb81
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

40680c66 20-Sep-2019 Vratko Polak <vrpolak@cisco.com>

lb: refactor ntohl in lb_conf handler

Type: refactor

Change-Id: Ibe8f3c1ed5c04d1800fea9b9a90772816aa38d65
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

97ea2f4e 29-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tests: decode worker stdout/stderr output

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I309254e9e99920fbeaa50eea503c1c2a9470abfe

bd52e46f 28-Oct-2019 Florin Coras <fcoras@cisco.com>

vcl: handle rx notifications on reused sessions

Type: fix

Ignore events on sessions that have been reused but not fully
initialized.

Change-Id: Ided020eb5245d665d0a2e4a9e1f8a6dddebae009
Signed-off-by: Florin Coras <fcoras@cisco.com>

67a6dcbc 25-Oct-2019 Damjan Marion <damarion@cisco.com>

dpdk: replace deprecated VFIO API invocation

Type: refactor

Change-Id: I1712729b3f5d4ab659f51a2d3bf798db16b50820
Signed-off-by: Damjan Marion <damarion@cisco.com>

ee743766 27-Sep-2019 jaszha03 <jason.zhang2@arm.com>

ip: refactor ip4_mtrie to use atomic store-release

ip4_mtrie used full memory barrier compare-and-swap in set_leaf () and
set_root_leaf () even though only one thread updates the trie. Replaced
such instances of compare-and-swap with atomic store-release.

Type: refactor

Change-Id: Ic6e3c84480697915541acd16dcc630d1c436137d
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

04c0130f 27-Sep-2019 jaszha03 <jason.zhang2@arm.com>

ip: refactor ip4_mtrie to atomically unset leaves

ip4_mtrie set leaves atomically in set_leaf () and set_root_leaf () but
deleted leaves using regular stores in unset_leaf () and unset_root_leaf ().
Changed leaf deletion to update mtrie using atomic store-release.

Slight performance improvement was observed in benchmarking on Qualcomm
and Xeon machines. Benchmarking involved running 'ip route add' and
'ip route del' on vpp instances. Below are the routes/second for adding
and deleting 100k routes before and after the store-release changes:

Xeon Add Routes Before: 1.140e6, 1.139e6, 1.148e6, 1.158e6, 1.155e6
Xeon Add Routes After: 1.167e6, 1.170e6, 1.174e6, 1.173e6, 1.169e6
Xeon Del Routes Before: 7.287e7, 8.089e7, 6.048e7, 7.171e7, 7.821e7
Xeon Del Routes After: 8.729e7, 7.353e7, 7.856e7, 8.209e7, 7.787e7
Qualcomm Add Routes Before: 3.709e5, 3.954e5, 3.739e5, 3.759e5, 3.671e5
Qualcomm Add Routes After: 3.879e5, 3.967e5, 3.936e5, 3.764e5, 3.817e5
Qualcomm Del Routes Before: 1.286e7, 1.379e7, 1.353e7, 1.230e7, 1.331e7
Qualcomm Del Routes After: 1.411e7, 1.355e7, 1.373e7, 1.394e7, 1.314e7

Type: refactor

Change-Id: If3acd25a2fb87addd0eb13d82d3c8f46579e8060
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

73f725c6 29-Oct-2019 John DeNisco <jdenisco@cisco.com>

docs: Fix warning with sphinx build, add script to publish docs

Signed-off-by: John DeNisco <jdenisco@cisco.com>
Change-Id: Ic17585bcb4196e5b0661104745f67d6a02ab6b3d

d743dffc 29-Oct-2019 Klement Sekera <ksekera@cisco.com>

tests: fix TEST= filtering for python3

Type: fix

Change-Id: Iceb60e8a507120434cfc68758476ff5351b05f58
Signed-off-by: Klement Sekera <ksekera@cisco.com>

669f4e34 28-Oct-2019 Neale Ranns <nranns@cisco.com>

ethernet: VNET API to create sub-interfaces

Type: refactor

Change-Id: I37899a9c1c2b0790bee90b84aec6b51cdd5236b4
Signed-off-by: Neale Ranns <nranns@cisco.com>

b7c23058 29-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

misc: 19.04.3 Release Notes

Type: docs

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I43a236be5289c50dafbede08beabe4c09ff3c892

c8be8511 28-Oct-2019 Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>

tcp: correct tcp connection lookup condition

Type: fix

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: Ibdbac568d5f765e6b5c959cab5e32dc33335064d

5afea129 28-Oct-2019 Florin Coras <fcoras@cisco.com>

session: allow transport cleanup only if not deleted

Type: fix

Change-Id: I51282182952a66be698226bace39626df4d67b9f
Signed-off-by: Florin Coras <fcoras@cisco.com>

1afe9527 25-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: Punt rather than drop unkown IPv6 ICMP packets

Type: feature

Change-Id: Ib137c453ff2dd5b9d028c653afa80e6b2b81b9e0
Signed-off-by: Neale Ranns <nranns@cisco.com>

f6c8f509 25-Oct-2019 Neale Ranns <nranns@cisco.com>

ping: move the echo responder into the ping plugin

Type: feature

Change-Id: I246346b82858e73b16d727e2106350bc0fc3c6f2
Signed-off-by: Neale Ranns <nranns@cisco.com>

b6e8b1a7 12-Mar-2019 Damjan Marion <damarion@cisco.com>

vlib: don't use vector for keeping buffer indices in the pool

Type: refactor

Change-Id: I72221b97d7e0bf5c93e20bbda4473ca67bfcdeb4
Signed-off-by: Damjan Marion <damarion@cisco.com>

38f7ccbc 28-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly fix sanity checks

use correct value for sanity checks

Type: fix

Change-Id: If33db5ce3e4a26f7876c2a67832ca2947563e211
Signed-off-by: Klement Sekera <ksekera@cisco.com>

7fa3dd28 27-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

docs: cleanup typos on readthrough

Type: style

Change-Id: I3b15035ea6c13cd1ca3cdc9dfa9b10a6e1be9880
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>


docs/featuresbyrelease/vpp1908.md
docs/gettingstarted/developers/bihash.md
docs/gettingstarted/developers/binary_api_support.rst
docs/gettingstarted/developers/building.rst
docs/gettingstarted/developers/buildsystem/buildrootmakefile.rst
docs/gettingstarted/developers/fib20/dataplane.rst
docs/gettingstarted/developers/fib20/graphwalks.rst
docs/gettingstarted/developers/fib20/routes.rst
docs/gettingstarted/developers/fib20/scale.rst
docs/gettingstarted/developers/fib20/tunnels.rst
docs/gettingstarted/developers/gdb_examples.rst
docs/gettingstarted/developers/infrastructure.md
docs/gettingstarted/developers/metadata.md
docs/gettingstarted/developers/multiarch/index.rst
docs/gettingstarted/developers/vnet.md
docs/gettingstarted/developers/vpp_api_module.rst
docs/gettingstarted/progressivevpp/index.rst
docs/gettingstarted/progressivevpp/switching.rst
docs/gettingstarted/progressivevpp/twovppinstances.rst
docs/gettingstarted/users/configuring/hugepages.rst
docs/gettingstarted/users/configuring/startup.rst
docs/gettingstarted/users/configutil/sysinfo.rst
docs/gettingstarted/writingdocs/styleguide/index.rst
docs/gettingstarted/writingdocs/styleguide/styleguide02.rst
docs/gettingstarted/writingdocs/styleguide/styleguide04.rst
docs/gettingstarted/writingdocs/styleguidemd/styleguide02.md
docs/overview/features/l2.rst
docs/overview/performance/index.rst
docs/overview/whatisvpp/dataplane.rst
docs/overview/whatisvpp/developer.rst
docs/overview/whatisvpp/extensible.rst
docs/overview/whatisvpp/what-is-vector-packet-processing.rst
docs/reference/cmdreference/index.rst
docs/reference/cmdreference/interface/create_interface.rst
docs/reference/cmdreference/show/show.rst
docs/reference/cmdreference/vhost/vhostuser.rst
docs/reference/vppvagrant/Vagrantfile
docs/reference/vppvagrant/boxSetup.rst
docs/usecases/ConnectingVPC.rst
docs/usecases/Routing.rst
docs/usecases/acls.rst
docs/usecases/automatingthedeployment.rst
docs/usecases/contiv/BUG_REPORTS.md
docs/usecases/contiv/K8s_Overview.md
docs/usecases/contiv/MANUAL_INSTALL.md
docs/usecases/contiv/MULTI_NIC_SETUP.md
docs/usecases/contiv/VPP_PACKET_TRACING_K8S.md
docs/usecases/simpleperf/iperf3.rst
docs/usecases/simpleperf/trex2.rst
docs/usecases/vmxnet3.rst
docs/usecases/vppinazure.rst
3b5e222f 25-Oct-2019 Florin Coras <fcoras@cisco.com>

session: app-closed to transport-deleted on delete notify

Type: refactor

As a result, transport-deleted is the only session state that has no
transport data structure.

Change-Id: I2da2bc4bbb141d8a7b52faae66a4733de8f8513b
Signed-off-by: Florin Coras <fcoras@cisco.com>

0d75f783 21-Oct-2019 Filip Varga <fivarga@cisco.com>

nat: respect udp checksum

Type: fix

Change-Id: I73895fa0101bd50483160c8dc6faac2c67513077
Signed-off-by: Filip Varga <fivarga@cisco.com>

4aacc01f 23-Oct-2019 Ole Troan <ot@cisco.com>

tests: switch test framework to python3 by default

Type: make
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I84d32f022d9dc555837c8916feba04a224cd262a

63cb8827 13-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: make RA tests run on VPP time

the IPv6 RA tests take timing into the account,
but the time inside VPP may go slightly differently compared
to the time inside the driving python thread,
if the machine running the tests is heavily loaded.
Make a sleep function which sleeps "on VPP time" and use it.

Change-Id: I3b34b0164f6e0ec7a619b92ee308089a4a8935e3
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

d29422cb 27-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vlib: unix trivial- clean up typos in docs

seen while reading through the code.

Type: style

Change-Id: I7a2f021b9f06d0eebb2ea3d0cafb6955ccb14781
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

ea5cd12d 23-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: fix tracing of packet flags

This fixes incorrect tracing of flags such as MORE_FRAGMENTS.

Type: fix

Change-Id: Ia5698418a7cbb45c18bc9c95f560cea020e63c39
Signed-off-by: Klement Sekera <ksekera@cisco.com>

cf7803d2 23-Oct-2019 Benoît Ganne <bganne@cisco.com>

ip: reassembly: fix use-after-free

When processing the last buffer of a reassembled packet, the current
buffer will be freed and must be reloaded using the updated index.

Type: fix

Change-Id: Ib39e29e60eb527b4cd4828a3aa37d82c8dddd709
Signed-off-by: Benoît Ganne <bganne@cisco.com>

1b1ccadc 25-Oct-2019 Ole Troan <ot@cisco.com>

vapi: switch to python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I78aac39b697e29bb454e5e95855e79ea3122b4c3

df0191ea 25-Oct-2019 Ole Troan <ot@cisco.com>

l2: l2bd nd termination test instability

The test for ND event suppression reused the previous test run
ipv6 address, and would sometimes consider that a duplicate,
and therefore suppressing that one too.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I1b115aa4eba9d57770fa03fcf38b7a1c251cfe88

6bcc6a45 15-Oct-2019 Neale Ranns <nranns@cisco.com>

dhcp: fix crash on unicast renewal send

Type: fix

- when the addresses were learnt a copy of the client was sent to the
main thread, this meant the unicast adjacecny was saved on the copy
not on the original.
- Add logging.
- Improve the proxy-node that hands the clint packets so the DHCP
packets are traced.
- allow a renewal to configure new address data

Change-Id: I6ab0afcccbc4a1cdefdd1b8beeda8fc7ba20ec1f
Signed-off-by: Neale Ranns <nranns@cisco.com>

d7b30665 24-Oct-2019 Dave Barach <dave@barachs.net>

mdata: buffer metadata change tracker plugin

A handy tool in case you need to know which metadata will be changed
when a packet visits a certain node.

Reflect metadata changes into format functions used by the
vpp-specific wireshark dissector.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I96fe8a24db4082bb29fe2a33cc522e8616a3a1bb

94afc939 23-Oct-2019 Benoît Ganne <bganne@cisco.com>

gso: fix buffers trace

When segmenting, new buffers must inherit the original buffer trace
handle.

Type: fix

Change-Id: Ibd1859a501b2862906dfc563b98652cfee5681da
Signed-off-by: Benoît Ganne <bganne@cisco.com>

002723c4 23-Oct-2019 Steven Luong <sluong@cisco.com>

lacp: add actor steady state check prior to skip processing lacp pdu

In a rare event, we may be skipping processing lacp pdu's when the it is
not in steady state.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3595d22dbff8a97dce9fb4d4452d2051bcf6f523

7331005c 23-Oct-2019 Steven Luong <sluong@cisco.com>

devices: vhoost cpu->copy array overflow on tcp jumbo frame (65535 bytes)

We reserve 40 slots in cpu->copy array prior to copy out to avoid overflowing
the array. However, 40 is not enough for the jumbo frame because desceiptor
buffer len is likely at 1536. Change the reserve to 200 and add ASSERT to avoid
encountering the same problem in the future.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ibf0c03c4b4f33e781d5be8679ccd6c3a4b4a646d

00b2d74d 18-Oct-2019 Changqian Wang <changqwa@cisco.com>

memif: memif buffer leaks during disconnecting zero copy interface.
code added to free the zero copy interface rx/tx queue buffers during disconnecting.
As ddc9eb4 find the last official solution introduced core in ut. This does not.

Type: fix

Signed-off-by: Changqian Wang <changqwa@cisco.com>
Change-Id: I971ee164e6d4331a85feb9e65d6702d771c86985

2a884db1 23-Oct-2019 Ole Troan <ot@cisco.com>

cdp: re-enable skipped tests for python3

CDP uses the running sytems host name, which
caused different failures on different systems.
The root cause was an python3 specific error in
checksum calculation.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I205436682d46e7e8cbb8c057c03a76dbbcab4d72

1a7bb281 02-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

avf: improve timeout handling

Type: feature

Change-Id: I8fa1d691ef7bc51ae5c44c344195207ce7d0a2e7
Signed-off-by: Damjan Marion <damarion@cisco.com>

eeb5fb3a 03-Oct-2019 Ignas Bačius <ignas@noia.network>

sr: add "set sr encaps hop-limit" command

Default hop-limit for the encapsulating IPv6 header is a compile-time
constant. Add ability to specify custom hop-limit, in order to avoid
packets being dropped with "hop limit exceeded in transit" response in
certain network configurations.

Type: feature
Signed-off-by: Ignas Bačius <ignas@noia.network>
Change-Id: I77f2b35c987cfd31801dc2744d31fb3c1984158f

bd0a00a4 22-Oct-2019 Miklos Tirpak <miklos.tirpak@gmail.com>

gtpu: msg id fix in send_gtpu_tunnel_details api

Type: fix

_vl_msg_id must start at msg_id_base.

Signed-off-by: Miklos Tirpak <miklos.tirpak@gmail.com>
Change-Id: Id3f05683c873fcac47667a9736e45e85849b740c

40dc4b35 22-Oct-2019 Ole Troan <ot@cisco.com>

papi: fix default handling

The BaseTypers object were reused, so a default for anyother mesage
would be inherited in new messages.

Type: fix
Fixes: 85465588b18fef9c4712f864f512e00741e2d4f2
Change-Id: Ie1efb85a76b088653eb9ea4b88540c98b6b0aad0
Signed-off-by: Ole Troan <ot@cisco.com>

d6ae4bf1 13-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: improve rate samples for retansmitted segments

Type: fix

- Initialize max_seq on both transmitted and retransmitted segments
- Keep track of segments that have been sacked.
- Track new data segments sent during recovery

Change-Id: Ice55231a3da200ae6171702e54b2ce155f831143
Signed-off-by: Florin Coras <fcoras@cisco.com>

81cb8e40 23-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: fix sack retransmit beyond snd_nxt

Type: fix

Ensure that sack retransmit logic does not try to inadvertently send new
data.

Change-Id: Idfda19643577d9c1b58e2af8d8283cabfbaf98e6
Signed-off-by: Florin Coras <fcoras@cisco.com>

386ebb6e 22-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: build: fix ibverb compilation test

Type: fix

Change-Id: Ib6389ecbcf4a1b7bae25b2bd9e7fbdec49545aaa
Signed-off-by: Benoît Ganne <bganne@cisco.com>

70d5d4fa 22-Oct-2019 Benoît Ganne <bganne@cisco.com>

vppinfra: make coverity happy with vec_set_len

Coverity gets confused by ASSERT((l) <= vec_max_len(v)) when l is 0.

Type: fix

Change-Id: I247d7015b148233d8f195bcf41e9a047b7a21309
Signed-off-by: Benoît Ganne <bganne@cisco.com>

3ad078d7 21-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tests: quic add big stream extended tests

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I6c5bdfd934a2c96c410c36c2bc090ee47b679bea

419d31f8 12-Oct-2019 haiyanx1.zhang <haiyanx1.zhang@intel.com>

tests: test tls case

Type: feature

Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>
Change-Id: I071f5face0d489dc967cce1edcffbc1f8fac5c7e
Signed-off-by: haiyanx1.zhang <haiyanx1.zhang@intel.com>

dbc9c599 25-Sep-2019 Florin Coras <fcoras@cisco.com>

vcl: handle segment map errors

Type: fix

Change-Id: Ibd122a4565c067627c4bbc8cac7df2d5b6497392
Signed-off-by: Florin Coras <fcoras@cisco.com>

d747c3c3 21-Oct-2019 Florin Coras <fcoras@cisco.com>

vcl: add config option for preferred tls engine

Type: feature

Change-Id: If6c095c9b737cb524a9232dcfa9be0f93f04d114
Signed-off-by: Florin Coras <fcoras@cisco.com>

91af1859 21-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tests: enable vpp_echo to run in gdb

- Enable vpp_echo to be run in gdb when
running 'make test DEBUG=gdb-all'

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I79a69b0573c01900535078d7493d52b417350815

2456433d 21-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

tests: DEBUG=gdb[server]-all to debug worker(s)

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I0264451632c1ce780b38a2c15a7e34350fc6d521

78af0a8c 29-Apr-2019 Benoît Ganne <bganne@cisco.com>

vppinfra: add clib_mem_free_s

IPsec zero-es all allocated key memory including memory sur-allocated by
the allocator.
Move it to its own function in clib mem infra to make it easier to
instrument.

Type: refactor

Change-Id: Icd1c44d18b741e723864abce75ac93e2eff74b61
Signed-off-by: Benoît Ganne <bganne@cisco.com>

c41217ab 18-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix GCM cipher

Type: fix

Change-Id: I382499061ff4b1c2cc1b70ebbf9725ff0e1be325
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

c9b2cfca 22-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly: avoid corruption in vnet buffer

Avoid corrupt next_index in vnet_buffer by moving input and output
variables into different memory places instead of sharing a common
space.

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: I34471fc6d0c8487535fac21349e688f398934f6d
Signed-off-by: Klement Sekera <ksekera@cisco.com>

bb098f17 22-Oct-2019 Neale Ranns <nranns@cisco.com>

gbp: missing contract hash-mode setting

Type: fix

Change-Id: Ia0f1e88b43e861d3f6965076c73cc48fb9574da3
Signed-off-by: Neale Ranns <nranns@cisco.com>

89b24950 18-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ipsec: fix tunnel protection removal

Type: fix

Change-Id: I4d5546d1f9b3a162291997f6f0c094c5c3d6cf31
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

2f71a888 10-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

ip: ipfix-export API update

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I5b03e5de111c3a3b8da4e9f02cba0aa99e3ee9f3

bd38f7ff 22-Oct-2019 Ole Troan <ot@cisco.com>

cdp: disable failing tests for python3

scapy in python3 does not seem to allow creating invalid protocol
packets. Suggest the maintainer rewrite the invalid tests so they
also work for python3. In the mean time they are disabled.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I554d57528422c98c6df4ba76eeae38c03f512a38

534de8b2 11-Jun-2019 Benoît Ganne <bganne@cisco.com>

build: add missing ldflags to exe and shared

Type: fix

Change-Id: I859bc6ebc574ab09fd70b45f8c911769d00e7acf
Signed-off-by: Benoît Ganne <bganne@cisco.com>

8a4bfdae 22-Jul-2019 Benoît Ganne <bganne@cisco.com>

vppinfra: add vec_set_len()

l2-flood and bier nodes reset vector length without updating it to its
effective size. Introduce a helper to do it (this allows ASAN to keep
track of the new vector size).

Type: refactor

Change-Id: I2d652550c440f0553a2b49c3ee3d37b49ebc16c3
Signed-off-by: Benoît Ganne <bganne@cisco.com>

26ea1465 11-Oct-2019 snaramre <snaramre@cisco.com>

tests: python3 changes for dns tests

Type: fix
Change-Id: Ia81c60d469b29606d9988d7d9ed1e133e6af7158
Signed-off-by: snaramre <snaramre@cisco.com>

b0d83f18 21-Oct-2019 Ole Troan <ot@cisco.com>

flowprobe: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I7425147e864467e4f94cee2a82ef74a894339471

98bd3580 21-Oct-2019 Yu Ping <ping.yu@intel.com>

tls: enable tls engine as the default engine

OpenSSL TLS is well maintained and many issues are fixed, and it makes
OpenSSL as the default engine will be more friendly to users if app does
not configure a specific engine such as http_static

Type: fix

Change-Id: I37499af1edd40ffb53b00436044d1fce3b43348d
Signed-off-by: Yu Ping <ping.yu@intel.com>

67694733 21-Oct-2019 Ole Troan <ot@cisco.com>

geneve: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I0ff4d58c181b2bdf483b8b039ad005c2a4915aa8

f6dee6c8 21-Oct-2019 Ole Troan <ot@cisco.com>

bonding: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I6cedb43af4437fdabce75f4a845629c5c2f96f6a

5e56f751 21-Oct-2019 Ole Troan <ot@cisco.com>

ip: test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I9c66bce900f78e5fbd435515df94e327ad25c3c6

3f2a956a 21-Oct-2019 Ole Troan <ot@cisco.com>

l2: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id17bcb65d7eb27f865fc7872b3e485c09f1d29a7

203bf04d 21-Oct-2019 Ole Troan <ot@cisco.com>

acl: l2 classify test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3b2e57e3dcf04ae50724b5909272b083d6003a85

8b76c23d 21-Oct-2019 Ole Troan <ot@cisco.com>

ipsec: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id13da9371c71c10c12a0120ec89ba21c1ca47524

1556b3ad 21-Oct-2019 Ole Troan <ot@cisco.com>

classify: tests to support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I8af6ee6e5239f0836978baa063a18a01c610279f

22674295 21-Oct-2019 Ole Troan <ot@cisco.com>

bier: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3cf5295f1a85579a66ba38ca1f74678b45474959

74dcbf97 06-Aug-2019 Mathias Raoul <mathias.raoul@gmail.com>

quic: Add PICOTLS_INCLUDE_DIR var to CMakeLists.

Type: fix

Change-Id: I10ebcc653491d11ca798e0a60be6eeef82c41766
Signed-off-by: Mathias Raoul <mathias.raoul@gmail.com>

586d3edf 21-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: add PID of VPP under test to API dump filename for the test

Some testclasses (e.g. IPSec) have methods with the same names,
this causes a race when running in parallel to save the API and
move it into the test's directory - the name of the file has
only the test method name as a discriminator.

Saving two traces from two VPP instances "succeeds", in that
it silently overwrites the file. But only one mv operation
works - the other gives an error "file not found" and fails the test.

Solution: add the PID of VPP under test to the API dump filename,
this way the filenames become guaranteed unique and the race is avoided.

Change-Id: I1bb47ed73369fea0f1bfbf907588a51e2cabfb7f
Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

127fbec4 18-Oct-2019 Ole Troan <ot@cisco.com>

ip: reassembly tests python3 support

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I990d8d521c128e8d4f482e30b3a49cbc11b632d1

79ba25d4 21-Oct-2019 Florin Coras <fcoras@cisco.com>

session: support registration of custom crypto engines

Type: feature

Change-Id: I888d415ff645b3827df7d4cfb0d3c5f4ac940617
Signed-off-by: Florin Coras <fcoras@cisco.com>

ef7cbf6a 17-Oct-2019 Florin Coras <fcoras@cisco.com>

vcl: add api to set lcl ip

Type: feature

Change-Id: I40169fbbe8a20670dd612c341b6c78b5c925bf74
Signed-off-by: Florin Coras <fcoras@cisco.com>

12966a7a 18-Oct-2019 Ole Troan <ot@cisco.com>

dhcp: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie136c1e94e5c25f9547fc2d6d45ce8e1630a035c

45495480 17-Oct-2019 Yulong Pei <yulong.pei@intel.com>

vlib: linux: fix wrong iommu_group value issue when using dpdk-plugin

When VPP work with dpdk-plugin, linux_vfio_main_t->container_fd is always -1
since it never have chance to run open("/dev/vfio/vfio") to get the fd.

But this lead to a potential issue of VPP, that is, when start VPP without
uio-driver field setup in /etc/vpp/startup.conf, VPP will run to automatical
select uio driver in vlib_pci_bind_to_uio() and the function depend on
iommu_group value to decide to work on vfio or vfio-noiommu mode.

Since in vlib_pci_get_device_info() have the condition container_fd != -1,
so the iommu_group value will be always -1 at this scenario, this caused
that VPP mistake to run with vfio-noiommu driver on intel_iommu=on state.

Actually in order to get iommu_group and iommu_group/name value, no need to
depend on linux_vfio_main_t->container_fd value, so the fix remove the
condition lvm->container_fd != -1, then it can get the correct iommu_group
value.

Type: fix

Change-Id: I3f162fc4971b9a2b8717205f8f3b52e30c5e5b69
Signed-off-by: Yulong Pei <yulong.pei@intel.com>

349cd1af 18-Oct-2019 Dave Barach <dave@barachs.net>

vlib: enable worker-thread dispatch pcap trace

Needed a bit of foreach_vlib_main(...) action to turn on/off all
instances of vm->dispatch_pcap_enable, and to pick up the pcap_main_t
pointer from vlib_global_main.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I49b69b87934c7dc7a9835cd07aa2c5c4d3c79f18

55cc4c4f 18-Oct-2019 Dave Barach <dave@barachs.net>

mactime: fix handle_get_mactime fcn prototype

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9576ade941b10d1605f6c6714f312ae2a8ad5065

9cd8f339 18-Oct-2019 Ole Troan <ot@cisco.com>

ip: add python3 support to punt tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib918d11fb3278a25a92006dcfe3c7c484e7b33ea

9e160f82 18-Oct-2019 Ole Troan <ot@cisco.com>

map: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icbe9ca3dc738c6575fe382740a1cc9d29a4a74ff

2915649f 18-Oct-2019 Ole Troan <ot@cisco.com>

gso: python3 support in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I166019cc69fd01cb43f1a3fad699f3d2e5ec5b19

19757332 18-Oct-2019 Ole Troan <ot@cisco.com>

ip: ip vrf tests python3 support

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie23c9d2d7325be62ef33df2f0562ab41518f7bf4

5dc5fcf1 18-Oct-2019 Ole Troan <ot@cisco.com>

udp:: support python3 in tests

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iea19d7bc2dfe9736ddefb4419509ccfda7a67eeb

e5b83aa3 18-Oct-2019 Ole Troan <ot@cisco.com>

memif: add python3 support to test

Committed from SK936 seat 1A.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I717fafbdb9b8576508d6dd72a7e5653cecebfae0
Signed-off-by: Ole Troan <ot@cisco.com>

f158944c 18-Oct-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

ip: trivial typos in docs

Type: style

Change-Id: I620f15b96ee5401e0145a139f06d343d7c4fadb4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>

64e978b1 17-Oct-2019 Ole Troan <ot@cisco.com>

ipsec: make tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3255702e7c562c8d04a91a095e245756c6443a9e

2bb7151d 16-Oct-2019 snaramre <snaramre@cisco.com>

tests: python3 changes for span and aclplugin test

Type: fix
Change-Id: Ia9f74f951f831cc5c9b5af863db1bb3f7a1a81ff
Signed-off-by: snaramre <snaramre@cisco.com>

8a754f1a 17-Oct-2019 Florin Coras <fcoras@cisco.com>

session: unify buffer tx dispatching

Type: refactor

Use pending tx buffer vector to postpone dispatching of all buffers,
i.e., either generated as a result of tx events or custom tx event.

Change-Id: Ic5894c4653c338cfb04555d20857f954b245ee83
Signed-off-by: Florin Coras <fcoras@cisco.com>

9929561a 17-Oct-2019 Dave Barach <dave@barachs.net>

http_static: pass http request type to builtin handlers

Makes it easy to tell GETs from POSTs, etc., in case one wants to
register the same handler for multiple request types.

Return interface stats as a json array, makes .js code a lot simpler.

Type: refactor

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Iadae7b909cf3e8ea179fe93620737fdf68f888ac

19cb04df 17-Oct-2019 Ole Troan <ot@cisco.com>

classify: make tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I7c4a12165fa0928fb2b8d99fc1c8d5de16377e7e

2a7ea2ee 17-Oct-2019 Florin Coras <fcoras@cisco.com>

session tcp: infra for transports to send buffers

Type: feature

Add infra that allows transpors to enqueue pending buffers without the
need to build and manage their own pending frames. An important benefit
is the fact that buffer wire/tx ordering is ensured by session layer.

Change-Id: I764fd1693d610b321a1d0c84b648a314f14583db
Signed-off-by: Florin Coras <fcoras@cisco.com>

3030beae 17-Oct-2019 snaramre <snaramre@cisco.com>

tests: python3 fixes for reassembly tests

Type: fix
Change-Id: I0d9b823bd558c48b18af9b0d1e80c30729e64dac
Signed-off-by: snaramre <snaramre@cisco.com>

cb711a4e 17-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: avoid sending acks when data available

Type: fix

Change-Id: I02e2cb2d349f9ddb2bfed040a08ca448f379d565
Signed-off-by: Florin Coras <fcoras@cisco.com>

ec44e263 16-Oct-2019 snaramre <snaramre@cisco.com>

tests: python3 changes for load balancer test

Type: fix
Change-Id: Id9a328158e7c4106a95928bf8ddceb7b9e73aa25
Signed-off-by: snaramre <snaramre@cisco.com>

b8d5e405 16-Oct-2019 Ole Troan <ot@cisco.com>

nat: tests support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie15ea8f01846f87cb65e90e8762dc941441fc176

45ec5708 16-Oct-2019 Ole Troan <ot@cisco.com>

vppinfra: test support python3

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Id1794f38fcb776ded9b769141f5f47d7be75f247

c30318da 17-Oct-2019 Sergey Ivanushkin <sergey.ivanushkin@enea.com>

tcp: Init cwnd from ssthresh.

Set high ssthresh out of the box and make configurable

Type: fix

Signed-off-by: Sergey Ivanushkin <sergey.ivanushkin@enea.com>
Change-Id: Iba1549b4ee55e51468ad0b28ef3d26a85fa9cae0

e0fd9ed1 15-Oct-2019 Dave Barach <dave@barachs.net>

http_static: add "http static cache clear" CLI

Useful to force content reloads

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ieecb018bec61a1624574660842d7d92cd84520f9

f72ad93d 09-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

ip: punt API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I7048f8ec598a8b06d75bdfb5d2fab9f6337c9474
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

54f89e55 10-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

ip: rd_cp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I1cc42b57fbf72e2ced8b5d1283c34de2f7ff948a

8161d73d 16-Oct-2019 Neale Ranns <nranns@cisco.com>

misc: Update gitignore for /test/ext/.d

.. otherwise i'm going to commit it accidentally

Type: feature

Change-Id: I0378b9a29a28ea7317bc7d234f8cbacdafd6b762
Signed-off-by: Neale Ranns <nranns@cisco.com>

cc3aac05 16-Oct-2019 Benoît Ganne <bganne@cisco.com>

bonding: fix interface deletion

Copy sw_if_index value instead of using pointers to original
bif->slaves content which could be overriden by eg. vec_del1().

Type: feature

Change-Id: I37e458effd6b2367479574f7bd3facd4e93bada4
Signed-off-by: Benoît Ganne <bganne@cisco.com>

a9e1f7b9 16-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: fix mss flag in option parsing

Type: fix

Change-Id: Ib03151a097caf15e4e8285afea83d1b930a874b0
Signed-off-by: Florin Coras <fcoras@cisco.com>

e24a4bc0 16-Oct-2019 Florin Coras <fcoras@cisco.com>

session: increase max ctrl msg size

Type: fix

Connect ctrl message recently outgrew the maximum ctrl msg size, so
increase the limit. Also add static asserts for messages that could
potentially exceed the limit.

Change-Id: I0d3e32e0d4d67d7e222cff14ddba59a0c3fb8b00
Signed-off-by: Florin Coras <fcoras@cisco.com>

8a8b05c5 16-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: avoid head retransmit if scoreboard has no holes

Type: fix

Change-Id: I6164ad0d97cd91b60c85302eff691836d12a0a70
Signed-off-by: Florin Coras <fcoras@cisco.com>

71e5b471 10-Oct-2019 Steven Luong <sluong@cisco.com>

bonding: graph node running after bond-input in feature arc may crash

In bond RX quad loop, when all packets within the frame have the same incoming
interface, we cannot skip calling bond_update_next because that function calls
vnet_feature_next() to update the b->current_config_index. The next node needs
the correct b->current_config_index to work with.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3d8b3d4e0f95490f406fae7638f0c43c301ce664

94e4dea1 16-Oct-2019 Benoît Ganne <bganne@cisco.com>

cdp: fix non-null terminated vector use

Type: fix

Change-Id: I31e5d9d9e93339eb789aed20996f326b085c22a9
Signed-off-by: Benoît Ganne <bganne@cisco.com>

15372774 12-Jul-2019 Matthew Smith <mgsmith@netgate.com>

dpdk: add function to add/del extra MAC addrs

Type: feature

Add a callback to install or remove an additional MAC address on
a DPDK-managed device. Note that some PMDs don't have support for
this so YMMV.

Change-Id: I7b0cb3fb0af0d66fbdb7b894a712897f889520a5
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

812afe71 15-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: add rdma API

Type: feature

Change-Id: I590612989cb3c114f8d99227ad36c3434e998597
Signed-off-by: Benoît Ganne <bganne@cisco.com>

e8c9f4f1 15-Oct-2019 Chenmin Sun <chenmin.sun@intel.com>

flow: Add 'drop' and 'redirect-to-queue' actions support

Type: feature

Add 'drop' and 'redirect-to-queue' support in
'test-flow' command and DPDK plugin

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I567bb77cb401c9bd1309ecabe802fe9de88c746b

07a0f212 11-Oct-2019 snaramre <snaramre@cisco.com>

tests: python3 changes for ip6 fib tests

Type: fix
Change-Id: Ie7764fec13cbb83b6899c7c33b7b2f8cc5d40c8a
Signed-off-by: snaramre <snaramre@cisco.com>

8e20fe7a 16-Oct-2019 Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>

svm: immediate fifo growth even when wrapped

Type: fix

- when the fifo is wrapped, and if applicable, insert a new chunk after
the tail-chunk and rebuild the rb_tree.
- make sure that this new algorithm can be applied only when the fifo is
used by a single thread (master-thread of the fifo).

Signed-off-by: Ryujiro Shibuya <ryujiro.shibuya@owmobility.com>
Change-Id: I3fc187bc496ea537ca24381e4abc08d2906c9e03

a9f1e7d4 16-Oct-2019 Benoît Ganne <bganne@cisco.com>

svm: reset vector data instead of length

Reseting vector length confuses ASAN and does not reset data either.
Only reset data instead.

Type: fix

Change-Id: Id60b8333df28a5b636a9d302b987bbad95c85c38
Signed-off-by: Benoît Ganne <bganne@cisco.com>

7391156c 16-Oct-2019 Benoît Ganne <bganne@cisco.com>

fib: fix use-after-free for interface adj removal

Type: fix

Change-Id: I82308e368d14d84f5970dad229bdcf2de7d1839d
Signed-off-by: Benoît Ganne <bganne@cisco.com>

94d2da0b 16-Oct-2019 Benoît Ganne <bganne@cisco.com>

session: fix use-after-free

Type: fix

Change-Id: Ie63b80db56febc8a16bafcdd5399b2f92b6aa437
Signed-off-by: Benoît Ganne <bganne@cisco.com>

6ed154f7 15-Oct-2019 Ole Troan <ot@cisco.com>

tests: cli wrapper should return string

Python3 fixes.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I648b2142d45dfab9146a02eeb1b12de11103ff9f
Signed-off-by: Ole Troan <ot@cisco.com>

d6df3acf 29-Aug-2019 snaramre <snaramre@cisco.com>

tests: python3 version check for enum module

Type: fix
Change-Id: Ie210500fba741d3f047e8499957b5b233a78fa36
Signed-off-by: snaramre <snaramre@cisco.com>

3d93ad9f 10-Oct-2019 Ignas Bacius <ignas@noia.network>

ipip: fix typos in short_help

Type: fix
Signed-off-by: Ignas Bacius <ignas@noia.network>
Change-Id: Ica069e8c9dd4efd1f00639754da471bf11418b57

a3c8ca10 10-Jul-2019 Mohsin Kazmi <sykazmi@cisco.com>

gbp: Add extended SFC unit tests

Type: feature

Change-Id: I1218257af0053ae27c4394d7666fde87a732e08c
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
Signed-off-by: Benoît Ganne <bganne@cisco.com>

29467b53 08-Oct-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: Add gso feature arc

Type: refactor

Change-Id: Ib4a8e7e64093b2db1deda6663325080bc8337605
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

26c7a4b0 09-Oct-2019 Mohsin Kazmi <sykazmi@cisco.com>

ping: Move to plugin

Type: refactor

Change-Id: I51d5bf54dfd408aa0c406cbdf0f4be10ef19d10d
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

ddc9eb48 14-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

memif: Revert "memif buffer leaks during disconnect."

This reverts commit d570c4d18df404cb59ef72d20d56f8e31418c8e9.
That commit introduced crash into memif make test-debug.
To reproduce: "TEST=memif make test-debug".

With this commit reverted the make test-debug for memif passes.

Type: fix
Change-Id: Ic335359e2050bb8a5d530b01c595b081476fa197
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

a66020be 14-Oct-2019 Neale Ranns <nranns@cisco.com>

fib: recursive calculation leads to delegate pool realloc

Type: fix

Change-Id: Ib7ac53d1b59b641ccd3b1d733107d7f1ba174314
Signed-off-by: Neale Ranns <nranns@cisco.com>

ef3c11ca 14-Oct-2019 Dave Barach <dave@barachs.net>

mactime: add the "mactime.json" builtin URL

If the http static server plugin is enabled, register the name
"mactime.json" with the server. Visiting <web-root>/mactime.json
produces a json brain-dump of the mactime table.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ie39b0c776675864a85251b8c07fbf719d399f6de

8d829f6c 13-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: make pg_start() wait until pg completes

A sizable number of tests call pg_start() to get the packets flowing and then
immediately expect to have the entirety of the packets gone through.
This works on powerful and unstressed hardware, but fails in beautifully random
ways under load.

This also necessitates the complicated logic of remembering the "zombie captures",
then sleeping for some time before cleaning them up....

The solution is simple: in pg_start(), start the generators, wait till they
all finish, clean up, done.

Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: I930e51b7aae39c9841d22dd905a4d13a465a672b
Type: test

4f05a8e4 13-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: log error which happens during connect and wait longer for stats socket

Intermittently, a test would start VPP, but no testcases would execute.
This would be more probable apparent during the high load or if there
is another testcase dumping the core at that moment.
Adding the logging to the connection revealed it was the stats socket
connection erroring with error -2. Increasing the deadline
from 3 seconds to 5 minutes has eliminated this error.

Change-Id: I40bd7e642abb9e2aef0238c612e4c34781de5db2
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Type: test

8921dc67 14-Oct-2019 Vratko Polak <vrpolak@cisco.com>

papi: fix socket sendall calls

No point in checking the return value,
as .sendall() raises on error
(and the previous check was missing "not").

Type: fix

Change-Id: I9e07709ddd7093f91ffef87808abbab264b8aa5a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

db056acc 14-Oct-2019 Benoît Ganne <bganne@cisco.com>

gbp: use correct dst mac for RD-UU forward

Type: fix

Change-Id: Ifdd193fab24796346b11a5df81740880f9a50ee8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

78fae134 13-Oct-2019 Keith Burns <alagalah@gmail.com>

mactime: pass context in reply to mactime_dump

Type: fix

mactime_dump API didn't copy context to _details reply,
causing subscription issues.

Change-Id: Ida9f28b437847fba67a7e0832baa2b25a46882a9
Signed-off-by: Keith Burns <alagalah@gmail.com>

6faac162 11-Oct-2019 Florin Coras <fcoras@cisco.com>

tls: allow disconnects from main thread

Type: fix

Use api with explicit thread index to retrieve tls contex on close.

Change-Id: Ibdc4338747300b7fc8f91ef3e10bcd48ce7ae366
Signed-off-by: Florin Coras <fcoras@cisco.com>

39c93494 11-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: vpp_echo refactor quic nclients arg

Type: refactor

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: If8471d98053ae44cae07cdca6d269aa3c7df9887

d442d104 11-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: vpp_echo clean up results comparison

Type: refactor

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I021dfe4a59ecda1ed77b656a81f4c935903854ea

4d62365a 11-Oct-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: vpp_echo remove redundant unformat function

Type: refactor

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ifae49981458cd3ef9e2c79d64040b2076ad93869

6df2c795 11-Oct-2019 Vratko Polak <vrpolak@cisco.com>

papi: harden socket handling

In the previous implementation of socket transport for PAPI,
socket methods .send and .recv_into were used.
But they are not guaranteed to send/receive all the data
for the full message. The receive part contained a loop,
but it handled only the main message, not the header.

This patch replaces .send with .sendall
and uses newly defined _read_fixed method.

Also, removed Paul from maintainers,
as he is not active much, lately.

Type: fix

Change-Id: Iae1a68bf8f9e666856b7c7d62ebfe22defc5dfe1
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

11b40e7e 11-Oct-2019 Dave Barach <dave@barachs.net>

lisp: fix dangling references to bihash tables

gid_ip4_table_t's and gid_ip6_table_t's are allocated from pools. They
MUST NOT be listed on the clib_all_bihash list to avoid dangling
references.

Switch to the clib_bihash_init2 API, which has the required knob.

Type: fix
Ticket: VPP-1788

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I49a17e937922c3af2e1c46b24e20883af51584a8

bbcfaac9 10-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: refactor flags into cfg and conn flags

Type: refactor

Change-Id: Ib5e2ecf55732599e1322736e3662178c9da49c7d
Signed-off-by: Florin Coras <fcoras@cisco.com>

3d36f19a 11-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: explicitly wait for the PG to finish before looking for capture file

Rather than only using time-based method of periodically checking
whether the pcap file appeared, first check that the packet generator
has stopped. To make this change fail-safe, have a 5-minute timeout
on this activity, just in case the things go terribly wrong.

Type: test
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
Change-Id: Id16b2802b2de8a4cafb5d9f0a8c9ba62ec89dc32

7e2cea3d 09-Oct-2019 Dave Barach <dave@barachs.net>

vppinfra: fix page boundary crossing bug in hash_memory64

Fix a day-1 bug, possibly dating back as far as 2002. The zap64() game
involves fetching 8 byte chunks, and clearing octets not to be
included in the key.

That's fine *unless* the 8-byte fetch happens to cross a page boundary
into unmapped or no-access space.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4607e9840032257c96ba7387f86c931c0921749d

8563cb38 10-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly: trace ip headers over worker handoffs

This change adds tracing of IP headers when doing a handoff between
worker threads. This eases debugging.

Type: feature

Change-Id: I2195b070a364cba13a658ec1cee5154fc4c3a8b0
Signed-off-by: Klement Sekera <ksekera@cisco.com>

68bae5b2 10-Oct-2019 Klement Sekera <ksekera@cisco.com>

tests: extra logging in reassembly tests

Type: test

Change-Id: Ia09c3149490e47e49e59544ab1680a8160e60ac8
Signed-off-by: Klement Sekera <ksekera@cisco.com>

be01e635 10-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: RD-CP API incorrect reply code

Type: fix

Change-Id: Ie436d51999dc1384a0db492f28a7e66620e14551
Signed-off-by: Neale Ranns <nranns@cisco.com>

1a41a35b 09-Oct-2019 Steven Luong <sluong@cisco.com>

bonding: feature arc may not be enabled for the slave interface

vnet_feature_enable_disable takes sw_if_index, not hw_if_index. If there
is a subinterface created prior to the slave interface is created,
sw_if_index and hw_if_index start to diverge and the problem will happen.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I11e1f099378832f83b748526c6cbeb56960fad3c

c31dc31f 06-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: improve pacing after idle send periods

Rest pacer on ack reception if we haven't recently sent anything.

Type: feature

Change-Id: I820bacd81b65130052dfafbfcbe6ca4553069fbc
Signed-off-by: Florin Coras <fcoras@cisco.com>

71a5da0c 10-Oct-2019 Dave Barach <dave@barachs.net>

http_static: add .json content

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ibf8583175c181dc12a589b3e6c11a10ee77fc160

be237bf0 27-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: retry lost retransmits

Add heuristic that detects lost retransmitted segments and retries
sending them.

Type: feature

Change-Id: I34d1bb16799e1993779222eb2bfad4b40704159e
Signed-off-by: Florin Coras <fcoras@cisco.com>

5b1379be 07-Oct-2019 Benoît Ganne <bganne@cisco.com>

ip: fix clang debug compilation

The non-extern declaration confuses clang linker in debug mode.
The function is defined as inline above anyway.

Type: fix
Fixes: c6215d902f

Change-Id: Ic7e4477631cf0bcfb31ab3f81effe3642dd4223e
Signed-off-by: Benoît Ganne <bganne@cisco.com>

7fbdb6aa 09-Oct-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: fix typos & cert_key store init

Type: fix

Change-Id: I865534de9f16bff586106e0850f131de1e9cbf24
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

02833ff3 03-Oct-2019 Srikanth A <srakula@cisco.com>

tcp: custom checksum calculations for Ipv4/Ipv6

Type: feature

Based on the configuration, we can disable checksum offload capability
and calculate checksum while pushing the TCP & IP header.
This saves some cycles when VPP stack is used in legacy hardware devices.

Signed-off-by: Srikanth A <srakula@cisco.com>
Change-Id: Ic1b3fcf3040917e47ee65263694ebf7437ac5668
(cherry picked from commit 3642782a2748503f5b5ccf89d1575c1d489948ef)

8a047ed7 24-Sep-2019 Simon Zhang <yuwei1.zhang@intel.com>

tcp: fix tso not work in single buffer issue

Type: fix

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: Iddb6fd41812e8c97af58859ef43279cfc0f9d1df
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>

5932ce17 09-Oct-2019 Dave Barach <dave@barachs.net>

tests: add cli_return_response to vpp_papi_provider

To improve gcov/lcov code coverage stats, it's necessary to send
incorrect debug CLI commands; to force vpp into debug CLI error paths.

cli_return_response() sends commands and returns the response object,
so test vectors can handle failures.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4fab591c9d2e30c996f016e18e4fd69b9c5bed06

a6b93eac 08-Oct-2019 Ahmed Abdelsalam <ahabdels@cisco.com>

sr: fix deleting an SR l2 steering policy

Type: fix
Signed-off-by: Ahmed Abdelsalam <ahabdels@cisco.com>
Change-Id: I9e98b1622785e58484bf316ef491e44cfb06bcb7

709dad30 09-Oct-2019 Ole Troan <ot@cisco.com>

acl: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Idc9c508eb0e3d4b0c3908360fb0771012a8e2bc0

18cd91c6 09-Oct-2019 Ole Troan <ot@cisco.com>

mactime: fix undefined symbol in mactime_test

undefined symbol format_macaddress

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I5549173ef758e965cf7d9d4f6aa9457d135318f5

2d3282e1 30-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

geneve: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I1964e4f0afe6f030ae9c8e28fcba5fd81aa1f130

3ae9f5a9 08-Oct-2019 Ole Troan <ot@cisco.com>

memif: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icab769607c4a5890dc80b8f2661faa7e297c2a27

1890e9ce 02-Oct-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix dangling pointer

Type: fix

Change-Id: I8aa9029e0a5cf21aa24a90b39eb2787653f65abb
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

2a111841 09-Oct-2019 Ryujiro Shibuya <Ryujiro.Shibuya@owmobility.com>

session: avoid old io dispatch if no slots left to send

Type: fix

Signed-off-by: Ryujiro Shibuya <Ryujiro.Shibuya@owmobility.com>
Change-Id: I8e1f6cbd905ad5c21aed1b2e358540d0fbd7fc47

66f2a889 31-Jul-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

docs: Add macos build documentation

Type: docs

Change-Id: Iee03aacab2cfcb4e87190302dc641e8273b7f096
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

7b2e9fb1 01-Oct-2019 Klement Sekera <ksekera@cisco.com>

map: use ip6-full-reassembly instead of own code

Remove map's implementation of reassembly and use common
ip6-full-reassembly functionality. This makes it easier to maintain by
removing duplicate code/functionality.

Type: refactor

Change-Id: I430e888b704e28c100a9ce075d1460cb529e4676
Signed-off-by: Klement Sekera <ksekera@cisco.com>

d5262831 30-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

dhcp: dhcp6_pd_client_cp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: If6c102a53d074cba7eca6b6af9855aa4486f38cc

de312c2d 27-Sep-2019 Mohsin Kazmi <sykazmi@cisco.com>

interface: dump the interface device type

Type: feature

Change-Id: I22e2ef34631c9432311ff6457504e0649e0512b4
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

2429f8bd 08-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: fix coverity warning

Type: fix
Fixes: 0eb75d0e9c7624a4e8ac69fea7dbe12d39b75096

Change-Id: I8bcdc06b33bf4e12752b90dc3445fa51af552a46
Signed-off-by: Klement Sekera <ksekera@cisco.com>

2777ec76 24-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

build: clean up make help output

This change is designed to help the uninformed find the right way
to run extended tests by using the test-all[-debug] targets.
'make test EXTENDED_TESTS=y' fails to build as it has a dependency
on 'vom-install' which is conveniently included in test-all[-debug].

- clarify test-all[-debug] description and
make test-help description
- Also align indentation of make help output

Type: style

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: Ief54cc8a5af68c052aacb0d660237c5eb63451b5

e0792fdf 12-Jul-2019 Matthew Smith <mgsmith@netgate.com>

interface: callback to manage extra MAC addresses

Type: feature

New callback vnet_hw_interface_add_del_mac_address().

Add or delete secondary MAC addresses on a hardware interface.
This will allow packets to be processed which have a destination
MAC address other than the primary programmed MAC address without
needing to put the device into promiscuous mode.

Change-Id: I6beecbcb8932fc1fe45b567f76fa3706feefae2c
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

6a6af6ea 07-Oct-2019 Vratko Polak <vrpolak@cisco.com>

api: comment, simplify and fix api socket read

The function vl_socket_read_ready did contain some comments already,
but as they stated, the logic has to be tricky to cover multiple cases.

Comment:
+ Add function-level comment
+ Add comments to describe some of local variables
+ Add many comments to describe internal state at particular lines.

Simplify:
+ Remov mbp_set as it is never needed.
+ Replace msg_len with msgbuf_len to save "+ sizeof (msgbuf_t)".

Improve:
+ Early exit on EAGAIN.

Fix:
+ "n" now only tracks input_buffer.
Previously, it was entering the detection of additional messages
even for unprocessed_input.
+ Set up msg_buffer (including appending to unprocessed_input)
outside full-message-detection loop now,
so it cannot be executed multiple times as before.

Type: fix
Ticket: VPP-1785

Change-Id: I256e34b435be06844458744a13ea37a0e86a96f9
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

0938547e 10-Sep-2019 Vratko Polak <vrpolak@cisco.com>

papi: introduce read_blocking

Previously, self.transport.q got the messages
(at least for socket transport), stored in the encoded (packed) form.
In order to avoid accessing internals for async reads,
a new method is introduced, to perform
blocking reads of decoded (unpacked) messages.

The method is also used in _call_vpp(),
so sync and async reads are kept compatible.

Type: feature

Change-Id: Id49792dfa57c00b1a14a198031c5398d09a9ba20
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

d6f1c9c5 06-Oct-2019 Rajesh Goel <rajegoel@cisco.com>

mpls: support fragmentation of mpls output packet

Type: fix

Signed-off-by: Rajesh Goel <rajegoel@cisco.com>
Change-Id: Ie4372c5cf58ab215cdec5ce56f8a994daaba2844

ab96454e 08-Oct-2019 Ole Troan <ot@cisco.com>

ioam: remove api boilerplate

Note: The VAT _test.c plugins need some more adjustments.

Type: refactor
Change-Id: Ifa150683d7d68db7950f66ef85eea73c8281ba14
Signed-off-by: Ole Troan <ot@cisco.com>

b126ebcf 07-Oct-2019 Ole Troan <ot@cisco.com>

api: autogenerate event handler functions for *_test.c

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: If75f63244f37ae3312832ca015f738c51ee7da1f
Signed-off-by: Ole Troan <ot@cisco.com>

1ff3c15b 08-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: only install IPv6 prefixes in FIB when the interface is up

otherwise they get installed twice and the reference counting means they are not removed.
This is the same behaviour as IPv4.

Type: fix

Change-Id: I9266e04ccff6ff06a577e85973a2ddbeb9dfc52b
Signed-off-by: Neale Ranns <nranns@cisco.com>

da0e7497 08-Oct-2019 Neale Ranns <nranns@cisco.com>

fib: P2P interfaces do not need specific multicast adjacencies

they can use the 'auto' adj for all traffic

Type: fix

Change-Id: Id2b9557683252a94badc8f9dfab5f7b2ae26f1ee
Signed-off-by: Neale Ranns <nranns@cisco.com>

82fc5fd4 13-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: use crypto_engine_type_t for TLS

Type: refactor

This patch does the following conversions
TLS_ENGINE_X -> CRYPTO_ENGINE_X
tls_engine_type_t -> crypto_engine_t
It does not change numbering of engines

Change-Id: I872dfaec3a6713bf4229c84d1ffd98b8b2419995
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

79f89537 13-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: Add certificate store

Type: feature

This changes the behavior of both API calls
APPLICATION_TLS_CERT_ADD & APPLICATION_TLS_KEY_ADD
certificates and keys aren't bound to an app, they are
passed to it via connect / listen using the message
queue.

This should be followed by a per protocol (QUIC/TLS)
crypto_context store to save devrived structs

Change-Id: I36873bc8b63b5c72776c69e8cd9febc9cae31882
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

ff5a9b6e 25-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: fix vpp_echo session close

- Convert asserts in vpp_echo to conditional checks
- Refactor error logging for session creation/deletion
- Fix session close anomalies
- Fix ECHO_* macros
- Add rx/tx results different cmdline options to
specify pass when counters are different
- Update close tests to send more than the fifo
sizes of data
- Specify rx/tx results diff options for early
close tests
- Set listen session state to closed on handling
unlisten reply

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I9d0075fcb18e20829f420da104d69523897b0552

2fd44a00 07-Oct-2019 Chenmin Sun <chenmin.sun@intel.com>

vlib: fix cli process stack overflow

Type: fix

Some cli processes, including configuring an test flow
on an i40e interface consume more than the currently
available stack space.

Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
Change-Id: I3df53d251cd43286f94647384d6e50a463bad15c

dd60b1b1 08-Oct-2019 Florin Coras <fcoras@cisco.com>

tcp: rate sample for persist segments

Type: fix

Change-Id: I7c38d2ad6364f098529f51c15b533eb234b82716
Signed-off-by: Florin Coras <fcoras@cisco.com>

8229580e 08-Oct-2019 IJsbrand Wijnands <ice@cisco.com>

api: add bapi thread handle to api main structure.

Adding the thread handle to the api main structure allows the client process of
the bin api to manage the thread, like setting the thread name for example.

Type: feature
Change-Id: I38b58ddc83d5958c4bda76eadd371eee1545724b
Signed-off-by: IJsbrand Wijnands <ice@cisco.com>

6be55648 01-Oct-2019 Klement Sekera <ksekera@cisco.com>

tests: handle unicode charactes in cli output

Type: fix

Change-Id: Ic4fb53e6d10a1de155a3088be81d53d9efeb0c0f
Signed-off-by: Klement Sekera <ksekera@cisco.com>

8095b602 12-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: make vpp_echo use mq instead of bapi

Type: refactor

Change-Id: I4f370b09e22dbbc8920272df9a042dae04825bfc
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

caa7acf5 02-Oct-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: add is_migrating flag

Type: fix

Add SESSION_F_IS_MIGRATING flag for session. It is set by the session
layer before poking the transport for migration. It's the transport
responsibility to unset the flag & act apropriatly if RX happens on
a migrating session.

Change-Id: Ie722917f1cf9344d8f041cad4ed8b064fb5853b6
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

859b5913 27-Sep-2019 Jianlin Lv <Jianlin.Lv@arm.com>

api: Add API support for marvell PP2 plugin

Support create/delete interface with PP2 api

Type: feature

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Change-Id: Ia9c0ac0f237fd9f71f5480d736d6bcabee763fff

3a1ef47c 30-Sep-2019 Klement Sekera <ksekera@cisco.com>

ip: remove dead code in ip6-svr

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: Ia714c2e46627864091d3f686dbced4cdd9c1a773
Signed-off-by: Klement Sekera <ksekera@cisco.com>

81e5e529 06-Oct-2019 Haggai Eran <haggai.eran@gmail.com>

docs: change VPP_WITH_SAMPLE_PLUGIN to SAMPLE_PLUGIN in sample plugin documentation

The sample_plugin_doc.md file refers to VPP_WITH_SAMPLE_PLUGIN make
parameter, while the VPP makefile uses SAMPLE_PLUGIN instead.

Type: docs
Signed-off-by: Haggai Eran <haggai.eran@gmail.com>
Change-Id: Id11090fcdc78b77e246da48d0d890865011f1132

4442f7cb 02-Oct-2019 Steven Luong <sluong@cisco.com>

devices: vhost not reading packets from vring

In a rare event, after the vhost protocol message exchange has finished and
the interface had been brought up successfully, the driver MAY still change
its mind about the memory regions by sending new memory maps via
SET_MEM_TABLE. Upon processing SET_MEM_TABLE, VPP invalidates the old memory
regions and the descriptor tables. But it does not re-compute the new
descriptor tables based on the new memory maps. Since VPP does not have the
descriptor tables, it does not read the packets from the vring.

In the normal working case, after SET_MEM_TABLE, the driver follows up with
SET_VRING_ADDRESS which VPP computes the descriptor tables.

The fix is to stash away the descriptor table addresses from
SET_VRING_ADDRESS. Re-compute the new descriptor tables when processing
SET_MEM_TABLE if descriptor table addresses are known.

Type: fix
Ticket: VPP-1784

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I3361f14c3a0372b8d07943eb6aa4b3a3f10708f9
(cherry picked from commit 61b8ba69f7a9540ed00576504528ce439f0286f5)

0dd97d47 07-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix crash when failing to read pci addr on create

Type: fix

Change-Id: I543e2e5976cb384b81278a7ec98a0a6ab1612438
Signed-off-by: Benoît Ganne <bganne@cisco.com>

90ea5dc1 07-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix crash when failing to detect numa node on create

Type: fix

Change-Id: Ibb8e7c1c13869c1dce2385f58bd7260fcf776c5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>

02bfd641 07-Oct-2019 Neale Ranns <nranns@cisco.com>

dhcp: Move to plugin

Type: feature

Change-Id: I3fe27a8ef577741d9a5c4f090ec91cf68fb44fe3
Signed-off-by: Neale Ranns <nranns@cisco.com>

2c41a61d 07-Oct-2019 Dave Barach <dave@barachs.net>

mactime: add a "top" command to watch device stats

Include a binary API change NOT suitable for cherry-picking into 19.08

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id369514a3085f5e4bcee34819c55c4636df9b518

0eb75d0e 07-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: add tracing for ipv6 frag headers

Type: feature

Change-Id: I0e049b28d8c21b67ea4545e865eda4e88f10e485
Signed-off-by: Klement Sekera <ksekera@cisco.com>

cc702410 07-Oct-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: fix wrong condition in update_fifo_size

Type: fix

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: If371cde9412be29634164830c58634da248ad0ae

bb688a4d 07-Oct-2019 Neale Ranns <nranns@cisco.com>

mactime: remove unnecessary function declaration

Type: fix

Change-Id: I80cb666d9eae9d0f780d51fb95454d97ed320454
Signed-off-by: Neale Ranns <nranns@cisco.com>

d3122ef4 29-Sep-2019 Christian E. Hopps <chopps@chopps.org>

vlib: move thread barrier around mod of global node next data

The old code modified the node next array prior to obtaining the thread
barrier. Then it updated the runtime node data, and upon barrier release
caused reforking of each worker thread. The reforking clones the main
thread nodes and reconstructs the runtime node structure. This cloning
is not 100% "deep" in the sense that the node next array is
shared (i.e., only the pointer is copied). So prior to the barrier being
obtained the node's next array is being changed while workers are
actively using it (bad). Treating the node next array as read-only in
the workers and sharing it is a decent optimization so instead of trying
to fix that just move the barrier a little earlier in the process to
protect the node next array as well.

This was tripping an assert in next frame ownership change by way of the
ip4-arp node. The assert verifies that the node's next array length is
equal to the runtime next node count. The race above was lost and the
node next array data was updated in the main thread while the arp code
was still executing in a worker.

This was being hit when many arp requests were being sent from both ends
of a tunnel during which the add next node function was called, which
often led to an assert b/c the next node array was out of sync with the
runtime next node count.

- PS#2 update - move barrier sync to just above code that modifies state.

Ticket: VPP-1783
Type: fix

Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I868784e28f994ee0922aaaae11c4894a3f4f1fe7
Signed-off-by: Christian E. Hopps <chopps@chopps.org>

1dc90824 01-Oct-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Refactor naming & clibs

Type: refactor

Change-Id: I067fc7dbcc0985277df01384d9dcdb0bdf62fba5
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

56f62afe 06-Oct-2019 Dave Barach <dave@barachs.net>

docs: grammar police raid

Edit the front-page intro text. Fix egregious grammar errors,
including an "it's" vs. "its" blunder.

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: If9d7d07899c402cd49bbae988110a15216035b02

364b20a6 07-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly add missing goto

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: I256ef153b3b27a1f7ab7daa45015a2ec4bc84076
Signed-off-by: Klement Sekera <ksekera@cisco.com>

91f68837 07-Oct-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly remove dead code

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: I79589f648f4c75762e5277fb94636a91fa36ccdd
Signed-off-by: Klement Sekera <ksekera@cisco.com>

29736540 16-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

build: add env variable to pass extra cmake args

If VPP_EXTRA_CMAKE_ARGS is set, its content will be
appended to the vpp cmake command cli

Type: feature

Change-Id: I825d4239e62b0a2fb70a652f0671f6c559630aad
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

d751746a 07-Oct-2019 Neale Ranns <nranns@cisco.com>

dhcp: API return code fix

Type: fix

Change-Id: Ifcbfeecd6ca1215ec473eec4cce736ab4eacde80
Signed-off-by: Neale Ranns <nranns@cisco.com>

46023762 07-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: MFIB CLI fix for parsing path flags

Type: fix

Change-Id: I7ed9726d8c5ca26715a84b004a18fd7f93142486
Signed-off-by: Neale Ranns <nranns@cisco.com>

df213385 04-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: prevent loopback of broadcast packets

TX queues must be created before RX queues on Mellanox cards in order to
not receive our own broadcast packets.

Type: fix

Change-Id: I32ae25a47d819f715feda621a5ecddcf4efd71ba
Signed-off-by: Benoît Ganne <bganne@cisco.com>

de0302ca 04-Oct-2019 Steven Luong <sluong@cisco.com>

bonding: traffic traversing the wrong interface

Missing an increment in the while loop. Hashes not stored in the array.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I603027f5a7305478f48a102ac8035ffde9102c53
(cherry picked from commit 0471cdbd3fe04a88a8b70b5f0eff0c378e19abf7)

ac3e72cb 06-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: Fix IP unnumbered dump of one interface

Type: fix

Change-Id: I35fb6fdfba50c4a59cf1ffb94cb51487bcf5afc9
Signed-off-by: Neale Ranns <nranns@cisco.com>

ac78f8a9 04-Oct-2019 Dave Barach <dave@barachs.net>

misc: add "show run summary"

Prints the interior node vector rate, rx / tx / drop rates

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I57130db0f99e852a8498aa90d01e52f7ac33dcc9

4a98388d 04-Oct-2019 Benoît Ganne <bganne@cisco.com>

rdma: make sure pci subsystem is initialized

The rdma driver use the pci subsystem, make sure the dependency is
recorded.

Type: fix

Change-Id: Ibd613f623d355612881acc31b9423f2de13793a3
Signed-off-by: Benoît Ganne <bganne@cisco.com>

0eae2bb1 04-Oct-2019 Benoît Ganne <bganne@cisco.com>

vlib: pci: set pci driver name to none when no driver is loaded

If no Linux PCI driver module is loaded, then the driver_name in the PCI
info struct is NULL. This can triggers crash when checking driver name
eg. in vlib_pci_device_open().
Default to "<NONE>" as driver name, which should never match.

Type: fix

Change-Id: I9e69889a7566467bd8220b92bbbaa72ada957257
Signed-off-by: Benoît Ganne <bganne@cisco.com>

66a332cf 04-Oct-2019 Dave Barach <dave@barachs.net>

docs: add packet-generator writeup

Type: docs

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4abb5c17e6fdfeaed5bbadb2ce83098dde6d05b1

7028a015 04-Oct-2019 MathiasRaoul <mathias.raoul@gmail.com>

hsa: make APP_OPTIONS_PREALLOC_FIFO_PAIRS configurable

-add prealloc_fifo_pairs member in echo_main_t
-new cli parameter in vpp_echo

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I6bb1214ee93e06421cd0a3721420278c51cd59c4

00078b99 04-Oct-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: make quic fifo size configurable via cli

Type: feature

Change-Id: I6d6ac649094ef4bee2aed311915dd58f11972e79
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

79c9d365 30-Sep-2019 Benoît Ganne <bganne@cisco.com>

ip: fix use-after-free in IPv6 SLAAC expiration

Type: fix

Change-Id: I46b166b3a10c4543eafa4422531dd3c725db45f1
Signed-off-by: Benoît Ganne <bganne@cisco.com>

72c159e6 02-Oct-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: update quicly to v0.0.5

-Update quicly patches
-Remove event logger (removed from quicly).
-Update quicly functions calls

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I0355befeb5ce961928f17225c83890ba87cf6ebc

579b1650 04-Oct-2019 MathiasRaoul <mathias.raoul@gmail.com>

vppinfra: create unformat function for data size parsing

Type: feature

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: I8d71078a9ed42326e19453ea10008c6bb6992c52

7233846c 18-Jul-2019 Benoît Ganne <bganne@cisco.com>

nat: fix use-after-free

Type: fix

Change-Id: Iac91c086c4e975f0bada058f40b7b7d4475377f8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

b0a7c484 29-Sep-2019 Benoît Ganne <bganne@cisco.com>

tcp: unittest: do not access non-existent samples

There is no bt->samples for this test, do not use it.

Type: fix

Change-Id: I2090290887bc5c0b5cdb0561cf2bf72a87781089
Signed-off-by: Benoît Ganne <bganne@cisco.com>

ec574ff9 03-Oct-2019 Andrew Yourtchenko <ayourtch@gmail.com>

acl: fix intermittent test failure

ACL tests use random port number in the tests.
A port number 6081 causes the decode in scapy
to consume some of the Raw payload into GENEVE
encoding, which breaks the test.

Solution: bring up the lower range of random
port to 16384, so that it does not touch any
of the well known ports.

Type: test
Change-Id: I022660d8ec147857924b436f1871b0b5ddcf4c47
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

664ec91f 14-Aug-2019 juraj.linkes <juraj.linkes@pantheon.tech>

ebuild: Unite default build platform to vpp

Top level makefile is using vpp as the default platform. The other place
where platform is specified has native as the default. Unite them to the
only currently supported platform - vpp.

Type: make

Change-Id: Idb12ccc3056dd6be640a2d6763dc30e4f789d2ac
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>

87d7bac5 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

misc: add "maxframe" and "rate" to packet-generator cli.

Allow for setting the maximum number of generated packets to be included
in the frame passed to next nodes. This is very important for testing
code which may be susceptible to multi-frame vs single-frame bugs (e.g.,
code that is doing re-ordering where packets may be buffered between
frames).

Update:
- remove redundant packet "rate" option.
- reduce n_max_frame to u32 as that's what pulled from the CLI.

Type: feature
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: Ie362bbb110b2cf01d9f65c559bbe9101e17b7fdc
Signed-off-by: Christian Hopps <chopps@labn.net>

4ec6f6bc 01-Oct-2019 Dave Barach <dave@barachs.net>

emacs: track improvements in vppapigen

Remove boilerplate which is now generated by vppapigen

Type: refactor

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I36bff1a651ac48caa969ed76d963b0a733ef5532

d570c4d1 01-Oct-2019 Padma Ram <padmaram86.raja@gmail.com>

memif: memif buffer leaks during disconnect.

- code added to release the mbuf's to main pool during memif disconnect.

Type: fix

Change-Id: I504dacc9a40bc1702831cf3208fd532d1ae68a6f
Signed-off-by: Padma Ram <padmaram86.raja@gmail.com>

fb0bb3a7 27-Sep-2019 Benoît Ganne <bganne@cisco.com>

api: fix non-null-terminated C-string

Type: fix

Change-Id: I132112bf77e1fad7fc0227a96e6b0cee590295e8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

0e182c5b 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

ipsec: initialize msgid and allow no dh in child sa

- set msgid to 0 not random.
- allow for no DH in ESP child SA

Ticket: VPP-1781
Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: Ibe26009d38f444eeaec5b042097f145d161c7672

49389386 02-Oct-2019 Matthew Smith <mgsmith@netgate.com>

ethernet: fix dmac filter coverity warning

Static analysis says that a possibly null pointer is dereferenced.
Check it first.

Type: fix

Change-Id: I3d1a1548162d1dfc26f19fbcf159f0f1f91eb7c4
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

25fe5782 02-Oct-2019 Ole Troan <ot@cisco.com>

pppoe: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I42705c508e88dae40a4c19ab20a1340623a57e16

7ff64fb9 02-Oct-2019 Ole Troan <ot@cisco.com>

oddbuf: remove api boilerplate

Type: refactor
Change-Id: Ic4922da46bf941249dd74b1a8bc6a98c62c099b7
Signed-off-by: Ole Troan <ot@cisco.com>

2e7a43ca 02-Oct-2019 Ole Troan <ot@cisco.com>

nsim: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Idf2206ae3e3d8dd05e98528ee1f02c4c7d567f37

025166dc 02-Oct-2019 Ole Troan <ot@cisco.com>

dpdk: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2cba1e2912902b092348dddcf9cbcba231c75995

bf6c5c15 01-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

feature: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Id1e7210298cb494f3cb7a47a9ecf2bc1d9c1d58e

103ba6ba 01-Oct-2019 Jakub Grajciar <jgrajcia@cisco.com>

dhcp: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ia63d920788add2584060a240321acced7a471640

d6d50ceb 27-Sep-2019 Vladimir Ratnikov <vratnikov@netgate.com>

map: fix DF[Don't fragment] ip4-map-t behaviour

This patch allows ip4-map-t plugin to drop
packets if DF flag is set and packet size
is bigger than MTU

Type: fix

Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Change-Id: I0c1531a1f876d9efc8e7e2bff9804f298becdb68

cfca8451 01-Oct-2019 Klement Sekera <ksekera@cisco.com>

map: fix indent-off

Replace erroneous INDENT-OFF with INDENT-ON and reformat code which is
non-conforming wrt to code style.

Type: style

Change-Id: Ia3310371e96b248e5da143fad8fdca3b2fb6650b
Signed-off-by: Klement Sekera <ksekera@cisco.com>

a8df85ce 01-Oct-2019 Dave Barach <dave@barachs.net>

vlib: improve summary vector-rate statistics

Type: refactor

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I4b77879b0a84fdec3c1518a972cf003d5135222d
Signed-off-by: Ole Troan <ot@cisco.com>

eacc8c59 01-Oct-2019 Neale Ranns <nranns@cisco.com>

ip: mfib CLI 'via local' fix

Type: fix

Change-Id: I6fd7bb27b95a50d37424f65dc51e8b341f8b1b28
Signed-off-by: Neale Ranns <nranns@cisco.com>

d459bf34 04-Sep-2019 Matthew G Smith <mgsmith@netgate.com>

ethernet: dmac filter checks secondary mac addrs

Maintain a list of secondary MAC addresses on ethernet_interface_t.
In ethernet-input dmac filtering, If packets do not match the
primary interface hardware address, check to see if they match the
other addresses.

Type: feature

Change-Id: Ie0edf45cae0d85c038a61086c47b3ae82d7e162d
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

dd4d8ac2 26-Sep-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: Create custom event logger

Type: feature

Change-Id: I20acfe6a53cf9f15e3e4b8847b6f76757962f1c7
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

ff1f6faa 26-Sep-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: Add Tx, Rx and packet drop counters

Type: feature

Change-Id: I25aeeed49fc569315296a73c5595c2e2e302434f
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

d4aeb84c 18-Jul-2019 Benoît Ganne <bganne@cisco.com>

session: fix use-after-free

Make sure to reinitialize data before free-ing it.

Type: fix

Change-Id: I45727c456d0345204d4825ecdd9690c5ebeb5e94
Signed-off-by: Benoît Ganne <bganne@cisco.com>

b5a2f705 01-Oct-2019 Florin Coras <fcoras@cisco.com>

session: allow transport cleanup in any state

Type: fix

Third time's a charm

Change-Id: I31555a35d2b51f49a93a2a213c28896b0cad4c09
Signed-off-by: Florin Coras <fcoras@cisco.com>

922f0b21 26-Sep-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic: add cli command for stats

add command to display stats from quicly (rtt, packet loss)

Type: feature

Change-Id: Iaa18bc78fbf80a9367ef150a8cf4997a456c6b39
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

7ff07354 30-Sep-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix non-NULL terminated C-string overflow

Type: fix

Change-Id: I584777825636347c116bd084e348858bcb1b7d75
Signed-off-by: Benoît Ganne <bganne@cisco.com>

640edcd9 23-Sep-2019 Klement Sekera <ksekera@cisco.com>

map: use SVR for MAP-T

This change is part of an effort to unify reassembly code. By removing
shallow virtual reassembly functionality in MAP and using the common
vnet provided shallow virtual reassembly, code size and complexity
is reduced.

Type: refactor
Change-Id: Iec8edd039f7b967b53e17bb9bca228a8b452ac0c
Signed-off-by: Klement Sekera <ksekera@cisco.com>

839a7bce 30-Sep-2019 Burt Silverman <burtms@gmail.com>

build: build-root/Makefile rm of install tree

Type: fix

The scenario is touch of a dpdk source file in places like
<TOP>/build-root/build-vpp-native/external/dpdk-19.08/. The subsequent
build will trigger an rm -rf $(PACKAGE_INSTALL_DIR) by
build-root/Makefile at around line 709. Because the package in
question, "external", consists of various "sub" packages, all of which
are controlled with files like .quicly.install.ok located in
build-root/build-vpp[_debug]-native/external, we end up not handling the
.*.install.ok files to reflect the removal of that PACKAGE_INSTALL_DIR.
This fix will correct that, at least for the case of touching/changing
dpdk files. A better long term solution would be to change the "sub"
packages to be full fledged build system packages, as Dave Barach points
out.

Signed-off-by: Burt Silverman <burtms@gmail.com>
Change-Id: Ia94ccaa2795cbf354b5921c3001a7141313b66be

8133c780 09-Sep-2019 Benoît Ganne <bganne@cisco.com>

ipsec: fix use-after-free

When deleting interface from the API, 'hi' gets removed before
'h->sw_if_index' is copied.

Type: fix

Change-Id: I8e10108e9bdf95ab2fe002790d98262d583ca58c
Signed-off-by: Benoît Ganne <bganne@cisco.com>

5c828bc1 27-Sep-2019 Benoît Ganne <bganne@cisco.com>

bonding: fix non-null-terminated C-string

Type: fix

Change-Id: Ibb7ba878b049b8b18e890c43fdd6324cb88d63b8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

46b91ebb 27-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

hsa: fix vpp_echo mq locking

Type: fix

Change-Id: I18d2cde0baaed4134e8378c09aaa88693fb997f8
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

0fc50934 30-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

dhcp: dhcp6_ia_na_client_cp API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ie2d2c74ed3832d137e808e0b52348b4e660feb6f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

63c73536 30-Sep-2019 Klement Sekera <ksekera@cisco.com>

ip: svr: fix feature refcounts

Reference counts need to be per-interface as opposed to global. This
allows configuring the feature on more than one interface correctly.

Type: fix
Fixes: de34c35fc73226943538149fae9dbc5cfbdc6e75

Change-Id: I05534ac59fa86e67290737ec6c61df2c19acab48
Signed-off-by: Klement Sekera <ksekera@cisco.com>

5517bd34 30-Aug-2019 Benoît Ganne <bganne@cisco.com>

vlib: fix old nodes vector overflow in refork

Type: fix

Change-Id: I81c4cf0ce87288bb2d3c7b9f31e9419290d588b4
Signed-off-by: Benoît Ganne <bganne@cisco.com>

328c08d6 30-Sep-2019 Benoît Ganne <bganne@cisco.com>

dns: fix non-NULL terminated C-string

Type: fix

Change-Id: Ib030e6ac3386528901e0805d1ffe2eec033d819f
Signed-off-by: Benoît Ganne <bganne@cisco.com>

f26b2511 11-Sep-2019 Benoît Ganne <bganne@cisco.com>

api: fix use-after-free

Type: fix

Change-Id: I2a599c22d5770587fdd419e5d212c8527054d2e9
Signed-off-by: Benoît Ganne <bganne@cisco.com>

ae072403 30-Sep-2019 Ole Troan <ot@cisco.com>

lb: remove api boilerplate

Type: refactor
Change-Id: I5555037386d6f6593ac3328385603a382be1fc2a
Signed-off-by: Ole Troan <ot@cisco.com>

10bbfce0 30-Sep-2019 Ole Troan <ot@cisco.com>

vmxnet3: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I009e806997461ad790f125d6359993862e1c5e5d

0d935531 29-Sep-2019 Ole Troan <ot@cisco.com>

stn: remove api boilerplate

Type: refactor
Change-Id: I212c87c03324137c79a674d0842ca4537b28e4b4
Signed-off-by: Ole Troan <ot@cisco.com>

1e582206 30-Sep-2019 Ole Troan <ot@cisco.com>

tls: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I92c010e64aa6cc6fb2b3845b37cc24dd112fc5f9

7071952d 30-Sep-2019 Ole Troan <ot@cisco.com>

mactime: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I034cc6fb2a12d1b43b3470a1ba39cc1fe020386a

dba00cad 29-Sep-2019 Benoît Ganne <bganne@cisco.com>

stats: fix per-worker stat vector length

Type: fix

Change-Id: I198a2312f5fc6e922c8a6c51ba7248ce6e236f81
Signed-off-by: Benoît Ganne <bganne@cisco.com>

bb5ff4e4 30-Sep-2019 Benoît Ganne <bganne@cisco.com>

hsa: fix non-NULL terminated C-string use in echo

Use '%v' format for non-NULL terminated vectors instead of '%s'.

Type: fix

Change-Id: Id83de52486ad8dad3cdf3f32dad63a223fc1fdf7
Signed-off-by: Benoît Ganne <bganne@cisco.com>

19e52c96 30-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: Fix missing elt regrab

Type: fix

Change-Id: Ie756c5477d989702e633aa0d42ca154ff32b4c9a
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

ee98904e 25-Sep-2019 Ole Troan <ot@cisco.com>

ct6: remove api boilerplate

Type: refactor
Change-Id: Ibf00279d8065e7ef4fc06e8b9946dcc7bfd647de
Signed-off-by: Ole Troan <ot@cisco.com>

0aa35a7f 27-Sep-2019 Ole Troan <ot@cisco.com>

l2e: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifca5eee01b7813ddb6a8e4510f3adb96ade55fa7

01d61e78 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

ipsec: add insecure option for format of SA

If specified, shows keys, otherwise redacts. This change sets this flag
in the existing CLI code (thus maintaining the old behavior). The use
case for not specifying the insecure flag (and thus redacting the keys
from the show output) is for log messages.

Type: feature
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I8c0ab6a9a8aba7c687a2559fa1a23fac9d0aa111

5a242638 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

ipsec: allow null cipher with dpdk esp

The NULL cipher is a (valid) non-AEAD choice for ESP encrypt path.
Allow it.

Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: I6d8b66223a0ffb0952c2dd6fa898a8a2289fef7a

9a5aab34 27-Sep-2019 Christian E. Hopps <chopps@chopps.org>

ipsec: fix memleaks in ikev2 openssl code

- Need to always free created contexts
- Always pair init with cleanup for older openssl API.

Type: fix
Signed-off-by: Christian E. Hopps <chopps@chopps.org>
Change-Id: Ie8840403bcac500c20085d57240401ad39d119f8

18512b00 27-Sep-2019 jaszha03 <jason.zhang2@arm.com>

vppinfra: implement CLIB_PAUSE () for aarch64 platforms

Define CLIB_PAUSE () to generate the "yield" instruction. No significant
performance changes were observed for clib_spinlock_t and clib_rwlock_t.

Type: feature

Change-Id: I59eb996e61c7a16007517e57e6996567302c1657
Signed-off-by: Jason Zhang <jason.zhang2@arm.com>
Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com>

b325983a 27-Sep-2019 Neale Ranns <nranns@cisco.com>

ipsec: support 4o6 and 6o4 for tunnel protect

Type: feature

Change-Id: Ib2352ca4c7abf4645f21fa16aaaf27408890a2bf
Signed-off-by: Neale Ranns <nranns@cisco.com>

35174b42 27-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: fix io_evt mq locking

Type: fix

Change-Id: Iaa8045bba19cc305c84074668a20e1468d431b10
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

694ec926 27-Sep-2019 Ole Troan <ot@cisco.com>

l3xc: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iea808fcdbf97cb78a2e2805002d3e2333279cb89

4540b2f8 27-Sep-2019 Ole Troan <ot@cisco.com>

lacp: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I5b77da8e9c476bd784be087a53b2eafb2d1a4831

941185ae 27-Sep-2019 Ole Troan <ot@cisco.com>

svs: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I08eab052b67893cc6633d235885438e69950904b

fc7b77db 27-Sep-2019 Ole Troan <ot@cisco.com>

ikev2: remove api boilerplate

Type: refactor
Change-Id: Ib46ed3e65e75a97995a3e251d87324fec6595024
Signed-off-by: Ole Troan <ot@cisco.com>

087d6c67 27-Sep-2019 Ole Troan <ot@cisco.com>

sctp: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I6576b76ef7ba494a8b777d01d75055270d837b24

83c1e9a3 21-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

tests: add quic plugin qclose/sclose tests

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I3122b038f7d77c7e5e8ee7c24046da6c94ca2d2c

51e70b6f 25-Sep-2019 Ole Troan <ot@cisco.com>

builtinurl: remove api boilerplate

Type: refactor
Change-Id: Iaf728642e489acfd63e1da88aa8daa44ceca21e9
Signed-off-by: Ole Troan <ot@cisco.com>

1bc96680 25-Sep-2019 Ole Troan <ot@cisco.com>

cdp: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I3b4bbbf2574faf8d06546eb72f127fa47479e988
Signed-off-by: Ole Troan <ot@cisco.com>

74af6f08 25-Sep-2019 Ole Troan <ot@cisco.com>

avf: remote api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Iafa1c0d0c1195f88b1a55f0341459c3278c3b2e6
Signed-off-by: Ole Troan <ot@cisco.com>

7eef62b6 27-Sep-2019 Ole Troan <ot@cisco.com>

igmp: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I578b09ec223c8e4a04b7590b55354b1104ac6628

83a49e12 27-Sep-2019 Ole Troan <ot@cisco.com>

http_static: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie1f0cccf0c9dc4c0d8ae1e1b5d8e6a75c325d1ce

49228efc 27-Sep-2019 Ole Troan <ot@cisco.com>

gtpu: remove api boilerplate

Type: refactor
Change-Id: I08d200fbec805af3109e738eee32c3ecfd61c7cc
Signed-off-by: Ole Troan <ot@cisco.com>

5c71a2e5 27-Sep-2019 Ole Troan <ot@cisco.com>

gbp: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I2995413619f5fbe77bbe2df9f5d37db8cc596b73

b922f16b 27-Sep-2019 Ole Troan <ot@cisco.com>

dns: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ifffa86b45dd1f213ba974a296ab64202b672a6df

9f3d2117 25-Sep-2019 Ole Troan <ot@cisco.com>

abf: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I80a371baf7715de1acee90952a0dd270172d8538
Signed-off-by: Ole Troan <ot@cisco.com>

d6a72f86 25-Sep-2019 Ole Troan <ot@cisco.com>

acl: remove api boilerplate

Type: refactor
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I5701b7d6d5e1423fb0004f7e48815cd672f81e4d

f5667c30 25-Sep-2019 Dave Barach <dave@barachs.net>

misc: add vnet classify filter set support

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I79b216d2499df143f53977e5b70382f6f887e0bc

2d0ebd7e 19-Jul-2019 Benoît Ganne <bganne@cisco.com>

ip: fix use-after-free in reassembly

- ip{4,6}_reass_finalize() frees the reassembly context: do not access
it after the call.
- traces access reassembly context: free it after and not before
tracing.

Type: fix

Change-Id: Ia3aaea9c7b74932e249e013be04b9bd7298fd187
Signed-off-by: Benoît Ganne <bganne@cisco.com>

a025b3ea 21-Aug-2019 Klement Sekera <ksekera@cisco.com>

map: use SVR for MAP-E

This change is part of an effort to unify reassembly code. By removing
shallow virtual reassembly functionality in MAP and using the common
vnet provided shallow virtual reassembly, code size and complexity is
reduced.

Type: refactor
Change-Id: I431f47d4db97154fecaeaecd6719cfc3b83cfc4a
Signed-off-by: Klement Sekera <ksekera@cisco.com>

de34c35f 25-Jun-2019 Klement Sekera <ksekera@cisco.com>

ip: add shallow virtual reassembly functionality

Type: feature

Change-Id: Ibc8334e26c7e6f6120696c3e313b6e11d73dab99
Signed-off-by: Klement Sekera <ksekera@cisco.com>

33538a15 09-Sep-2019 Hongjun Ni <hongjun.ni@intel.com>

lb: add APIs for set interface nat4 and nat6

Type: feature

Change-Id: I5656cd798b108dd780381b87f574554442ed7b23
Signed-off-by: Hongjun Ni <hongjun.ni@intel.com>

83049339 24-Sep-2019 Damjan Marion <damarion@cisco.com>

classify: use vector code even when data is not aligned

Type: feature

Change-Id: I8f5f4841965beb13ebc8c2a37ce0dc331c920109
Signed-off-by: Damjan Marion <damarion@cisco.com>

6eb009ac 20-Sep-2019 Vratko Polak <vrpolak@cisco.com>

lb: vl_api_lb_conf_t_handler has to ntohl

As requested in review, this is a minimal edit.
Refactor comes as a separate Change.

Type: fix

Change-Id: Ie3bdfc3cfde4bfee56848217133ca5f6bbccaeef
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

df40cb5b 25-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

devices: pipe API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ifd62207048d125bec18b3a728590ac540dcafe5e

769145cd 06-Mar-2019 Klement Sekera <ksekera@cisco.com>

ip: respect buffer boundary when searching for ipv6 headers

Type: fix

Change-Id: I5a5461652f8115fa1270e20f748178fb5f5450f2
Signed-off-by: Klement Sekera <ksekera@cisco.com>

8fadb658 24-Sep-2019 Aloys Augustin <aloaugus@cisco.com>

udp: do not send received packets to error-drop

This tends to pollute the error counter.

Type: fix
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Change-Id: Idb628e767b074a5ee7e00d001bc88c378d7b8d0b

e1e7fb88 25-Sep-2019 Florin Coras <fcoras@cisco.com>

session: validate connection in session lookup del

Type: fix

Change-Id: I4e2617f99064c5a96e4debae8b68716ca129ee73
Signed-off-by: Florin Coras <fcoras@cisco.com>

36ebcfff 13-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: use sacks for timer based recovery

Type: feature

If available, reuse sack scoreboard in timer triggered retransmit to
minimize spurious retransmits.

Additional changes/refactoring:
- limited transmit updates
- add sacked rxt count to scoreboard
- prr pacing of fast retransmits
- startup pacing updates
- changed loss window to flight + mss

Change-Id: I057de6a9d6401698bd1031d5cf5cfbb62f2bdf61
Signed-off-by: Florin Coras <fcoras@cisco.com>

54c93cfc 24-Sep-2019 Florin Coras <fcoras@cisco.com>

session: fix cleanup in closing states

Type: fix

Change-Id: Iccc283bb98d3bb459a711ec2b74d6a32ad12903b
Signed-off-by: Florin Coras <fcoras@cisco.com>

2a1ca787 18-Sep-2019 Ole Troan <ot@cisco.com>

api: split api generated files

Split generation of API message enum and the typedefs into
separate files, so that the type file can be included from
elsewhere.

Generate a C file for VPP that contains the API registration,
this was previously done via X macros by the C pre-
processor.

This allows deleting lots of skeleton/copy paste code
for each feature.

plugins/flowprobe
plugins/map
examples/sample-plugin
vnet/ipip
used as Guinea pigs.

Generate a C Test file for VAT, that does the same for VAT plugins.
Also add support for a per-message CLI option, that is currently
limited to VAT help text. option vat_help = "<help text>";

Type: refactor
Change-Id: I245e3104bb76f7e1fb69a59ab20cc7c8dfcdd460
Signed-off-by: Ole Troan <ot@cisco.com>

33af8c1e 16-Sep-2019 Lijian.Zhang <Lijian.Zhang@arm.com>

fib: fix some typos in fib/mtrie

Type: fix

Change-Id: I1af0e4a9bc23a3b6b6d3a74df093801ab6cae1f8
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>

896c896a 24-Jun-2019 Klement Sekera <ksekera@cisco.com>

ip: refactor reassembly

this is a preparation step for introducing other reassembly types

Type: refactor

Change-Id: I197e299dbd729b00eead31667913b8ceff915d63
Signed-off-by: Klement Sekera <ksekera@cisco.com>

5e2f84d2 12-Sep-2019 Klement Sekera <ksekera@cisco.com>

papi: truncate long logger messages

Dumping whole cli_inband output causes huge unformatted messages written
to logger, so truncate these to avoid that.

Type: fix

Change-Id: I59565a98e3595cbfe4971cc346e104cb198d8f24
Signed-off-by: Klement Sekera <ksekera@cisco.com>

7ca5aaac 24-Sep-2019 Damjan Marion <damarion@cisco.com>

vlib: add flag to explicitelly mark nodes which can init per-node packet trace

Type: feature

Change-Id: I913f08383ee1c24d610c3d2aac07cef402570e2c
Signed-off-by: Damjan Marion <damarion@cisco.com>

be7ef3b5 24-Sep-2019 Damjan Marion <damarion@cisco.com>

build: pass 'no-pci' to autgenerated config

Avoid aggresive hiijack of pci interfaces when 'make run' and
'make run-release' are used and there is no startup.conf present.

Type: feature

Change-Id: Id653b5f9ac3d2935a40299885e616960e75d4a95
Signed-off-by: Damjan Marion <damarion@cisco.com>

cac31a4a 24-Sep-2019 Florin Coras <fcoras@cisco.com>

session: avoid transport cleanup if previously deleted

Type: fix

Change-Id: I485d38c7d9473e2ad1cbd8e17a788ec8d29ab001
Signed-off-by: Florin Coras <fcoras@cisco.com>

9382ad9b 23-Sep-2019 Dave Barach <dave@barachs.net>

misc: improve pcap drop trace output

Append <nodename>: <error-string> to pcap drop traces.

The data displays perfectly fine in [vanilla] wireshark, and makes it
100% obvious which node dropped the packet, and why.

Type: feature
Ticket: VPP-1776

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I9b964b99da4011b93723354db6ef0b128fca20cb

d5ade023 21-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

tests: fix test-checkstyle to check plugin tests

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I93eb0ae4338247fa2479f8e419483d1593436dc7

33909777 23-Sep-2019 Dave Barach <dave@barachs.net>

misc: unify pcap rx / tx / drop trace

Use a single vnet_pcap_t in vlib_global_main, specifically to support
unified tracing

Update sphinx docs, doxygen tags

Type: refactor
Ticket: VPP-1776

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id15d41a596712968c0714cef1bd2cd5bc9cbdd55

44ca60ec 06-Sep-2019 Benoît Ganne <bganne@cisco.com>

gbp: fix contract rule handling

Fix a memory leak when removing old GBP contract rules and make sure a
GBP contract rule exists when matching the corresponding ACL rule.

Type: fix
Fixes: 13a08cc098

Change-Id: Iba67d573e69280ad998488a7a3d3462341c68ea4
Signed-off-by: Benoît Ganne <bganne@cisco.com>

1df833e6 23-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: fix unformat cwnd multiplier

Type: fix

Change-Id: Ife4e650cb8b16f84ca6f77ba7b1d17a0f452fc3f
Signed-off-by: Florin Coras <fcoras@cisco.com>

bb73ae7b 23-Sep-2019 MathiasRaoul <mathias.raoul@gmail.com>

hsa: fix typo in vpp_echo for tx-buf

fix typo and allow use of Gb, Mb or Kb for tx/rx-buf sizes

Type: fix

Change-Id: I2cfd4c09d6b14dd5c744d942eea09ca9ddcc0f46
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

6c57a4a9 20-Aug-2019 Dmitry Vakhrushev <dmitry@netgate.com>

nat: fix update of outside fibs (output-feature)

NAT hasn't worked when NAT interfaces wasn't in
default VRF (fib_index = 0). This issue has been occurred with
interfaces with output-feature in endpoint-dependent mode.

Update VAT commands:
- update nat44_add_del_address_range
- add nat44_interface_add_del_output_feature

Ticket: VPP-1732
Type: fix

Change-Id: Iddea15dde4b948f159a0056d48c55bd917037fd1
Signed-off-by: Dmitry Vakhrushev <dmitry@netgate.com>

4da1506d 11-Sep-2019 Andrew Yourtchenko <ayourtch@gmail.com>

interface: use the correct condition for checking if the pcap fd is open

The 9af7e2e87e used a comparison that fd is >= 0 to check that
the pcap needs closing. While the pcap_close() function does
reset the file descriptor to -1, the freshly initialized structure
has it equal to 0.

This causes the VPP to close stdin if the packets are being seen
on pg interface without the capture file being opened.
This triggers the vpp attempting to read from STDIN
(another bug), which results in running out of memory.

Change-Id: I11d61422701500a9b3e0dd52d59383f297d57f54
Type: fix
Fixes: 9af7e2e87e
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

1c887d93 08-Aug-2019 juraj.linkes <juraj.linkes@pantheon.tech>

ebuild: Add MAKE_PARALLEL_FLAGS to VPP build

Align with other packages.

Type: make

Change-Id: I3c8f5c6a349ce9d4e05f546945ae2d8dcf3b1b61
Signed-off-by: juraj.linkes <juraj.linkes@pantheon.tech>

b28a81e2 23-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

api: add missing format_vl_api_ip[46]_address_with_prefix_t

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Iad7067962b1dd8d3a1335f07e89a62f901e82dff

138c37af 18-Jul-2019 Benoît Ganne <bganne@cisco.com>

fib: do not dump no-longer valid adjacencies

In some cases, we can refer to no-longer adjacencies (eg. in traces). Do
not dump them in this case as they are probably incorrect (memory can be
reused).

Type: fix

Change-Id: Ib653ba066bb6595ec6ec37d313a3124bce0eeed3
Signed-off-by: Benoît Ganne <bganne@cisco.com>

d51880c5 03-Sep-2019 Benoît Ganne <bganne@cisco.com>

gbp: remove loopback interfaces between tests

Type: fix

Change-Id: I440f25b95b23b717518d101a1327ecf16d6ba39a
Signed-off-by: Benoît Ganne <bganne@cisco.com>

6d5f6592 18-Sep-2019 Matthew Smith <mgsmith@netgate.com>

ip: fix memory leak in ip_dump handler

Type: fix

A vector allocated by vl_api_ip_dump_t_handler() was not being
freed.

Change-Id: I13425b8087e60df60c6aaa1230aa7e6d60b101a8
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

1afa7aff 13-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: fix msg freeing on error

Type: fix

Change-Id: I0807f84737d5e98e69e9ed27a1de6813b2ddd138
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

afef8bf2 12-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: refactor congestion event handling

Type: refactor

Minor cleanup to congestion event handling.

Change-Id: I7179ff9e21c1853382ba814652c9024f3e5b8a37
Signed-off-by: Florin Coras <fcoras@cisco.com>

9137e540 13-Sep-2019 Dave Barach <dave@barachs.net>

misc: classifier-based packet trace filter

See .../src/vnet/classify/trace_classify.h for the business end
of the scheme.

It would be best to hash pkts, prefetch buckets, and do the primary
table lookups two at a time. The inline as given works, but perf
tuning will be required. "At least it works..."

Add "classify filter" debug cli, for example:
classify filter mask l3 ip4 src dst \
match l3 ip4 dst 192.168.2.10 src 192.168.1.10

Add "pcap rx | tx trace ... filter" to use the current classify filter chain

Patch includes sphinx documentation and doxygen tags.

Next step: device-driver integration

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I05b1358a769f61e6d32470e0c87058f640486b26

864d857c 19-Sep-2019 Damjan Marion <damarion@cisco.com>

classify: remove includes from classifier header file

Type: refactor

Change-Id: I6f0af1c3078edce1c1b29a8b99c4a232d7084d33
Signed-off-by: Damjan Marion <damarion@cisco.com>

0e402a98 19-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: refactor vpp_echo failure handling

- Return unique value for each failure condition
- Last failure value returned
- All failures included in description
- Output failure value and description

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I72d5e7f660ad4765c468874421622607af6ae3d1
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

4e323cbd 17-Sep-2019 Benoît Ganne <bganne@cisco.com>

interface: fix pcap drop trace in case of vlan

Type: fix

Change-Id: If3c4e5c376b51a26143d8922dcacfbda534163bd
Signed-off-by: Benoît Ganne <bganne@cisco.com>

5c29029e 19-Sep-2019 Florin Coras <fcoras@cisco.com>

session: builtin app rx notifications regardless of state

Type: feature

Provide rx notifications to builtin apps even after disconnect.
Consequently tcp connections that are past FIN_WAIT_1 can still receive
rx notifications.

This is not currently supported for external applications.

Change-Id: I529da7f7120b0e7c62c5026ac71f86d6b5196cf4
Signed-off-by: Florin Coras <fcoras@cisco.com>

de2dd6c3 18-Sep-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: add support for GCM cipher

Type: feature
Change-Id: Ic703015b55f0ae947e5e44b10b74b3c79efe7da6
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

aa4438a3 03-Apr-2019 Jakub Grajciar <jgrajcia@cisco.com>

cop: API cleanup

Use consistent API types.

Type: fix

Change-Id: I6ac453c88628a4dbb08b03c408df09b91b1ea5ca
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

75761b93 11-Sep-2019 Ole Troan <ot@cisco.com>

api: split vl_api_prefix into two

One type for address with prefix and one type for prefix.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Icfec51d9b7d5cde1d69fbecdd97498688ab7b295
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>

fbc38898 09-Sep-2019 Andrew Yourtchenko <ayourtch@gmail.com>

tests: split up the long running IPSec tests into separate classes

Type: test
Change-Id: Ieeae7f1653f5f2e8e49f258871b389ef8954c90b
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

789ac9de 17-Sep-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: fix vpp_echo stats output

- Output stats when there are missing timing events
- Add missing timing event status to the stats output

Type: fix

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I10a8db6db9568b98379df544d0098f9722a44867

d5a78a53 17-Sep-2019 Ole Troan <ot@cisco.com>

vppapigen: fix missing vla check for union class

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ie775cf3469d761847ac39cf0d80a3ec6463b7928

a41b0b78 18-Sep-2019 Ole Troan <ot@cisco.com>

stats: fix per_worker vector rate heap

The per_worker counters were outside of the stats heap.
Also fixes the length of the per_vector counter.
A simple vector is two dimensional including a thread dimension.

Fixes: f89a6de8f0
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I370bf9cb033d264f42df2723e01b768dc270792b

b28349e8 17-Sep-2019 MathiasRaoul <mathias.raoul@gmail.com>

quic : refactor function naming

- functions renaming to be consistent with the other plugin functions name
- removing useless logs

Type: style

Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>
Change-Id: Iea212a799448975e01a92f16cc329de13907ff07
Signed-off-by: MathiasRaoul <mathias.raoul@gmail.com>

7436b436 11-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: compute snd time for rate sample

Type: feature

Change-Id: I6bd675dc28dbc34293e895911efe986844c0564f
Signed-off-by: Florin Coras <fcoras@cisco.com>

43765e2b 17-Sep-2019 Dave Barach <dave@barachs.net>

builtinurl: initial working attempt

Note that the builtin URLs are disabled by default. To activate,
"builtinurl enable" or use the builtinurl_enable API.

See .../extras/http/sample.md for some Hugo-friendly .md w/ embedded
Javascript that accesses the builtin URLs.

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I6d82d9292c41d6d2d90be73ba8a1a043fb20c986

4bf84904 31-Jul-2019 Paul Vinciguerra <pvinci@vinciconsulting.com>

vppapigen: fix tests and run on verify

- changes vppapigen to only process an import once.

Type: fix

Change-Id: Ifcbcfcc69fdfb80d63195a17701762d0c239d7b4
Signed-off-by: Paul Vinciguerra <pvinci@vinciconsulting.com>
Signed-off-by: Ole Troan <ot@cisco.com>

c63c0166 17-Sep-2019 Ed Kern <ejk@cisco.com>

build: fix rpm python 3 depends

Type: fix

Change-Id: Ie6eaccb27779bb14c0a23764a16cd22f0a72e379
Signed-off-by: Ed Kern <ejk@cisco.com>

7c8f828b 15-Sep-2019 Florin Coras <fcoras@cisco.com>

session: limit pacer bucket size

Type: feature

Change-Id: I3ca27b09670716eba463d7b16771f765a1bd6dcd
Signed-off-by: Florin Coras <fcoras@cisco.com>

735d2e20 16-Sep-2019 Aloys Augustin <aloaugus@cisco.com>

vlib: fix cli process stack overflow

Some cli processes, including bringing up an i40e interface with dpdk,
consume more than the currently available stack space.

Type: fix
Fixes: VPP-1774
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Change-Id: I86ceb9e6e07523d5e0f760b5922467f09a8d4006

1dbda64b 11-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: use rate sample rtt in recovery if possible

If in recovery and rate samples are taken for burts that have not been
retransmitted, use the rtt estimate.

Type: feature

Change-Id: I95028f492008457c959157aa4ee4c3435fa9c3f0
Signed-off-by: Florin Coras <fcoras@cisco.com>

5554c56a 12-Sep-2019 Dave Barach <dave@barachs.net>

http_static: add dynamic GET / POST method hooks

Add .json output to format_vnet_sw_interface_cntrs(...)

Type: feature

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ied036ebfaaafbf1dfc2a4e396c00f09f40659400

da9513af 06-Sep-2019 Damjan Marion <damarion@cisco.com>

dpdk: initialize rte_mbuf during mempool dequeue

In some cases it may happen that buffer is allocated by DPDK, and freed
by VPP native code. In such cases dpdk metadata is not reset, so we need
to do that during mempool dequeue. Template approach is taken to reduce
cost of that operation.

Type: fix
Fixes: 910d369

Change-Id: Ic239007cfc8fbceb965021c56963cda9d53f63be
Signed-off-by: Damjan Marion <damarion@cisco.com>

67e4df14 16-Aug-2019 Hiroki Shirokura <slank.dev@gmail.com>

vlib: cli support ctrl-w to erase left word

Type: fix
Signed-off-by: Hiroki Shirokura <slank.dev@gmail.com>
Change-Id: I3ae7dc3858d0353764d629d6a9eff2bdab5f8768

33a58171 04-Sep-2019 Ole Troan <ot@cisco.com>

api: autogenerate api trace print/endian

In addition to the external vppapitrace tool, VPP itself supports dumping of API trace files.
In two formats, "custom-dump" and "dump". "dump" gives a human friendly list,
and "custom-dump" is meant to give a list of commands that can be fed to VAT.
This patch only deals with "dump".
Prior to this fix, auto-generation was only done for the basic types.
This fix adds support for any type, including lists, and supports pretty-printing
of enums, strings, IP addresses, MAC addresses and so on.

Usage: api trace dump <api-trace-file>

For example

Change-Id: I4e485680e6dcfce7489299ae6cf31d835071ac40

---------- trace 48 -----------
vl_api_sw_interface_set_flags_t:
_vl_msg_id: 75
client_index: 0
context: 10
sw_if_index: 1
flags: IF_STATUS_API_FLAG_ADMIN_UP
---------- trace 49 -----------
vl_api_sw_interface_add_del_address_t:
_vl_msg_id: 88
client_index: 0
context: 11
sw_if_index: 1
is_add: 1
del_all: 0
prefix: 172.16.1.1/24
---------- trace 51 -----------
vl_api_cli_inband_t:
_vl_msg_id: 819
client_index: 0
context: 13
cmd: packet-generator capture pg0 pcap /tmp/vpp-unittest-TestMAP-YhcmDX/pg0_out.pcap disable
---------- trace 58 -----------
vl_api_ip_neighbor_add_del_t:
_vl_msg_id: 199
client_index: 0
context: 20
is_add: 1
neighbor:
sw_if_index: 2
flags: IP_API_NEIGHBOR_FLAG_NONE
mac_address: 0202.0000.ff02
ip_address: fd01:2::2

Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: I5556d06008de2762e7c2d35a8b0963ae670b3db1
Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Ole Troan <ot@cisco.com>

1292d19c 13-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

session: add session enable option in config file

Type: feature

Change-Id: I8f02873e75c6e890f6749806d4f02547f951c8ca
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

a786687a 12-Sep-2019 Aloys Augustin <aloaugus@cisco.com>

hsa: Fix QUIC sessions count calculation

Type: fix
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>
Change-Id: Ia53a41a30920f8af7cd00c6f809b32e7cc277b7a

bf02d6f4 13-Sep-2019 Damjan Marion <dmarion@me.com>

devices: partial revert of af_packet API cleanup patch

Reverting as make test must me able to run non-root so creating tap interfaces is no-go.

Type: fix
Fixes: 3b2db9002c14f9e0742622f2d503c5801d443827

Change-Id: Ib6eb2679b65b662ed6e88e67f8b199744abae85e
Signed-off-by: Damjan Marion <dmarion@me.com>

321cfa5f 13-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: cleanup scoreboard after recovery

Type: fix

When recovering from congestion, remove last hole in scoreboard if it
covers all bytes sent above snd_congestion.

Change-Id: I752accd4590cd9bf553c35a1bb40a38c308c04f5
Signed-off-by: Florin Coras <fcoras@cisco.com>

3b2db900 26-Aug-2019 Jakub Grajciar <jgrajcia@cisco.com>

devices: af_packet API cleanup

Use consistent API types.

- fix af_packet_dump dumping deleted interface

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Ie8d138e30c8c51a2306bb2ad9ac0b7a49d5412bf
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

3c7c613c 11-Sep-2019 Benoît Ganne <bganne@cisco.com>

map: fix non-null-terminated C-string

Type: fix

Change-Id: Ia3a4693acd5eab234f60b37436c5b642b00bda46
Signed-off-by: Benoît Ganne <bganne@cisco.com>

7fd40216 12-Sep-2019 Elias Rudberg <elias.rudberg@bahnhof.net>

dpdk: fix null-termination of strings

Fix problem with some strings not being null-terminated,
by using the vec_terminate_c_string macro in two places.
The problem was found using AddressSanitizer.
(Also make sure indentation is OK for those changes.)

Ticket: VPP-1772
Type: fix

Signed-off-by: Elias Rudberg <elias.rudberg@bahnhof.net>
Change-Id: Ib7826e3c322e58b649e2d7f6053786da618a5e9e

58519563 11-Sep-2019 Benoît Ganne <bganne@cisco.com>

hsa: fix memory management bugs

Fix use-after-free and non-null terminated string.

Type: fix

Change-Id: Ibba2a6cae68c612a34477aa813b3bf27a0c8fc1f
Signed-off-by: Benoît Ganne <bganne@cisco.com>

6d6456ab 11-Sep-2019 Benoît Ganne <bganne@cisco.com>

quic: fix use-after-free

Type: fix

Change-Id: I5e5e37684e336ca992dae8ea1d39b1fb103802b1
Signed-off-by: Benoît Ganne <bganne@cisco.com>

b0876964 11-Sep-2019 Steven Luong <sluong@cisco.com>

misc: bond_create is broken for custom dump print

Regression from https://gerrit.fd.io/r/#/c/vpp/+/21508/
The aformentioned patch changed lb and mode to u32. But it does not make the
same change to custom_dump.c

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I2b7d065e21427090af3deb47c8a24c5da679e4f5

b840c773 10-Sep-2019 Benoît Ganne <bganne@cisco.com>

quic: fix non-null terminated hostname string

Type: fix

Change-Id: I089d359d5726050f32f69366547086216fdb3098
Signed-off-by: Benoît Ganne <bganne@cisco.com>

8b1c7f34 11-Sep-2019 jdenisco <jdenisco@cisco.com>

docs: run-sphinx-docs-merged

Type: docs

Signed-off-by: jdenisco <jdenisco@cisco.com>
Change-Id: I571222f3e3672253930700e23cca4812dde84a6d

86b1871b 08-Jul-2019 Lijian.Zhang <Lijian.Zhang@arm.com>

ip: apply dual loop unrolling in ip4_input

Too many prefetches within loop unrollings induce bottleneck and
performance degradation on some CPUs which have less cache line fill
buffers, e.g, Arm Cortex-A72.
Apply dual loop unrolling and tune prefetches manually to resolve
hot-spot with prefetch instructions.
It saves about 11.5% cycles with ip4_input node on Cortex-A72 CPUs.

Type: feature

Change-Id: I1ac9eb21061a804af2a414b420217fbcda3689c9
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>

840f64b4 09-Jul-2019 Lijian.Zhang <Lijian.Zhang@arm.com>

ip: apply dual loop unrolling in ip4_rewrite

Too many prefetches within loop unrollings induce bottleneck and
performance degradation on some CPUs which have less cache line fill
buffers, e.g, Arm Cortex-A72.
Apply dual loop unrolling and tune prefetches manually to remove
hot-spot with prefetch instructions, to get throughput improvement.
It brings about 7% throughput improvement and saves 28% clocks with
ip4_rewrite nodes on Cortex-A72 CPUs.

Type: feature

Change-Id: I0d35ef19faccbd7a5a4647f50bc369bfcb01a20d
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>

fe2523d1 11-Jul-2019 Lijian.Zhang <Lijian.Zhang@arm.com>

dpdk: apply dual loop unrolling in DPDK TX

Too many prefetches within loop unrollings induce bottleneck and
performance degradation on some CPUs which have less cache line fill
buffers, e.g, Arm Cortex-A72.
Apply dual loop unrolling and tune prefetches manually to remove
hot-spot with prefetch instructions, to get throughput improvement.
It brings about 1% throughput improvement and saves 8% clocks with
the target node on Cortex-A72.

Type: feature

Change-Id: If3a64a04a77e90cd0240bc4d1186dbb09dac7df0
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>

8a1dea4c 11-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

memif: fix zero-copy arg overwrite

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I9a34465c85597baecdbc672ce395265f7dbb7f00

3d1ef873 25-Aug-2019 Jakub Grajciar <jgrajcia@cisco.com>

bonding: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: Idbba4ab6a412b75338e3149e51476693f0862f16
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

558e3e09 06-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: handle sack reneging

Type: feature

Change-Id: I201155b1b92cf7e57310af726879dab039090582
Signed-off-by: Florin Coras <fcoras@cisco.com>

082ebeba 09-Sep-2019 jialv01 <Jianlin.Lv@arm.com>

build: fix running error with vmxnet3_test_plugin.so

vpp_api_test load vmxnet3_test_plugin.so error:
"load_one_plugin:42:/vpp/lib/vpp_api_test_plugins/vmxnet3_test_plugin.so:
undefined symbol: unformat_vlib_pci_addr"

Type: fix

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Change-Id: I444aa05d0bc3c4f4f25082388243f1adb305dd0a

1146ff4b 02-Sep-2019 Simon Zhang <yuwei1.zhang@intel.com>

tcp: enable gso in tcp hoststack

Type: feature

Change-Id: If68d07fbe8c6f7fffd2f93c7e854367082927e4f
Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>

b97641c7 09-Sep-2019 Dave Barach <dave@barachs.net>

misc: clean up "pcap [rx|tx] trace" debug CLI

Separate debug CLI arg parsing from the underlying action
function. Fixes a number of subtle ordering dependencies, and will
allow us to add a binary API to control the feature at some point in
the future.

Type: refactor
Ticket: VPP-1770

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Id0dbeda06dad20e756c941c691e2088ce3c50ec7

61a89f2b 10-Sep-2019 Florin Coras <fcoras@cisco.com>

session: fix session filter range

Type:fix

Change-Id: I173f45bf3d90e6979675b2ac812a969539f02147
Signed-off-by: Florin Coras <fcoras@cisco.com>

78dae008 30-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: validate connections in output

Type: feature

This shouldn't happen unless connections are removed after buffers were
enqueued to tcp-output and before tcp-output runs. For instance, packet
is enqueued to tcp output and cleanup is called for connection.

Change-Id: Ib7dd82ffa6cfb21ff5068aba010e0a3497eeea13
Signed-off-by: Florin Coras <fcoras@cisco.com>

5c2f9643 09-Sep-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

misc: fix shebang with missing env

This is needed for macos where /usr/bin/python[23] does not exist
and /usr/bin is write protected

Type: fix

Change-Id: Ia1b3c732248c78482993de532fa2ea96e376d90a
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

2f6e0c60 06-Sep-2019 Vratko Polak <vrpolak@cisco.com>

papi: let async calls return context

Callback receives "reply" messages containing context,
but previously there was no easy way
to get the automatically generated context value
of the originally sent "command" message.

With this, the caller can store the contexts,
so the callback knows which command got replied to.

Type: feature

Change-Id: I58ca812d20b03916f74096c396126710115a747c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

a287a30d 09-Sep-2019 Dave Barach <dave@barachs.net>

misc: fix coverity warning in the oddbuf plugin

Clean up license / copyright headers

Type: fix
Ticket: VPP-1771

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ibfc2a46632e17578fd74357b83f417987b8447be

5b786fb8 09-Sep-2019 Dave Barach <dave@barachs.net>

docs: improve unformat documentation

Specifically: document the unformat specifiers "%=", "%|", and correct
usage of unformat_line_input.

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I254f9c4a61c5c8d3edbf76f521e5f38fb89150f1

546f955b 21-Aug-2019 Jakub Grajciar <jgrajcia@cisco.com>

memif: API cleanup

Use consistent API types.

memif_create now enables zero-copy by default.
Add no_zero_copy param to memif_create which
if set, disables zero copy.

Type: refactor

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I11df8b9212c40de179ee71dc9da14039b982ede5
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

bdf3ebe3 09-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

libmemif: prevent crash in case of invalid connection handle

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I803c86a48e0148ef143026a5cd93e4510c4f0611
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

e5948fb4 29-Aug-2019 Dave Barach <dave@barachs.net>

vlib: clean up the "pcap dispatch trace" debug CLI

Separate debug CLI arg parsing from the underlying action
function. Fixes a number of subtle ordering dependencies, and will
allow us to add a binary API to control the feature at some point in
the future.

Type: refactor
Ticket: VPP-1762

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I1240fe3f61a0acf5ee9faed60d6ad3386e72e569

c4abafd8 04-Sep-2019 Dave Barach <dave@barachs.net>

ip: fix udp/tcp checksum corner cases

When checksumming chained buffers with odd lengths: insert a
NULL byte, or the calculation fails.

Type: fix

Signed-off-by: Dave Barach <dave@barachs.net>
Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I380f7c42897bdb28c8c29aa1c4cdaaa849cc9ecc

b736e75d 04-Sep-2019 Filip Tehlar <ftehlar@cisco.com>

ikev2: fix crash during IKE SA Init exchange

Type: fix

Change-Id: If827fe348fe35d1221d29f91b7e6ea1624d13999
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

a1876b84 20-Aug-2019 Steven Luong <sluong@cisco.com>

bonding: add weight support for active-backup mode

Not all interfaces have the same characteristics within the bonding group.
For active-backup mode, we should do our best to select the slave that
performs the best as the primary slave. We already did that by preferring
the slave that is local numa. Sometimes, this is not enough. For example,
when all are local numas, the selection is arbitrary. Some slave interfaces
may have higher speed or better qos than the others. But this is hard to
infer.

One rule does not fit all. So we let the operator to optionally specify the
weight for each slave interface. Our primary slave selection rule is now
1. biggest weight
2. is local numa
3. current primary slave (to avoid churn)
4. lowest sw_if_index (for deterministic behavior)

This selection rule only applies to active-backup mode which only one slave
is used for forwarding traffic until it becomes unreachable. At that time,
the next "best" slave candidate is automatically promoted. The slaves are
sorted according to the preference rule when they are up. So there is no need
to find the next best candidate when the primary slave goes down.

Another good thing about this rule is when the down slave comes back up, it
is selected as the primary slave again unless there is indeed a "better"
slave than this down slave that were added during that period.

To set the weight for the slave interface, do this after the interface is
enslaved

set interface bond <interface-name> weight <value>

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I59ced6d20ce1dec532e667dbe1afd1b4243e04f9

ffbfe3a2 05-Sep-2019 Aloys Augustin <aloaugus@cisco.com>

quic: fix server opening stream immediately

Previously, if the first thing a server did was to open a stream and
send data, this could trigger a crash on the clilent side VPP as the
quic session wouldn't be allocated.

Change-Id: I43990ce2a71217d6719ecae4da60111d05fbcfc0
Type: fix
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>

a069762e 05-Sep-2019 Mohsin Kazmi <sykazmi@cisco.com>

tap: revert clean-up when linux will delete the tap interface

Type: fix
Ticket: VPP-1766

revert e4ac48e792f4eebfce296cfde844ee73b1abd62f

Change-Id: I03feea4008a47859d570ad8d1d08ff3f30d139ef
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>
(cherry picked from commit 623a1b7053424b539a51faf866ab839d3da3f45b)

ea397f5a 04-Sep-2019 jialv01 <Jianlin.Lv@arm.com>

build: fix unsupported CMake comparison operation

VERSION_GREATER_EQUAL is not supported before CMake version 3.7.

Type: fix

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
Change-Id: Id690b7b7c26121f9d289ebd0aaea0860be63795f

254c1b0d 03-Sep-2019 Filip Tehlar <ftehlar@cisco.com>

dpdk: fix extended stats

Extended stats are not displayed due to incorrect condition.

Type: fix
Change-Id: Ie04664e6274137462dce832bf7ee06204cd77be5
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>

4682feb1 02-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

bfd: API cleanup

Use consistent API types.

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I4b91ebe8aadbec8b95716ed1cde4b0a13eee3a3f
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

0f09a828 07-Aug-2019 Steven Luong <sluong@cisco.com>

stats: add /if/<n>/<n>/state for lacp interface state

Add /if/lacp/<bond-sw_if_index>/<slave-sw_if_index>/state

<bond-sw_if_index> is a vector of the bond sw_if_index
<slave-sw_if_index> is a vector of the slave sw_if_index
Content is the integer value of the lacp actor state. The state is actually
a bitfield as described in the lacp protocol spec.

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ic6eca8ce2a1acd2d858e4e50b7eac1d000ea08e5
Signed-off-by: Ole Troan <ot@cisco.com>

63882357 04-Sep-2019 Jakub Grajciar <jgrajcia@cisco.com>

memif: always enable zero-copy when creating memif using API

Type: fix

Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
Change-Id: I823b6297e1d2bdd438633ec7b877960e6d8423fa

5bb23ecd 31-Aug-2019 Florin Coras <fcoras@cisco.com>

session: improve cli

Type: feature

Allow session cli filtering based on thread index, transport protocol,
session state and range of session pool indices. For instance

show session thread 1 proto tcp state ready range 0 20 verbose

Shows the session ids for the first 20 tcp sessions in thread 1 that are
in ready state.

To avoid excessive output that could reasult in the worker barrier being
held by the main thread for long periods of time, the session cli will
only output:
- session ids (verbose == 1) for a maximum of 50 sessions / worker
- verbose > 1 details for a maximum of 10 sessions

Change-Id: I2cfb351b548e2e0a1d5b4345810be613e2917d17
Signed-off-by: Florin Coras <fcoras@cisco.com>

8b4114e5 03-Sep-2019 Florin Coras <fcoras@cisco.com>

tcp: cc algos handle cwnd on congestion signal

Type: refactor

Change-Id: I15b10a22d0d0b83075a0eef5ef8c09cf76989866
Signed-off-by: Florin Coras <fcoras@cisco.com>

fa20d4c5 12-Jul-2019 Matthew Smith <mgsmith@netgate.com>

ethernet: move dmac filtering to inline function

In eth_input_process_frame(), destination MAC addresses are
compared to the interface hardware address in a loop. Move
this to a separate inline function to facilitate making changes
to the filtering logic more cleanly.

Type: refactor

Change-Id: I0978f01667e78af5214dbbc9ba223f5b84ce6b7e
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

87f0dc73 04-Sep-2019 Damjan Marion <damarion@cisco.com>

avf: reduce default ITR interval

Type: fix
Fixes: b4ff07a

Change-Id: I361ec71944048734b73eec700e32531fb070194e
Signed-off-by: Damjan Marion <damarion@cisco.com>

daa4bff1 28-Aug-2019 Ole Troan <ot@cisco.com>

api: memclnt api use string type.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Idad79286b7730c8e85202c4b8e675ea50f8bbc48
Signed-off-by: Ole Troan <ot@cisco.com>

27eeb87f 03-Sep-2019 Florin Coras <fcoras@cisco.com>

session: avoid bihash list for session tables

Type: fix

Change-Id: I1dbc822061f43fcc25dfa5d1728f5c7575139f45
Signed-off-by: Florin Coras <fcoras@cisco.com>

a6d4e313 03-Sep-2019 Matthew Smith <mgsmith@netgate.com>

ethernet: fix dmac check avx2 loop condition

In eth_input_process_frame(), a loop which checks the destination
MAC address of received packets had a different condition for avx2
than it did for the non-avx2 version of the loop. It could result
in one unnecessary execution of the loop body after all packets
had been processed.

Type: fix
Fixes: 8d6f34e2b1cbfde5702e88686631527d5e1e10a0

Change-Id: Ib673f45917a0dea461987fdc8f0ca318b749fb1a
Signed-off-by: Matthew Smith <mgsmith@netgate.com>

e5ff5a36 23-Aug-2019 Ole Troan <ot@cisco.com>

api: enforce vla is last and fixed string type

Enforce that variable length fields are the last element of API messages.

Add a 'fixed' version of string type, since dealing with
multiple variable length strings turned out too painful
for the C language bindings.

The string type is now:
{
string name[64]; // NUL terminated C-string. Essentially decays to u8 name[64]
string name[]; // Variable length string with embedded len field (vl_api_string_t)
};

The latter notation could be made available to other types as well.
e.g.
{
vl_api_address_t addresses[];
}
instead of

{
u32 n_addr;
vl_api_address_t addresses[n_addr];
};

Type: fix
Change-Id: I18fa17ef47227633752ab50453e8d20a652a9f9b
Signed-off-by: Ole Troan <ot@cisco.com>

b6fde4a8 03-Sep-2019 Ole Troan <ot@cisco.com>

stats: memory leak with per-node-counters on

vlib_node_get_nodes() creates a duplicate node structure which was never freed.

Type: fix
Fixes: 1ddbc0138b
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ib1200854937faaa694b398607d2f0ba65aa81c01

a03d25d3 03-Sep-2019 Benoît Ganne <bganne@cisco.com>

gbp: fix set_mac() in unit tests

Do not use low-level sw_interface_set_mac_address() directly and use
higher-level set_mac() instead, otherwise interface local_mac and
configured mac are out-of-sync

Type: fix
Fixes: 25b049484f

Change-Id: I9366e7afb95ef00e25a94ca3b0e6309871169878
Signed-off-by: Benoît Ganne <bganne@cisco.com>

bdf9b977 03-Sep-2019 Dave Barach <dave@barachs.net>

vppinfra: add bihash_init2

Add controls to list / not list a specific bihash in clib_all_bihashes,
to immediately initialize a bihash.

clib_bihash_init2 is now the primary API. It takes a typical args_t
structure. clib_bihash_init becomes a compatibility widget. It
fabricates an args_t and calls init2...

Type: refactor
Ticket: VPP-1758

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Ib3e1304884997cf7025af20bdc67a7dda290f15b

ba0da570 21-Aug-2019 Lijian.Zhang <Lijian.Zhang@arm.com>

tap: fix tap interface not working on Arm issue

The VPP code tries to set all userspace memory in the table via IOCTL
to VHOST_SET_MEM_TABLE. But on aarch64, the userspace address range is
larger (48 bits) than that on x86 (47 bits). Below is an segment from
/proc/[vpp]/maps.

fffb41200000-fffb43a00000 rw-s 00000000 00:0e 532232
/anon_hugepage (deleted)

Instead of setting all userspace memory space to vhost-net, will only set
the address space reserved by pmalloc module during initialization.

Type: fix

Change-Id: I91cb35e990869b42094cf2cd0512593733d33677
Signed-off-by: Lijian Zhang <Lijian.Zhang@arm.com>
Reviewed-by: Steve Capper <Steve.Capper@arm.com>

017dc452 30-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: send rwnd update only if wnd is large enough

Type: feature

Change-Id: I3e97e05a31806afb6b2e84ecf05fb96d285db92e
Signed-off-by: Florin Coras <fcoras@cisco.com>

baf1c7cc 02-Sep-2019 Aloys Augustin <aloaugus@cisco.com>

quic: disable quic plugin by default

Change-Id: I8eb243e80ff043a23cb3efae186164dad6c11ca8
Type: fix
Signed-off-by: Aloys Augustin <aloaugus@cisco.com>

efa119db 30-Aug-2019 Steven Luong <sluong@cisco.com>

tap: interface rx counter not increment correct

vlib_increment_combined_counter takes sw_if_index, not hw_if_index. Using
hw_if_index may work as long as there is no subinterface created to cause
hw_if_index and sw_if_index to differ.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I6db042186eeeacf32250f7ef261af8cd6f5ce56e

d770cfc9 02-Sep-2019 Damjan Marion <damarion@cisco.com>

ipsec ip tcp l2: multiarch nodes cannot be declared as static

Credits to ray.kinsella@intel.com who spotted the issue and identified
root cause.

Type: fix

Change-Id: I4afe74c47769484309f6aebca2de56ad32c8041f
Signed-off-by: Damjan Marion <damarion@cisco.com>

dd0cc9ec 22-Aug-2019 Ping Yu <ping.yu@intel.com>

tls: some rework based on TLS openssl C API

Type: fix

Change-Id: I5d0ac1fe6a6770ab8b3a9c366d10387718391199
Signed-off-by: Ping Yu <ping.yu@intel.com>

be2c2a82 02-Sep-2019 Klement Sekera <ksekera@cisco.com>

tests: run vapi tests by default

Type: fix

Change-Id: I7b190507446fca745fc4bc6abbdeed48f55abdb9
Signed-off-by: Klement Sekera <ksekera@cisco.com>

3a350702 02-Sep-2019 Klement Sekera <ksekera@cisco.com>

tests: fix centos detection

Type: fix
Fixes: defde0f870

Change-Id: Ib81e3610bd0fc22901a902dc76692f1951ead2b8
Signed-off-by: Klement Sekera <ksekera@cisco.com>

ddf625d6 30-Aug-2019 Steven Luong <sluong@cisco.com>

vmxnet3: interface rx counter not increment correctly

vlib_increment_combined_counter takes sw_if_index, not hw_if_index. Using
hw_if_index may work as long as there is no subinterface created to cause
hw_if_index and sw_if_index to differ.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: If50412dc1e84c4f1f5b977b58d0e1aeb5ab8ebe6

4e1fcf49 31-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: fix rx min/max fifo size parsing

Type: fix

Change-Id: Iff4a13da654dbdf7f08bb6d0743b466a1e6be01b
Signed-off-by: Florin Coras <fcoras@cisco.com>

5c89fbf2 30-Aug-2019 Vladimir Kropylev <vladimir.kropylev@enea.com>

session: move svm_fifo_clear_deq_ntf to before calling the app callback

Type: fix

in case the app requests another dequeue notification, it should not be cleared

Change-Id: I7e94e8e30ef098f87f5e7f4880af276970ee5b37
Signed-off-by: Vladimir Kropylev <vladimir.kropylev@enea.com>

2985e0af 29-Aug-2019 Steven Luong <sluong@cisco.com>

vmxnet3: per interface gso support

gso option for vmxnet3 is per VPP process currently. There is no reason why
we cannot provide per interface gso support.

Type: feature

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ife962b52221191050dedd18252b859880ccd7599

90b34ed6 29-Aug-2019 Michael Yu <michael.a.yu@nokia-sbell.com>

devices: fix issue of per_interface_next_index

Per interface, next hop graph node can be customized
with vnet_hw_interface_rx_redirect_to_node function,
but it doesn't work well for af-packet type interface.

In current implementation, with function
af_packet_set_interface_next_node invoked next hop graph
node index can be set to apif->per_interface_next_index,
but it's not set to next0 properly for packet processing
in af_packet_device_input_fn.

Type: fix

Signed-off-by: Michael Yu <michael.a.yu@nokia-sbell.com>
Change-Id: I8e132ddd1c3c01b6f476de78546d4a9389b3ff87
Signed-off-by: Michael Yu <michael.a.yu@nokia-sbell.com>

182d2198 24-Jul-2019 Florin Coras <fcoras@cisco.com>

tcp: force zero window on full rx fifo

Type: feature

Change-Id: I7c5684a9f88e56fd62d83a59c14c4e4a6f096b89
Signed-off-by: Florin Coras <fcoras@cisco.com>

03598c4b 29-Aug-2019 John Lo <loj@cisco.com>

dpdk: enable checksum offload for Intel SRIOV NIC drivers

Type: fix

Signed-off-by: John Lo <loj@cisco.com>
Change-Id: I3ee59106ba45164a4ee3788bf4dcf5bf4c2dc1c2

cedcf608 27-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: improve mss computation

Type: fix

Use different mss for v4 and v6 packets.

Change-Id: Ifcd322c1fd74f749a42bae671dd6cfed8c32b150
Signed-off-by: Florin Coras <fcoras@cisco.com>

22ba3303 30-Aug-2019 Florin Coras <fcoras@cisco.com>

vcl: initialize ctrl_mq in workers

Type: fix

Change-Id: I1b9c8b0f9292f039b941e18d8aca5d734d5f1e77
Signed-off-by: Florin Coras <fcoras@cisco.com>

57c88938 29-Aug-2019 Florin Coras <fcoras@cisco.com>

vcl: allow non-blocking connects

Type: feature

Change-Id: I55349f482ce6781337f747b2f0d2c0a027c3a675
Signed-off-by: Florin Coras <fcoras@cisco.com>

a495a3ea 30-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: track zero rwnd errors

Type: feature

Distinguish between rcv window errors and errors after we advertised a
zero rcv window, i.e., potential window probes.

Change-Id: I6cb453c7aaae456c0a05a8328cfaa55eaca10bf7
Signed-off-by: Florin Coras <fcoras@cisco.com>

fcd5e12b 24-Aug-2019 Guanghua Zhang <ghzhang@fiberhome.com>

session : make sure session layer is enabled when cli operate the sessions.

Type: fix

show session rules tcp
vpp/src/vnet/session/application_namespace.c:34 (app_namespace_get)
assertion `! pool_is_free (app_namespace_pool, _e)' fails
Thread 1 "vpp_main" received signal SIGABRT, Aborted.

Signed-off-by: Guanghua Zhang <ghzhang@fiberhome.com>
Change-Id: I3430339a598a92d0a38826471adeb4547b0b7df4

18fff747 29-Aug-2019 Benoît Ganne <bganne@cisco.com>

stats: null-terminate default socket name

Type: fix
Fixes: d991a798ff

Change-Id: I1920a40d7bbb01593676d9d8564158fdba9452bb
Signed-off-by: Benoît Ganne <bganne@cisco.com>

977c1dec 29-Aug-2019 Steven Luong <sluong@cisco.com>

lacp: continuing input packet trace from device driver

lacp gets the packet from the device driver. Let's continue the input
packet trace's trajectory instead of restarting it in lacp-input.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I4d4537e050742a23f74287086d38d39673ebd60f

e7eba489 25-Aug-2019 Simon Zhang <yuwei1.zhang@intel.com>

ip: remove unused function parameter

Type: refactor

Signed-off-by: Simon Zhang <yuwei1.zhang@intel.com>
Change-Id: I8674ff5f6f6336b256b7df8187afbb36ddef71fb

71f36067 23-Aug-2019 Yulong Pei <yulong.pei@intel.com>

lb: fix memcpy error issue

vl_api_prefix_t size is 21 byte, ip46_address_t size is 16 byte, only copy
16 byte of vl_api_prefix_t to ip46_address_t is not correct.

Type:fix

Change-Id: I35ede7836a0c878d39388b29b15d91bb08f87a07
Signed-off-by: Yulong Pei <yulong.pei@intel.com>

73cad33b 29-Aug-2019 Florin Coras <fcoras@cisco.com>

svm: fix fifo hdr freelist allocation

Type: fix

Change-Id: Ia362ad821db1fd506e973e1844cc3ec74703cc17
Signed-off-by: Florin Coras <fcoras@cisco.com>

f1f5a8a1 04-Apr-2019 Jakub Grajciar <jgrajcia@cisco.com>

bier: API cleanup

Use consistent API types.

Type: fix

Change-Id: I416171c729193e64a68e85a3f1f25d03a9a559d1
Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>

374f706b 22-Aug-2019 Dave Wallace <dwallacelf@gmail.com>

hsa: clean up vpp_echo json output

Type: style

Change-Id: I8dbf2197b78690b94a346d6ff564648ab42f8235
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

f3a8c080 23-Aug-2019 Dave Wallace <dwallacelf@gmail.com>

quic: enable stable quic tests

Type: test

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I041c011ee955acba656b774049b530efe1d50f22

cda35b38 16-Aug-2019 Steven Luong <sluong@cisco.com>

lacp: mark is_mp_safe for show and dump binary API

show and dump binary APIs for lacp neighbors are running in the same thread
as the create and delete interface. There is no need for barrier lock.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Id584bd7408210fcc23b464ef2084f11f88bca58b

29ab3446 26-Aug-2019 Andrew Yourtchenko <ayourtch@gmail.com>

acl: perform a sanity check of ACL rules before creating ACL

Adding acl with incorrect arguments like 1.1.1.1/24 (instead of 1.1.1.0/24)
don't cause a disaster, but doesn't match either, as some might expect.

Add an explicit sanity check which returns an error.

Type: fix

Change-Id: Id1601f4b9c9887d3e7e70aac419d1f1de0c0e012
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

eef61bb8 27-Aug-2019 Florin Coras <fcoras@cisco.com>

session: fix unbind coverity warning

Type:fix

Change-Id: If4fce6bd9b06ed545d72df847afd6a74cdefe042
Signed-off-by: Florin Coras <fcoras@cisco.com>

50059cca 28-Aug-2019 Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

quic: Fix listener vpp_session_handle

Type: fix

Change-Id: I19f70403e15cd180e9d337fbdad47191de333b34
Signed-off-by: Nathan Skrzypczak <nathan.skrzypczak@gmail.com>

1ec093fe 27-Aug-2019 Benoît Ganne <bganne@cisco.com>

rdma: fix pending packets check on tx

Fix coverity CID 203636: Control flow issues (NO_EFFECT).
This greater-than-or-equal-to-zero comparison of an unsigned value is
always true. "n_left_from >= 0U".

Type: fix
Fixes: e7e8bf37f100b20acb99957572f1796f648c2853

Change-Id: Ibbf8c82defb12d6d532345eea657d5f300e6a514
Signed-off-by: Benoît Ganne <bganne@cisco.com>

670027a5 27-Aug-2019 Neale Ranns <nranns@cisco.com>

ipsec: Add 'detail' option to 'sh ipsec sa'

Type: feature

with detail option prints all details for all SAs

Change-Id: Ic3c423c085dfc849cf9c3e18a6f624b82150d961
Signed-off-by: Neale Ranns <nranns@cisco.com>

5ad541ee 27-Aug-2019 Steven Luong <sluong@cisco.com>

interface: Remove residual dpdk bonding code

dpdk bonding code was removed in 19.08. However, there are still references
to VNET_SW_INTERFACE_FLAG_BOND_SLAVE which was set by the already removed
code.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I949a7281e6273f2733dd7532cc4a3bb4f3ce30de

458089bb 21-Aug-2019 Florin Coras <fcoras@cisco.com>

session: move ctrl messages from bapi to mq

Type:refactor

Moves connect, disconnect, bind, unbind and app detach to message
queue from binary api. Simplifies app/vcl interaction with the session
layer since all session control messages are now handled over the mq.

Add/del segment messages require internal C api changes which affect all
builtin applications. They'll be moved in a different patch and might
not be back portable to 19.08.

Change-Id: I93f6d18e551b024effa75d47f5ff25f23ba8aff5
Signed-off-by: Florin Coras <fcoras@cisco.com>

7adaa226 27-Aug-2019 Ole Troan <ot@cisco.com>

api: revert use string type for strings in memclnt.api

This reverts commit 2959d42feb576c0e00c28c4e27658b25f6c783e9.
Lacks client side fixes.

Type: fix
Change-Id: Ib94b18e74325cede41ed1733e57896f17a952526
Signed-off-by: Ole Troan <ot@cisco.com>

2cdcd0cf 27-Aug-2019 Neale Ranns <nranns@cisco.com>

ipsec: Fix NULL encryption algorithm

Type: fix
Ticket: VPP-1756

the block-size was set to 0 resulting in incorrect placement of the ESP
footer.

add tests for NULL encrypt + integ.

Change-Id: I8ab3afda8e68f9ff649540cba3f2cac68f12bbba
Signed-off-by: Neale Ranns <nranns@cisco.com>

8e9e0ecc 27-Aug-2019 Klement Sekera <ksekera@cisco.com>

ip: reassembly: remove unnecessary code

Type: refactor

Change-Id: I30cb324006c3c6ab88d01c044cf80fab3a34f13a
Signed-off-by: Klement Sekera <ksekera@cisco.com>

2959d42f 22-Aug-2019 Ole Troan <ot@cisco.com>

api: use string type for strings in memclnt.api

Explicitly using string type in API allows for autogenerating tools to print
strings instead of hex-dumping byte strings.

Type: fix
Signed-off-by: Ole Troan <ot@cisco.com>
Signed-off-by: Klement Sekera <ksekera@cisco.com>
Change-Id: I573962d6b34d5d10aab9dc6a5fdf101c9b12a6a6
Signed-off-by: Ole Troan <ot@cisco.com>

3f1964d2 22-Aug-2019 Mohsin Kazmi <sykazmi@cisco.com>

gso: fix segmentation when gso_size greater than vlib buffer size

Type: fix
Ticket: VPP-1751

Change-Id: I5ffb078492adc97374290de404f2ec0102b75184
Signed-off-by: Mohsin Kazmi <sykazmi@cisco.com>

61b28ba6 20-Aug-2019 Andrew Yourtchenko <ayourtch@gmail.com>

misc: 19.08 new features

The full RELEASE.md diff is b610f2022c9f4e10a922e7b57c80ec77cd45d021

Change-Id: Ide6d85d41bdc836a03390a50ab94f6ebbaae0b28
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit 1c586de48cc76fc6eac50f5d87003e2a80aa43e7)

7cd982d0 17-Aug-2019 Andrew Yourtchenko <ayourtch@gmail.com>

misc: VPP 19.08 Release Notes

Change-Id: I81c7ad50c66b4b8d690e87aad1f3c16af065fc85
Type: docs
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>
(cherry picked from commit b610f2022c9f4e10a922e7b57c80ec77cd45d021)

59ac9c23 26-Aug-2019 Andrew Yourtchenko <ayourtch@gmail.com>

ip: ip6_preflen_to_mask incorrect result for prefix len > 64

The as_u64[0] in the result was not correctly filled in for
longer prefix lengths.

Type: fix
Fixes: 1c7104514c

Change-Id: I871772c618475396d1c1c4c699ff77e35097f07e
Signed-off-by: Andrew Yourtchenko <ayourtch@gmail.com>

e7e8bf37 21-Aug-2019 Benoît Ganne <bganne@cisco.com>

rdma: use rings for buffers management

Refactor rdma driver for improved performance and prepare for raw
datapath access.

Type: refactor

Change-Id: Iae31872055a6947708ea9f430bd1dc083ea63b5a
Signed-off-by: Benoît Ganne <bganne@cisco.com>

92f190a8 23-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: fix byte tracker samples flush

Type: fix

Change-Id: I3b4cb8fc17387693d6ad6cdef004ca99cd56bc23
Signed-off-by: Florin Coras <fcoras@cisco.com>

a2ac36c9 23-Aug-2019 Ole Troan <ot@cisco.com>

vppapitrace: add text output

Add new argument --todump, to mimic the VPP
api trace dump output.

Type: feature
Signed-off-by: Ole Troan <ot@cisco.com>
Change-Id: Ia8c845b321ef9d55dd6e2f388165ca5498406ab6

84a563ae 22-Aug-2019 Dave Barach <dave@barachs.net>

dns: fix trivial multi-thread deadlock

Add a simple lock trace mechanism

Type: fix
Ticket: VPP-1752

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: Idc82b1ad59adb0f7c185d27ced57e9a4c25ce62f

a43c93f8 22-Aug-2019 Dave Wallace <dwallacelf@gmail.com>

tests: move plugin tests to src/plugins/*/test

- Relocate plugin tests for 'make test' into
src/plugins/*/test so that plugin test cases
are co-located with the plugin source code.

Type: refactor

Signed-off-by: Dave Wallace <dwallacelf@gmail.com>
Change-Id: I503e6a43528e14981799b735fa65674155713f67
Signed-off-by: Dave Wallace <dwallacelf@gmail.com>

34af0ccf 21-Aug-2019 Dave Barach <dave@barachs.net>

dns: make the dns name resolver a plugin

Type: refactor
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I823c2cd307a4613653a2d20f564dda062d4da31b

2ca9a84b 22-Aug-2019 Damjan Marion <damarion@cisco.com>

avf: properly set irq queue masks

Type: fix
Fixes: ae91180

Change-Id: I9c55c3fdf41089d337b998e2e28abb23d81525ef
Signed-off-by: Damjan Marion <damarion@cisco.com>

22bb417e 12-Aug-2019 Filip Varga <fivarga@cisco.com>

nat: handoff traffic matching for dynamic NAT

Type: feature

Change-Id: I5c5af6f9acb340cc674323305104b8ce23e6d21d
Signed-off-by: Filip Varga <fivarga@cisco.com>

95e091b2 22-Aug-2019 Klement Sekera <ksekera@cisco.com>

ip: fix merge issue

Signed-off-by: Klement Sekera <ksekera@cisco.com>

Change-Id: Idd64b0b3eedb7179f6d316b66cea8160ad577990
Type: fix
Fixes: 630ab5846bceddf8d663e9f488a2dc0378949827
Signed-off-by: Klement Sekera <ksekera@cisco.com>

ab489925 21-Aug-2019 Steven Luong <sluong@cisco.com>

vlib: fix null pointer crash on strncmp

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff4b71de0 in __strncmp_sse42 () from /lib64/libc.so.6
(gdb) up
up
vm=0x7ffff6664d40 <vlib_global_main>, addr=0x7fffb4bec6d0,
ids=0x7fffb31675f0 <avf_pci_device_ids>, handle=0x7fffb4bec594)
at /usr/src/debug/vpp-20.01/src/vlib/linux/pci.c:1250
1250 if (strncmp ("vfio-pci", (char *) di->driver_name, 8) == 0)
(gdb) p di
p di
$1 = (vlib_pci_device_info_t *) 0x7fffb6446164
(gdb) p di->driver_name
p di->driver_name
$2 = (u8 *) 0x0
(gdb)

driver_name may be null. strncmp is not forgiving. Change to use C11 safeC
version.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I1777a5966ceee7409d7bde86c30b14dc75534a5a

b6834750 21-Aug-2019 Benoît Ganne <bganne@cisco.com>

hsa: fix http response

http_ok is a const null-terminated string, not a vector.

Type: fix
Fixes: 844a36d1a6

Change-Id: Ide1a23506d9f43cd33c3a4b8ba11658c67fbecc8
Signed-off-by: Benoît Ganne <bganne@cisco.com>

1096b46d 21-Aug-2019 Vratko Polak <vrpolak@cisco.com>

sr: fix sr_set_encap_source reply

Can we get a reply macro that would avoid such copypaste errors?

Type: fix

Change-Id: I753efb1d82fced668c27f2e44b0318bfd31c0a23
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

747b3d8b 21-Aug-2019 Benoît Ganne <bganne@cisco.com>

vcl: fix ldp_set_app_name overflow

In case of overflow, we null-terminate the parameter ('app_name')
instead of ldp global name ('ldp->app_name').
Moreover, snprintf() always safely null-terminate the destination string
even in case of overflow.

Type: fix
Fixes: 048b1d6ab7

Change-Id: I4d8b0e020a228e982b6699d652b341c5afe92993
Signed-off-by: Benoît Ganne <bganne@cisco.com>

a436a422 20-Aug-2019 Florin Coras <fcoras@cisco.com>

tcp: add option for always on event logging

Type: feature

Add option to always compile in debugging infra. Debug verbosity can be
controlled via configuration updatable via cli. Compile time inclusion
and configuration of event logging verbosity is still available in order
to minimize event logging impact.

Change-Id: I9d946efe9fa4204fdace1adb1d6588c97b5ae758
Signed-off-by: Florin Coras <fcoras@cisco.com>

c33eddeb 21-Aug-2019 Damjan Marion <damarion@cisco.com>

avf: print queue id in packet trace

Type: feature

Change-Id: If3deb26b9ee3b9e677c9dc50789bf81fe6c11dee
Signed-off-by: Damjan Marion <damarion@cisco.com>

4bf88880 21-Aug-2019 Dave Barach <dave@barachs.net>

dns: add basic functional "make test" case

Type: test
Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I88e93b510d8d4f7b59f3e630539dc7e0264afa47